Re: Review Request: Konqeror Session Applet: Allow Keyboard only usage

2009-08-21 Thread Sebastian Kügler
On Saturday 22 August 2009 01:16:19 Sebastian Kügler wrote: > There's also a kate session applet, I'm pretty sure no one would object it > receiving the same fix. Nevermind, I saw that it was actually the first one you fixed ... :D -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID:

Re: Review Request: Konqeror Session Applet: Allow Keyboard only usage

2009-08-21 Thread Sebastian Kügler
On Thursday 20 August 2009 14:23:29 Conrad Hoffmann wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1367/ > --- > > Review reques

Re: A contact's plasmoid video

2009-08-21 Thread Sebastian Kügler
On Thursday 20 August 2009 17:42:35 Adenilson Cavalcanti wrote: > At this moment, it is really more an exercise with Qt animation and plasma. > The code is still pretty much a mess and definitely needs quite a lot of > cleanup before being made public. Maybe after this cleanup we could host it > in

Re: KDE/kdebase/workspace/plasma/applets/devicenotifier

2009-08-21 Thread Sebastian Kügler
On Friday 21 August 2009 12:05:15 Alessandro Diaferia wrote: > SVN commit 1013934 by adiaferia: > > update the space info patch and actually commit it - soliddevice engine > issue fixed CCMAIL:plasma-devel@kde.org Thanks! -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
> 2009/8/21 Alessandro Diaferia > > > 2009/8/21 Giulio Camuffo > > > >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote: > >> > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifie > >>r.h, line 106 > >> > >> > > < > >> > >> http://reviewboard.kde.org/r/1370/diff/3/?fil

Re: Working method for focusing widgets in panels and keyboard navigation for Tasks applet

2009-08-21 Thread Chani
On August 21, 2009 13:29:17 Marco Martin wrote: > On Friday 21 August 2009, Emdek wrote: > > Hello > > > > As we talked yesterday on IRC, on notmart request I'll now describe how > > works (to allow to discuss that on Tokamak) this quite simply hack, > > workaround, only sensible method (;-)) or na

Re: Working method for focusing widgets in panels and keyboard navigation for Tasks applet

2009-08-21 Thread Marco Martin
On Friday 21 August 2009, Emdek wrote: > Hello > > As we talked yesterday on IRC, on notmart request I'll now describe how > works (to allow to discuss that on Tokamak) this quite simply hack, > workaround, only sensible method (;-)) or name it whatever you like. > as i said it's kinda brutal, the

Re: Review Request: Konqeror Session Applet: Allow Keyboard only usage

2009-08-21 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1367/#review2116 --- Ship it! yep, that's fine, and such a simple patch you could've skipp

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-08-21 19:26:43.299357) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Alessandro Diaferia
2009/8/21 Alessandro Diaferia > > > 2009/8/21 Giulio Camuffo > >> >> >> > On 2009-08-21 17:23:18, Alessandro Diaferia wrote: >> > > >> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h, >> line 106 >> > > < >> http://reviewboard.kde.org/r/1370/diff/3/?file=10433#file104

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
> On 2009-08-21 17:23:18, Alessandro Diaferia wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h, > > line 106 > > > > > > consider deleting white spaces > > eh, the problem with whit

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2112 --- The patch looks pretty good to me and really a great step forward in u

Re: Review Request: Add setSubTitlePolicy() method to Plasma::Delegate

2009-08-21 Thread Dmitry Suzdalev
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1357/ --- (Updated 2009-08-21 15:50:26.488754) Review request for Plasma, Aaron Seigo and

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-08-21 14:05:09.360260) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
> On 2009-08-20 18:39:43, Kevin Ottens wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 338 > > > > > > Urgh! Please no! > > > > You're hard depending on HAL now

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
> On 2009-08-21 13:15:51, Beat Wolf wrote: > > how much does this overlap with > > http://wm161.net/2009/08/12/device-automounter-in-kdereview-srpm-for-fedora-11/ > > ? well, as Kevin said in his comment, I should remove the automounter from my patch because in 4.4 there will be an automounter

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2106 --- how much does this overlap with http://wm161.net/2009/08/12/device-aut

Re: [PATCH] BUG 203716 give user a hint when adding same application into quicklaunch

2009-08-21 Thread 潘卫平(Peter Pan)
潘卫平(Peter Pan) 写道: > Lukas Appelhans 写道: >> Am Donnerstag 20 August 2009 04:44:29 schrieb 潘卫平(Peter Pan): >>> Lukas Appelhans 写道: Am Mittwoch 19 August 2009 15:51:18 schrieb 潘卫平(Peter Pan): > Lukas Appelhans 写道: >> Am Mittwoch 19 August 2009 14:25:09 schrieb 潘卫平(Peter Pan): >>> Luk

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-08-21 12:47:32.535164) Review request for Plasma. Changes --

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Giulio Camuffo
> On 2009-08-20 18:39:43, Kevin Ottens wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 369 > > > > > > And what will happen for computers faster/slower than your? You sh

Re: Review Request: big revamp of Device Notifier

2009-08-21 Thread Alessandro Diaferia
2009/8/20 Björn Ruberg > On Donnerstag 20 August 2009, David Baron wrote: > > Is this the one that has been on kde-look for a while? Sounds like it. > > > > This is a worthy revamp of the original device-notifier plasmoid and in > 4.3 > > it is actually readable. The "last mounted" tooltip is of

Re: Review Request: Patch to add free space indicator into device notifier plasmoid

2009-08-21 Thread Alessandro Diaferia
2009/8/18 Sebastian Kügler > On Tuesday 18 August 2009 13:44:50 Alessandro Diaferia wrote: > > 2009/8/17 Sebastian Kügler > > I've updated the patch and now it correctly shows the capacity bar. > There's > > only a little issue: as soon as the device gets "mounted" the engine does > > not return

KDE/kdebase/workspace/plasma/applets/devicenotifier

2009-08-21 Thread Alessandro Diaferia
SVN commit 1013934 by adiaferia: update the space info patch and actually commit it - soliddevice engine issue fixed CCMAIL:plasma-devel@kde.org M +2 -1 CMakeLists.txt M +11 -0 devicenotifier.cpp A devicespaceinfodelegate.cpp [License: LGPL (v2+)] A

Working method for focusing widgets in panels and keyboard navigation for Tasks applet

2009-08-21 Thread Emdek
Hello As we talked yesterday on IRC, on notmart request I'll now describe how works (to allow to discuss that on Tokamak) this quite simply hack, workaround, only sensible method (;-)) or name it whatever you like. Some background I've did Run Command applet in October (my first plasmoid an