Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-29 Thread 潘卫平(Peter Pan)
Aaron J. Seigo 写道: > On Wednesday 29 July 2009, 潘卫平 wrote: >> Third, I set the BusyWidgest's geometry in AbstractTaskItem::drawTask(), >> so it can get the proper geometry. > > patch looks good; i only wonder if there's a better place to put the > setGeometry for the busy widget than in a paintEv

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Aaron J. Seigo
On Wednesday 29 July 2009, Ryan P. Bitanga wrote: > On Thu, Jul 30, 2009 at 2:04 AM, Aaron J. Seigo wrote: > > On Wednesday 29 July 2009, Ryan P. Bitanga wrote: > >> On Thu, Jul 30, 2009 at 12:43 AM, Aaron J. Seigo wrote: > >> > On Wednesday 29 July 2009, Ryan P. Bitanga wrote: > >> > >> so I think

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Ryan P. Bitanga
On Thu, Jul 30, 2009 at 2:04 AM, Aaron J. Seigo wrote: > On Wednesday 29 July 2009, Ryan P. Bitanga wrote: >> On Thu, Jul 30, 2009 at 12:43 AM, Aaron J. Seigo wrote: >> > On Wednesday 29 July 2009, Ryan P. Bitanga wrote: >> so I think the best place to do this would be in >> the destructor of FindM

Re: Picture Frame Widget

2009-07-29 Thread Aaron J. Seigo
(cc'ing Aron as he's not subscribed (yet? ;) to plasma-devel) On Wednesday 29 July 2009, Aron Hoekstra wrote: > Offer the ability to right-click on a presently displayed image and > "exclude" it from the slideshow. i think this has been requested before, too. would be nice to see it implemented.

Re: Review Request: Add clear() method to Plasma::TabBar widget

2009-07-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1146/#review1842 --- i assume the reason there is no QTabWidget::clear() is that it isn't s

Picture Frame Widget

2009-07-29 Thread Aron Hoekstra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think the Picture Frame/Slideshow Widget is great, thanks for developing it. I'd like to offer a few suggestions: Offer the ability to right-click on a presently displayed image and "exclude" it from the slideshow. Of course, Transition Effects wou

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Aaron J. Seigo
On Wednesday 29 July 2009, Ryan P. Bitanga wrote: > On Thu, Jul 30, 2009 at 12:43 AM, Aaron J. Seigo wrote: > > On Wednesday 29 July 2009, Ryan P. Bitanga wrote: > >> Because we can launch a new query while jobs for an existing query are > >> still executing, any slots that are connected to prepare

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-29 Thread Aaron J. Seigo
On Wednesday 29 July 2009, 潘卫平 wrote: > Third, I set the BusyWidgest's geometry in AbstractTaskItem::drawTask(), > so it can get the proper geometry. patch looks good; i only wonder if there's a better place to put the setGeometry for the busy widget than in a paintEvent, but this seems like it

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Ryan P. Bitanga
On Thu, Jul 30, 2009 at 12:43 AM, Aaron J. Seigo wrote: > On Wednesday 29 July 2009, Ryan P. Bitanga wrote: >> Because we can launch a new query while jobs for an existing query are >> still executing, any slots that are connected to prepare and teardown >> have to be threadsafe. > > setup and tead

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-29 Thread 潘卫平
Aaron J. Seigo 写道: > On Thursday 23 July 2009, 潘卫平(Peter Pan) wrote: >> Taht will cover the icon and looks mussy. >> I prefer to let it over the text. > > hm.. ok, how about on the right side of the button then, where the # of > windows usually appears when there are several windows grouped? > > al

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Aaron J. Seigo
On Wednesday 29 July 2009, Ryan P. Bitanga wrote: > Because we can launch a new query while jobs for an existing query are > still executing, any slots that are connected to prepare and teardown > have to be threadsafe. setup and teadrown should be called and executed from the main thread. queries

Re: KDE MicroBlog (Twitter) update doesn't work

2009-07-29 Thread Ryan P. Bitanga
It had nothing to do with the dataengine or anywhere in the service framework. Someone accidentally commented out a line in the applet. I committed the fix. checkout r1004151 of the applet. On Wed, Jul 29, 2009 at 8:01 PM, Ryan P. Bitanga wrote: > On Wed, Jul 29, 2009 at 6:41 PM, Gerhard > Gappmei

Re: KDE MicroBlog (Twitter) update doesn't work

2009-07-29 Thread Ryan P. Bitanga
On Wed, Jul 29, 2009 at 6:41 PM, Gerhard Gappmeier wrote: > > > No, I'm directly connected to the Internet, no proxy. Receiving messages > works. > > Have you tested with Twitter, or with identica? I tested both before but I svn up'd to 1003809 and compiled everything just now and I'm getting the

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Ryan P. Bitanga
On Wed, Jul 29, 2009 at 7:17 PM, Martin Gräßlin wrote: > Am Mittwoch 29 Juli 2009 12:53:56 schrieb Ryan P. Bitanga: >> Another issue is that teardown is currently only emitted when the >> dialog is hidden. I think the assumption was that there would be a one >> to one correspondence between emissi

Re: Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Martin Gräßlin
Am Mittwoch 29 Juli 2009 12:53:56 schrieb Ryan P. Bitanga: > Hi all, > > I should have thought of this sooner, but upon taking a closer look at > the code, I just realized that we have a few issues with the whole > setup/teardown scenario. > > Because we can launch a new query while jobs for an exi

Issues with setupMatchSession/matchSessionComplete in RunnerManager

2009-07-29 Thread Ryan P. Bitanga
Hi all, I should have thought of this sooner, but upon taking a closer look at the code, I just realized that we have a few issues with the whole setup/teardown scenario. Because we can launch a new query while jobs for an existing query are still executing, any slots that are connected to prepar

Re: KDE MicroBlog (Twitter) update doesn't work

2009-07-29 Thread Gerhard Gappmeier
Ryan P. Bitanga schrieb: > On Wed, Jul 29, 2009 at 5:49 PM, Ryan P. Bitanga > wrote: > >> On Wed, Jul 29, 2009 at 4:11 PM, Gerhard >> Gappmeier wrote: >> >>> I reverted back to 974104 (2009-05-28), before a bigger change was done, but >>> this also didn't work. >>> >>> So I took a look at

Re: KDE MicroBlog (Twitter) update doesn't work

2009-07-29 Thread Ryan P. Bitanga
On Wed, Jul 29, 2009 at 5:49 PM, Ryan P. Bitanga wrote: > On Wed, Jul 29, 2009 at 4:11 PM, Gerhard > Gappmeier wrote: >> >> I reverted back to 974104 (2009-05-28), before a bigger change was done, but >> this also didn't work. >> >> So I took a look at the code to see how updates are sent. >> Unfor

Re: KDE MicroBlog (Twitter) update doesn't work

2009-07-29 Thread Ryan P. Bitanga
On Wed, Jul 29, 2009 at 4:11 PM, Gerhard Gappmeier wrote: > Hi > > for while now I'm not able to send updates to Twitter using the MicroBlog > plasmoid, whereas receiving messages works. > > Yesterday I reverted the microblog dataengine to older versions to see when it > was broken. > > @aseigo, th

Re: Review Request: Add next and previous buttons to Frame applet

2009-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1028/#review1833 --- Ship it! Patch looks fine, other than some minor coding style things,

Re: Conky

2009-07-29 Thread David Baron
On Wednesday 29 July 2009 00:08:45 Aaron J. Seigo wrote: > On Tuesday 28 July 2009, David Baron wrote: > > This is a very versatile, configurable system/email/xmms2/you-name-it > > i've read reviews about it and it seems very un-user-friendly in it's > configuration. what does it have that our plas

KDE MicroBlog (Twitter) update doesn't work

2009-07-29 Thread Gerhard Gappmeier
Hi for while now I'm not able to send updates to Twitter using the MicroBlog plasmoid, whereas receiving messages works. Yesterday I reverted the microblog dataengine to older versions to see when it was broken. @aseigo, thx for your hint, but rev 995814 has not broken it. Also a previous ver