Re: Review Request: Quicklaunch: Add drag and drop support within plasmoid

2009-05-09 Thread Shafqat Bhuiyan
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/685/ --- (Updated 2009-05-09 23:04:05.499032) Review request for Plasma. Changes ---

Re: Review Request: Quicklaunch Plasmoid: Add drag and drop support

2009-05-09 Thread Shafqat Bhuiyan
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/685/ --- (Updated 2009-05-09 22:03:55.636589) Review request for Plasma. Summary (update

Re: Review Request: Quicklaunch: Add drag and drop support for quicklaunch applet

2009-05-09 Thread Shafqat Bhuiyan
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/685/ --- (Updated 2009-05-09 22:02:15.766838) Review request for Plasma. Summary (update

Review Request: PATCH: Add drag and drop support for quicklaunch applet

2009-05-09 Thread Shafqat Bhuiyan
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/685/ --- Review request for Plasma. Summary --- This patch allows for icons in the qu

Re: Review Request: Fix the 0600GMT=sunrise, 1800GMT=sunset bug in the BBC Weather Ion

2009-05-09 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/684/#review1100 --- what version of the GPL is it licensed under? the source code you got t

Re: Code snippet review for plasmate

2009-05-09 Thread Aaron J. Seigo
On Saturday 09 May 2009, Shantanu Tushar Jha wrote: > I looked at the techbase about kparts and studied kwrite code a bit, and > finally started to try with embedding a text editing kpart in Plasmate. > I know there's a lot to be done. Just to make sure if I'm going in the > right direction and to

Re: Review Request: Moonrise/set for time dataengine

2009-05-09 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/680/#review1099 --- putting things in TimeSource was a way to avoid constant allocations. o

Re: Review Request: Notes plasmoid: change text color before any text, new color is now honored

2009-05-09 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/679/#review1098 --- /trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp

Review Request: Fix the 0600GMT=sunrise, 1800GMT=sunset bug in the BBC Weather Ion

2009-05-09 Thread Andrew Coles
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/684/ --- Review request for Plasma. Summary --- To give an icon depicting the current

Code snippet review for plasmate

2009-05-09 Thread Shantanu Tushar Jha
I looked at the techbase about kparts and studied kwrite code a bit, and finally started to try with embedding a text editing kpart in Plasmate. I know there's a lot to be done. Just to make sure if I'm going in the right direction and to find possible problems, I've attached a patch that displays

Re: Review Request: Notes plasmoid: change text color before any text, new color is now honored

2009-05-09 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/679/ --- (Updated 2009-05-09 04:47:06.598306) Review request for Plasma. Summary ---

Review Request: Moonrise/set for time dataengine

2009-05-09 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/680/ --- Review request for Plasma. Summary --- Moonrise/set patch using new TimeSour

Review Request: Notes plasmoid: change text color before any text, new color is now honored

2009-05-09 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/679/ --- Review request for Plasma. Summary --- The upstream Qt bug is fixed but it d