Re: Review Request: Prevent krunner to run the wrong command when "fast" typing

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/172/#review255 --- i don't think this patch is correct. the idea is that when the query cha

Re: tasks applet: group popup

2009-02-23 Thread Christian Mollekopf
On Tuesday 24 February 2009 00:24:50 Aaron J. Seigo wrote: > On Monday 23 February 2009, Christian Mollekopf wrote: > > Hi, > > > > I already started with the popup and it seems to work quite nicely, but i > > would like to have your comments on how i intend to go on. > > just for my own clarity, w

Review Request: Prevent krunner to run the wrong command when "fast" typing 2

2009-02-23 Thread wilderkde
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/173/ --- Review request for Plasma. Summary --- Please see preceding request Diffs

Review Request: Prevent krunner to run the wrong command when "fast" typing

2009-02-23 Thread wilderkde
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/172/ --- Review request for Plasma. Summary --- This is an attempt to solve https://b

Re: tasks applet: group popup

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Christian Mollekopf wrote: > Hi, > > I already started with the popup and it seems to work quite nicely, but i > would like to have your comments on how i intend to go on. just for my own clarity, which popup are you referring to exactly? > For displaying i think it wo

tasks applet: group popup

2009-02-23 Thread Christian Mollekopf
Hi, I already started with the popup and it seems to work quite nicely, but i would like to have your comments on how i intend to go on. According to marcos suggestions i'm currently displaying a LayoutWidget in a Plasma::Dialog which leads to a similar result as the current popupMenu. Since d

Re: configAccepted()

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Toussis Manolis wrote: > Because it is explicity called in ~applet. Sorry again for the post. :-) no problems. i prefer that it's a bug in your code than libplasma anyways. ;) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B

Re: configAccepted()

2009-02-23 Thread Toussis Manolis
On Monday 23 February 2009 22:16:16 Aaron J. Seigo wrote: > On Monday 23 February 2009, Toussis Manolis wrote: > > I re-implementing in my applet the configAccepted() to store the > > settings... > > configChanged() you mean? there is no configAccepted in Plasma::Applet. or > are you connecting to

Re: configAccepted()

2009-02-23 Thread Toussis Manolis
ignore the previous message. On Monday 23 February 2009 22:01:06 Toussis Manolis wrote: > I re-implementing in my applet the configAccepted() to store the > settings... > > The thing is that I came across a strange issue. > I run the applet if I invoke the config interface, and press ok... > co

Re: configAccepted()

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Toussis Manolis wrote: > I re-implementing in my applet the configAccepted() to store the > settings... configChanged() you mean? there is no configAccepted in Plasma::Applet. or are you connecting to configAccepted yourself? > The thing is that I came across a strang

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Cukic
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/161/ --- (Updated 2009-02-23 12:13:18.513988) Review request for Plasma. Summary ---

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Ivan Čukić wrote: > > writing code for the current implementation versus what the code ought to > > do itself is a good way to end up with future bugs. trust me, i do it all > > the time ;-p > > hear, hear! :) > > So, is it SHIP IT? yer :) -- Aaron J. Seigo humru othr

configAccepted()

2009-02-23 Thread Toussis Manolis
I re-implementing in my applet the configAccepted() to store the settings... The thing is that I came across a strange issue. I run the applet if I invoke the config interface, and press ok... configAccepted is called once. Then I close the applet , and configAccepted is called once more. All th

Re: plasma::applet painter

2009-02-23 Thread Toussis Manolis
On Saturday 21 February 2009 20:31:10 Aaron J. Seigo wrote: > On Saturday 21 February 2009, Toussis Manolis wrote: > > Thank you very much on answering my question. > > > > On Saturday 21 February 2009 18:34:27 Aaron J. Seigo wrote: > > > On Saturday 21 February 2009, Toussis Manolis wrote: > > > >

Re: Review Request: simple animation of tabbar icons everytime kickoff is launched by pressing the KDE start button

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/63/#review252 --- btw, some general input on the animation: * it should probably be a litt

Re: Review Request: manage layout direction in the layoutwidget of the tasks applet

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/169/#review251 --- Ship it! sensible steps forward /trunk/KDE/kdebase/workspace/plasma/a

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Čukić
> writing code for the current implementation versus what the code ought to > do itself is a good way to end up with future bugs. trust me, i do it all > the time ;-p hear, hear! :) So, is it SHIP IT? ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: Delete svgBackground also when svgFilename is empty

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/150/#review250 --- Ship it! obvious improvement :) - Aaron On 2009-02-22 01:24:23, Petr

Re: Review Request: Display correct week number in the calendar widget

2009-02-23 Thread Aaron Seigo
> On 2009-02-18 11:22:20, Aaron Seigo wrote: > > the week # should be calculated properly according to the region settings. > > adding the weekday is going to cause layouting problems (which you've > > already run into :) and just be rather confusing. > > > > on the other hand, it makes intern

Re: Review Request: simple animation of tabbar icons everytime kickoff is launched by pressing the KDE start button

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/63/#review248 --- posting a screencast would be helpful so people can see what it does. t

Re: Review Request: Make web shortcut icons look better in krunner

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/47/#review247 --- Ship it! i can't see the diff (rb seems to have messed it up) but the id

Re: Review Request: add method addIconAction(QAction*, ActionCorner) to Plasma::IconWidget plus a bonus :)

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/14/#review245 --- so the reason i didn't expose the corner enum was so that we weren't stuc

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Cukic
> On 2009-02-23 11:07:49, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/dialog.cpp, lines 424-427 > > > > > > shouldn't this be: > > > > if (d->widget) { > > d->widget->setFocus(); > > } > > > >

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/161/#review244 --- as long as this doesn't result in the dialog actually taking focus from

Re: SoConcepts

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Jordi Polo wrote: > Last year someone thought of Plasma participating in SoC independent from > KDE on the observation that the GNOME ecosystem receive more SoC slots from > Google than KDE probably because they present different projects. not something google is intere

Re: taskmanager project

2009-02-23 Thread Aaron J. Seigo
On Monday 23 February 2009, Casper Clemence wrote: > p.s. Is there a way to get Solid to call-back applications when a resource > becomes available. Solid::Networking::notifier() emits the following signals: void statusChanged( Solid::Networking::Status status ); void shouldConnect(); void shoul

Review Request: manage layout direction in the layoutwidget of the tasks applet

2009-02-23 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/169/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- This pa

Re: SoConcepts

2009-02-23 Thread Jordi Polo
Last year someone thought of Plasma participating in SoC independent from KDE on the observation that the GNOME ecosystem receive more SoC slots from Google than KDE probably because they present different projects. On Mon, Feb 23, 2009 at 8:10 PM, Riccardo Iaconelli wrote: > On Thursday 19 Feb

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Cukic
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/161/ --- (Updated 2009-02-23 06:55:27.189241) Review request for Plasma. Changes ---

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Čukić
On Monday, 23. February 2009. 14.20.40 you wrote: > I closed some bugs because people where complaining that the notifier took > the focus. The use case was : > > I typing a mail and a notification pop, then the focus moved to the > notifier, i don't care, i want to continue typing my mail... > > I

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Alexis Ménard
I closed some bugs because people where complaining that the notifier took the focus. The use case was : I typing a mail and a notification pop, then the focus moved to the notifier, i don't care, i want to continue typing my mail... If you are chatting and then the thing pop and steal your focus

Re: Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Cukic
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/161/ --- (Updated 2009-02-23 04:30:15.258007) Review request for Plasma. Summary ---

Review Request: Sets the focus for widget in Plasma::Dialog on show

2009-02-23 Thread Ivan Cukic
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/161/ --- Review request for Plasma. Summary --- Sets the focus of the view and the QG

Re: taskmanager project

2009-02-23 Thread Christian Mollekopf
On Monday 23 February 2009 12:03:43 Casper Clemence wrote: Hi Casper, You may have noticed that i turned the LayoutWidget into a layout last week. And since i was curious i also started to implemented the popup window. It's not yet done but it's already displaying in my local copy with the real

Re: SoConcepts

2009-02-23 Thread Riccardo Iaconelli
On Thursday 19 February 2009 23:25:47 Aaron J. Seigo wrote: > > the idea was to not need a filedialog unless the user is exporting them. > > so when I want to load a containment, I don't think "now where the heck > > did I put that thing?" - I just get a list of stashed containments and > > can loa

Re: taskmanager project

2009-02-23 Thread Casper Clemence
Hey dudes. I'm really just checking in to say that I'm still committed to contributing. My laptop died on the week I thought I would have spare time to get started so that's why you haven't heard progress from me. Thanks for your help. p.s. Is there a way to get Solid to call-back applications w