Re: Dataengine Questions, Proposal?

2009-02-01 Thread Sebastian Kügler
On Thursday 22 January 2009 17:02:56 David Baron wrote: > I would like to try the dataengine that interfaces to KDEPIM contacts. So > how do I: > > Register the applet with it/for it? > > What datasource do I get? Obviously this is not a polled item and > getDataSource should trigger the signal. T

[PATCH] applet message boxes

2009-02-01 Thread Marco Martin
Hi all, this is an old rotting patch i had on review board since ages, i would like to have it sorted out, since i wanted to continue working on that thing (and not having pending stuff before tokamak :p). this makes possible for applets to display messages as overlays with text, an icon and opt

[PATCH] function to hide the tabbar from Plasma::TabBar

2009-02-01 Thread Marco Martin
Hi guys, review board is not feeling well (upgrading i suppose?) so posting it here anyways, with this patch could be possible to use Plasma::TabBar like a QStackedWidget, i think it makes sense since it has already the double use of a tabbar and a tabwidget, so it would be one thing to rule them

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Alessandro Diaferia
2009/2/1 Guillaume Pothier > 2009/2/1 Alessandro Diaferia : > > I deeply checked and Kephal actually returns correct screen info (2 > > screens, > > the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). > Moreover > > adjustSize() uses Plasma::View::screen() > > in order to resize

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Guillaume Pothier
2009/2/1 Alessandro Diaferia : > I deeply checked and Kephal actually returns correct screen info (2 > screens, > the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). Moreover > adjustSize() uses Plasma::View::screen() > in order to resize the view, and before delaying adjustSize,

Re: Review Request: Plasma::Webview

2009-02-01 Thread 0xDeadC0de
> * properly accept left clicks > A few months ago when i started embedding a qwebview inside a graphics widget would cause left clicks to be ignored (not getting events probably) > * properly accept right clicks > Right clicks did work however > ditto > > * context menu creation > > WebView m

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Alessandro Diaferia
2009/2/1 Guillaume Pothier > Hi Alessandro, sorry I didn't reply earlier, Hi Guillaume, np :) > I was offline this week. > I think your fix is not in the ideal place. I think that what happens > is that you are using a driver that is not xrandr1.2-aware (please > tell me if I'm wrong), ho

Re: Review Request: Plasma::Webview

2009-02-01 Thread Aaron J. Seigo
On Sunday 01 February 2009, 0xDeadC0de wrote: > I'd like to request that plasma webview become full on QWebViews instead > of QWebPages. proxying a widget when we can paint directly to canvas would be a step backwards. let's look at the four issues you describe: * properly accept left clicks i

Re: [PATCH] Multiscreen fix!

2009-02-01 Thread Guillaume Pothier
Hi Alessandro, sorry I didn't reply earlier, I was offline this week. I think your fix is not in the ideal place. I think that what happens is that you are using a driver that is not xrandr1.2-aware (please tell me if I'm wrong), and therefore Kephal falls back to QDesktopWidget for screen manageme

Re: createConfigInterface

2009-02-01 Thread Aaron J. Seigo
On Sunday 01 February 2009, David Baron wrote: > Is the create frunction called once, the first time, or is it called each > time the dialog is to be shown? This obviously makes a coding difference. it's called only when necessary, and the UI is deleted when the dialog is dismissed by the user. i

Review Request: Plasma::Webview

2009-02-01 Thread 0xDeadC0de
I'd like to request that plasma webview become full on QWebViews instead of QWebPages. On previous attempts at doing the same thing the QWebView would lose left click abilities. That does not seem the case with this method (Would obviously need some testing) but with 4.4.3 I get a normal QWebView

Re: Review Board

2009-02-01 Thread Marco Martin
On 2/1/09, David Solbach wrote: > Hi there, > > On Saturday 31 January 2009 19:18:01 Allen Winter wrote: > > I support an upgrade. > > In the KDEPIM group we only have 3 entries, all of which have been > > committed by now. > > I can't have two installations of Reviewboard with different vers

createConfigInterface

2009-02-01 Thread David Baron
I am bringing my configuration panes into the plasma applet standard configDialog. Is the create frunction called once, the first time, or is it called each time the dialog is to be shown? This obviously makes a coding difference. Code I've seen (and crashes I had in trying things out) implie