Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Aaron J. Seigo
On Saturday 08 November 2008, Jason Stubbs wrote: > There are some situations - such as overlapping sibling widgets - that can > cause a painting loop that can make plasma severely unresponsive. While > those issues should be fixed as they arise, I think that it is better that > the system tray be

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/#review258 --- trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/f

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/#review257 --- Ship it! couple of minor things that could be improved, but the a

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 19:40:24.687531) Review request for Plasma. Summary -

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 19:40:17.960183) Review request for Plasma. Summary -

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
> On 2008-11-08 12:07:21, Aaron Seigo wrote: > > a much easier, straightforward and foolproof way of doing this is to have a > > QTime and a QTimer, and at the start of the paintEvent method have sth like: > > > > if (time.elapsed() < MIN_REFRESH_TIME) { > > timer->start(MIN_REFRESH_TIME -

Re: plasma, panels, colours

2008-11-08 Thread Aaron J. Seigo
On Saturday 08 November 2008, Marco Martin wrote: > err, http://www.notmart.org/misc/tasks2.png i think this actually looks worse, as now there's a bunch of brighter spots each of which lower internal contrast. why the struggle against providing some hue adjustment to the background? the normal

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/#review255 --- a much easier, straightforward and foolproof way of doing this is

Re: Review Request: per-applet authors' info!

2008-11-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/263/#review254 --- Ship it! trunk/KDE/kdebase/workspace/plasma/shells/common/kcateg

Re: dict plasma applet

2008-11-08 Thread Aaron J. Seigo
On Saturday 08 November 2008, Nick Shaforostoff wrote: > i've done first steps in writing a dataengine for multitran-data > (multitran.sf.net, multitran.ru), and also plan to write > qstardict-based dataengine. would make most sense, obviously, if they were all in the same dataengine. > so i will

Re: taskbar: onlyGroupWhenFull

2008-11-08 Thread Riccardo Iaconelli
On Wednesday 05 November 2008 22:48:29 Michael Rudolph wrote: > Anyway, your kind words motivated me enough to pick up the slack at > the ways of the plasma. Perhaps this time around I can produce > something tangible. I think that your ways of plasma is a really valuable contribution. I wanted to

Re: [REVIEW] Add labelSize() to Plasma::Meter

2008-11-08 Thread Sebastian Kügler
On Saturday 08 November 2008 12:05:38 Rob Scheepmaker wrote: > On Saturday 08 November 2008 11:48:54 Sebastian Kügler wrote: > > On Friday 07 November 2008 17:56:11 Rob Scheepmaker wrote: > > > While I was updating the kuiserver applet to use the new progress-bar > > > design I suddenly had the nee

Re: plasma, panels, colours

2008-11-08 Thread Marco Martin
On Saturday 08 November 2008, Marco Martin wrote: > On Friday 07 November 2008, Aaron J. Seigo wrote: > > On Friday 07 November 2008, Marco Martin wrote: > > > it's still work in progress, the margins are slightly wrong, and will > > > make normal and iconified ones maybe a bit more different but i

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
Jason Stubbs wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/264/ > --- > > (Updated 2008-11-08 04:00:45.525789) Hmm.. no

Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- Review request for Plasma. Summary --- There are some situations - suc

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 04:00:45.525789) Review request for Plasma. Summary -

Re: plasma, panels, colours

2008-11-08 Thread Marco Martin
On Saturday 08 November 2008, Marco Martin wrote: > On Friday 07 November 2008, Aaron J. Seigo wrote: > > On Friday 07 November 2008, Marco Martin wrote: > > > it's still work in progress, the margins are slightly wrong, and will > > > make normal and iconified ones maybe a bit more different but i

Re: plasma, panels, colours

2008-11-08 Thread Marco Martin
On Friday 07 November 2008, Aaron J. Seigo wrote: > On Friday 07 November 2008, Marco Martin wrote: > > it's still work in progress, the margins are slightly wrong, and will > > make normal and iconified ones maybe a bit more different but i think > > it's already a bit more happy :) > > yes, this

Re: plasma, panels, colours

2008-11-08 Thread Marco Martin
On Friday 07 November 2008, Chani wrote: > > > > I think this is a good direction. The glow ties in well with the Oxygen > > active window shadow/glow while keeping the rest of the panel consistent > > with the remainder of the theme. If the problem we're trying to solve is > > the distinction b

Re: Review Request: per-applet authors' info!

2008-11-08 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/263/ --- (Updated 2008-11-08 03:21:04.419894) Review request for Plasma. Summary -

Review Request: per-applet authors' info!

2008-11-08 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/263/ --- Review request for Plasma. Summary --- I thought it's the time to take

Re: [REVIEW] Add labelSize() to Plasma::Meter

2008-11-08 Thread Rob Scheepmaker
On Saturday 08 November 2008 11:48:54 Sebastian Kügler wrote: > On Friday 07 November 2008 17:56:11 Rob Scheepmaker wrote: > > While I was updating the kuiserver applet to use the new progress-bar > > design I suddenly had the need to obtain the size of a label in the > > progress-bar svg. JobWidge

Re: [REVIEW] Add labelSize() to Plasma::Meter

2008-11-08 Thread Sebastian Kügler
On Friday 07 November 2008 17:56:11 Rob Scheepmaker wrote: > While I was updating the kuiserver applet to use the new progress-bar > design I suddenly had the need to obtain the size of a label in the > progress-bar svg. JobWidget displays the filename elided > ("file://home/...ample.png") and for

Re: dict plasma applet

2008-11-08 Thread Nick Shaforostoff
2008/11/8 Thomas Georgiou <[EMAIL PROTECTED]>: > Well, initially we used a qgraphicstextedit with html formatting to > make it look nicer, but we could not have scrolling with that, so when > 4.1 came along we switched to qwebview (to get scrolling support). > Then we switched dictionaries to wordn