Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
ok should be fixed in 857678. Cheers, Benoit PS. Now using intel graphics (yes i got one of these sony sz2 with dual intel/nvidia), no rendering glitches. 2008/9/6 Benoit Jacob <[EMAIL PROTECTED]>: > aaah got it :) > > when changing a setting, init() was called, reallocating the QImage > that w

Re: RSSNOW and news

2008-09-05 Thread Thomas Fjellstrom
On Friday 05 September 2008, Frerich Raabe wrote: > and the scrolltext widget is not so hip anymore either given all > the fancy animations you can see in KDE by now. > > - Frerich > Speaking of a fancy animation, I just thought of one that might be neat for a news/rss widget.. Old items smoothly

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
aaah got it :) when changing a setting, init() was called, reallocating the QImage that was being painted in paralled by the renderer threads... solution was to add a renderThreads[0]->wait() in Mandelbrot::init()... indeed the 0-th thread is the master-thread, it controls the others if any. Che

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
Indeed, i can reproduce that. How do I get a backtrace? The kcrash dialog just disappears when i ask for the backtrace, and when i run plasma in gdb, after the crash it just says "no stack". 2008/9/6 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Friday 05 September 2008, Benoit Jacob wrote: >> I updat

Re: RSSNOW and news

2008-09-05 Thread Sebastian Kügler
On Friday 05 September 2008 17:42:01 Petri Damstén wrote: > > I'm planning to go through the theming support in the news applet, so > > moving > > it now to kdereview is a bit early (but it won't hold me from fixing the > > theming). I've already done some back- and forward-porting of stuff to > >

Re: RSSNOW and news

2008-09-05 Thread Sebastian Kügler
On Friday 05 September 2008 18:12:15 Aaron J. Seigo wrote: > On Friday 05 September 2008, Davide Bettio wrote: > > > b) the difference between rssnow and news? > > > > mainly the layout... rssnow is the eyecandy one, news is the simpler one. > > perhaps we could alter the names of one or the other

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Benoit Jacob wrote: > I updated to 177.70. With desktop effects enabled, the glitches are as > bad as before. With desktop effects disabled, the situation has > improved but there remain some glitches. not related, but i just discovered that changing the settings while

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
I updated to 177.70. With desktop effects enabled, the glitches are as bad as before. With desktop effects disabled, the situation has improved but there remain some glitches. Cheers, Benoit 2008/9/5 Sebastian Kügler <[EMAIL PROTECTED]>: > On Friday 05 September 2008 16:32:02 Benoit Jacob wrote:

Re: Patch: New KRunner searches context of Dolphin Places Panel

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, David Edmundson wrote: > Aaron Seigo wrote: > > m_filePlaces = new KFilePlacesModel() gets leaked; > > Didn't know that, I think I have some other code to check now! =) > > it would be good to show an error, perhaps via KMessageBox, when setup > > fails in setupComple

Re: Patch: New KRunner searches context of Dolphin Places Panel

2008-09-05 Thread David Edmundson
Aaron Seigo wrote: > m_filePlaces = new KFilePlacesModel() gets leaked; Didn't know that, I think I have some other code to check now! > the object name doesn't actually need to be translated anymore, so this: Done > it would be good to show an error, perhaps via KMessageBox, when setup > fails

Re: Review Request: a signal for the activity change

2008-09-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/176/#review162 --- /trunk/KDE/kdebase/workspace/libs/plasma/containment.h

Re: Review Request: a signal for the activity change

2008-09-05 Thread Marco Martin
> On 2008-09-05 07:53:09, Aaron Seigo wrote: > > good idea; however, i think a better approach would be to have a > > contextChanged(Plasma::Context*) signal, and then do connect(d->context, > > SIGNAL(contextChanged(Plasma::Context*)), this, > > SLOT(contextChanged(Plasma::Context*)));? ok,

Re: Review Request: a signal for the activity change

2008-09-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/176/ --- (Updated 2008-09-05 11:19:45.262903) Review request for Plasma. Summary -

Re: RSSNOW and news

2008-09-05 Thread Frerich Raabe
Sebastian Kügler schrieb: > > 2) I noticed that news ticker is in kdenetwork, so what are we supposed to > > do? a) moving both applet to kdenetwork > > b) moving knewsticker to kdeplasma-addons > > c) moving both applet to kdeplasma-addons > > If newsticker still performs as horrible as it did in

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
ok, i was already doing svn up on all of workspace and last time i even did all of kdebase :) 2008/9/5 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Friday 05 September 2008, Aaron J. Seigo wrote: >> On Friday 05 September 2008, Benoit Jacob wrote: >> > Thanks for looking into it, but now when i chang

Re: RSSNOW and news

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Davide Bettio wrote: > > b) the difference between rssnow and news? > > mainly the layout... rssnow is the eyecandy one, news is the simpler one. perhaps we could alter the names of one or the other to reflect this difference? =) RSSNow is a cool name, and the logo

Re: RSSNOW and news

2008-09-05 Thread Davide Bettio
Hi, Il Friday 05 September 2008 16:04:10 Sebastian Kügler ha scritto: > I don't follow this logic, it should be the other way round, no? Having > people review it when we *know* it's not ready doesn't sound useful :) I just proposed a way to tell people "we are going to move both to kdesomething

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Aaron J. Seigo wrote: > On Friday 05 September 2008, Benoit Jacob wrote: > > Thanks for looking into it, but now when i change the color and > > "apply" or "ok" the change is not applied, the old color is still > > used. > > you probably need to svn up again; the wallpa

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
I did svn up again, indeed containment.cpp was changed; now i'm getting back the old behavior: the color gets updated and the viewpoint reset. very possibly, this can be a bug in my own code i.e. if i got the load/save config thing wrong. i have to go back to math work for now, next time i check

Re: RSSNOW and news

2008-09-05 Thread Petri Damstén
2008/9/5 Sebastian Kügler <[EMAIL PROTECTED]> > I'm planning to go through the theming support in the news applet, so > moving > it now to kdereview is a bit early (but it won't hold me from fixing the > theming). I've already done some back- and forward-porting of stuff to have > it > in both app

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Benoit Jacob wrote: > Thanks for looking into it, but now when i change the color and > "apply" or "ok" the change is not applied, the old color is still > used. you probably need to svn up again; the wallpaper is getting a chance to save itself, so the config should

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
I just tried the "vesa" driver instead of "nvidia": it works fine. So this is a nvidia driver issue, sorry for the noise. I haven't yet tried the newer drivers, I was planning to wait until they are released. Cheers, Benoit 2008/9/5 Sebastian Kügler <[EMAIL PROTECTED]>: > On Friday 05 September

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
Thanks for looking into it, but now when i change the color and "apply" or "ok" the change is not applied, the old color is still used. I did "svn up" in trunk/kdebase/workspace, anything else I should do ? Benoit 2008/9/5 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Friday 05 September 2008, Benoit

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Benoit Jacob wrote: > Another thing that also looks like a bug: > > if you go to "desktop effects" and change the color, apply, then the > viewpoint gets reset. I checked, the view parameters (m_center and > m_zoom) are already reset when the setColor() slot is called.

Re: Review Request: Moving m_time, m_date and m_prettyTimeZone variables into libplasmaclock

2008-09-05 Thread Rafa? Mi?ecki
> On 2008-09-05 07:38:29, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h, > > lines 57-59 > > > > > > why do you need the time and date members? > > > > moving m_

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Sebastian Kügler
On Friday 05 September 2008 16:32:02 Benoit Jacob wrote: > Here are the steps to reproduce: > > -set mandelbrot as your wallpaper > -minimize all windows, close plasma toolboxes (e.g. the panel toolbox) > -navigate through the wallpaper (e.g. mouse wheel) > > I still have the glitches with latest t

Re: RSSNOW and news

2008-09-05 Thread Sebastian Kügler
On Friday 05 September 2008 16:40:32 Aaron J. Seigo wrote: > On Friday 05 September 2008, Sebastian Kügler wrote: > > If newsticker still performs as horrible as it did in the beginning, it > > shouldn't be released at all. That might save us some bugreports "plasma > > chews up all my CPU time".

Re: Review Request: a signal for the activity change

2008-09-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/176/#review159 --- good idea; however, i think a better approach would be to have a

Re: RSSNOW and news

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Davide Bettio wrote: > Hi, > > 1) I think that we should move rssnow and news to kdereview (even if they > aren't really ready) because if we move both applet to kdereview we can > focus on making things working. can you summarize: a) the current state of both the rss

Re: RSSNOW and news

2008-09-05 Thread Aaron J. Seigo
On Friday 05 September 2008, Sebastian Kügler wrote: > If newsticker still performs as horrible as it did in the beginning, it > shouldn't be released at all. That might save us some bugreports "plasma > chews up all my CPU time". The news and rss applets are well-behaving as > far as I can see, so

Re: Review Request: libplasmaclock: updating m_prettyTimezone inside lib instead of digital clock

2008-09-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/175/#review158 --- Ship it! - Marco On 2008-09-05 03:00:10, Rafa? Mi?ecki wrote: >

Re: Review Request: Moving m_time, m_date and m_prettyTimeZone variables into libplasmaclock

2008-09-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/173/#review157 --- /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clocka

Re: Review Request: Digital clock: Fix saving selected timezone

2008-09-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/174/#review156 --- Ship it! - Aaron On 2008-09-05 01:44:59, Rafa? Mi?ecki wrote: >

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
Another thing that also looks like a bug: if you go to "desktop effects" and change the color, apply, then the viewpoint gets reset. I checked, the view parameters (m_center and m_zoom) are already reset when the setColor() slot is called. Cheers, Benoit P.S. sorry about mouseWheelEvent :) 2008

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
Here are the steps to reproduce: -set mandelbrot as your wallpaper -minimize all windows, close plasma toolboxes (e.g. the panel toolbox) -navigate through the wallpaper (e.g. mouse wheel) I still have the glitches with latest trunk; also, if i enable desktop effects I get glitches also in the da

Review Request: a signal for the activity change

2008-09-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/176/ --- Review request for Plasma. Summary --- this is the first time i try to

Re: RSSNOW and news

2008-09-05 Thread Sebastian Kügler
On Friday 05 September 2008 15:25:22 Davide Bettio wrote: > 1) I think that we should move rssnow and news to kdereview (even if they > aren't really ready) because if we move both applet to kdereview we can > focus on making things working. I don't follow this logic, it should be the other way ro

RSSNOW and news

2008-09-05 Thread Davide Bettio
Hi, 1) I think that we should move rssnow and news to kdereview (even if they aren't really ready) because if we move both applet to kdereview we can focus on making things working. 2) I noticed that news ticker is in kdenetwork, so what are we supposed to do? a) moving both applet to kdenetwo

Re: LCD widget

2008-09-05 Thread Davide Bettio
Hi, Il Friday 05 September 2008 09:00:02 Petri Damstén ha scritto: > I was asked by Davide Bettio to move Weather Station to kdereview (I really > should go through playground and check which of my engines and applets > could go to kdereview...). you should move also system monitor for example. :)

Re: Review Request: [Analog Clock] Show Timezone String

2008-09-05 Thread Alessandro Diaferia
> On 2008-09-04 12:32:50, Aaron Seigo wrote: > > > > Rafa? Mi?ecki wrote: > What about putting timezone string over clock's face rather than on > bottom of it? Don't you think it would be nicer? Sure, since Aaron told me to remove the time string i planned to move the timezone string over

Review Request: libplasmaclock: updating m_prettyTimezone inside lib instead of digital clock

2008-09-05 Thread Rafa? Mi?ecki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/175/ --- Review request for Plasma. Summary --- This patch moves updating m_pre

Re: Review Request: [Analog Clock] Show Timezone String

2008-09-05 Thread Rafa? Mi?ecki
> On 2008-09-04 12:32:50, Aaron Seigo wrote: > > What about putting timezone string over clock's face rather than on bottom of it? Don't you think it would be nicer? - Rafa? --- This is an automatically generated e-mail. To reply, visi

Review Request: Digital clock: Fix saving selected timezone

2008-09-05 Thread Rafa? Mi?ecki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/174/ --- Review request for Plasma. Summary --- I discovered bug that after cha

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Marco Martin
On Friday 05 September 2008, Benoit Jacob wrote: > Hi, > > I just committed an initial version of my Mandelbrot wallpaper plugin > (only 360 LOC) there: > > /trunk/playground/base/plasma/wallpapers/ > > commit message: > > http://websvn.kde.org/trunk/playground/base/plasma/wallpapers/?view=log&pat

Review Request: Moving m_time, m_date and m_prettyTimeZone variables into libplasmaclock

2008-09-05 Thread Rafa? Mi?ecki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/173/ --- Review request for Plasma. Summary --- To move standarised tooltip fro

Re: Review Request: [Analog Clock] Show Timezone String

2008-09-05 Thread Alessandro Diaferia
> On 2008-09-04 12:32:50, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.h, line 78 > > > > > > you can actually just remove m_showTimeString; that was originally a > > demo of plasm

LCD widget

2008-09-05 Thread Petri Damstén
Hi, I was asked by Davide Bettio to move Weather Station to kdereview (I really should go through playground and check which of my engines and applets could go to kdereview...). Before moving Weather Station I would like to ask one thing though. Weather Station has general LCD widget. It's basi