Moving spellcheck runner to kdeplasma-addons

2008-08-18 Thread Ryan P. Bitanga
Does anyone have any objections to moving the spellcheck runner into kdeplasma-addons? It hasn't been touched for a while and I don't think it needs further development. I only read Aaron's mail asking if we could move it to kdereview recently (yes I know that was sent last March but the huge traf

Re: Review Request: Override showOnlyCurrentDesktop for demandsAttention

2008-08-18 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/131/ --- (Updated 2008-08-18 18:33:42.206447) Review request for Plasma. Summary -

Re: Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

2008-08-18 Thread guitarist198
> On 2008-08-13 07:04:36, Alex Merry wrote: > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp, line 264 > > > > > > There should be an & before the word "Desktop", as in the > > makeDesktopsMenu(TaskPtr)

Re: Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

2008-08-18 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/133/ --- (Updated 2008-08-18 18:13:34.778758) Review request for Plasma. Summary -

Re: Smarter desktop applet placement

2008-08-18 Thread Ambroz Bizjak
I have further improved my layout code. Now it can use any of the four corners as the "static corner" instead of only top-left. This means if the screen shrinks for example, it is not only possible to make the right screen border push applets left, but also the left border push applets right. And n

System-wide Activities

2008-08-18 Thread Hari krishna Anandhan
Hello all, I am a newbie here ( though long-time lurker). This is my first journey to make myself useful to KDE. I will start with a *dream* and then the implementation (Hope it doesn't clash with plasma's vision; or better if it is complementary to it, it would be great! ) To start with, please

Re: Quota warning dialogue

2008-08-18 Thread Jan Kara
Hi, On Mon 18-08-08 06:27:37, Aaron J. Seigo wrote: > hi Jan .. > > sorry for the late reply .. i'm sitting in LHR airport as i write this ... > > On Wednesday 13 August 2008, Jan Kara wrote: > > interface = "com.system.quota.warning", > > unless you own the system.com domain name ;) this wou

Re: System tray rewrite ready for review

2008-08-18 Thread Jason Stubbs
Replying to myself... Jason Stubbs wrote: > Sebastian Kügler wrote: >> Positioning and background seem to be messed up here. See the screenshot. > > I've reproduced the positioning issue (it depends on the theme) so will > work on a fix for that, There's actually two issues. I introduced a bug

Re: System tray rewrite ready for review

2008-08-18 Thread Sebastian Kügler
On Monday 18 August 2008 14:02:15 Jason Stubbs wrote: > Sebastian Kügler wrote: > > On Sunday 17 August 2008 19:53:33 Jason Stubbs wrote: > >> I won't be around much over the next week as I'm moving, but I should be > >> back to my regular "squeeze in an hour or two each day" by next weekend. > > I

Re: Quota warning dialogue

2008-08-18 Thread Sebastian Kügler
On Monday 18 August 2008 14:27:37 Aaron J. Seigo wrote: > hi Jan .. > > sorry for the late reply .. i'm sitting in LHR airport as i write this ... > > On Wednesday 13 August 2008, Jan Kara wrote: > > interface = "com.system.quota.warning", > > unless you own the system.com domain name ;) this woul

Re: System tray rewrite ready for review + portability?

2008-08-18 Thread Aaron J. Seigo
On Monday 18 August 2008, Richard Moore wrote: > On 8/18/08, Gerhard Gappmeier <[EMAIL PROTECTED]> wrote: > > independent from your changes I see a problem with the X11 includes. > > KDE4 should run on any OS including Windows and this includes break > > portability. > > This is probably destined t

Re: System tray rewrite ready for review + portability?

2008-08-18 Thread Jason Stubbs
Gerhard Gappmeier wrote: > Hi Jason, > > independent from your changes I see a problem with the X11 includes. > KDE4 should run on any OS including Windows and this includes break > portability. > > While there is no problem of making OS dependent plasmoids in general > I think a basic one like t

Re: System tray rewrite ready for review + portability?

2008-08-18 Thread Richard Moore
On 8/18/08, Gerhard Gappmeier <[EMAIL PROTECTED]> wrote: > independent from your changes I see a problem with the X11 includes. > KDE4 should run on any OS including Windows and this includes break > portability. This is probably destined to be part of the workspace/plasma rather than plasma libs,

Re: Quota warning dialogue

2008-08-18 Thread Aaron J. Seigo
hi Jan .. sorry for the late reply .. i'm sitting in LHR airport as i write this ... On Wednesday 13 August 2008, Jan Kara wrote: > interface = "com.system.quota.warning", unless you own the system.com domain name ;) this would be incorrect. perhaps org.linux? or perhaps even better would be to

Re: System tray rewrite ready for review + portability?

2008-08-18 Thread Gerhard Gappmeier
Hi Jason, independent from your changes I see a problem with the X11 includes. KDE4 should run on any OS including Windows and this includes break portability. While there is no problem of making OS dependent plasmoids in general I think a basic one like the systray should run everywhere. Are th

Re: System tray rewrite ready for review

2008-08-18 Thread Jason Stubbs
Sebastian Kügler wrote: > On Sunday 17 August 2008 19:53:33 Jason Stubbs wrote: >> I won't be around much over the next week as I'm moving, but I should be >> back to my regular "squeeze in an hour or two each day" by next weekend. It seems I'll continue to squeeze in an hour or two while preparin

Re: System tray rewrite ready for review

2008-08-18 Thread Sebastian Kügler
On Sunday 17 August 2008 19:53:33 Jason Stubbs wrote: > I'm fairly happy with the state of the rewrite and so am requesting that > it be reviewed for moving into trunk/kdebase. There's not much that it > doesn't fix and not much work left to do, but no show stoppers as far as > I know. > > There a