Re: [Piglit] [PATCH] summary/console: Add -p / --problems

2017-12-11 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Adam Jackson (2017-12-05 08:08:37) > This is convenient for extracting a focused test set from a more > comprehensive run, to speed up bisection or per-commit validation. > --- > framework/programs/summary.py | 5 + > framework/summary/console_.py | 4 +++- >

[Piglit] [PATCH 3/5] egl-util: use piglit_egl_get_display over eglGetDisplay

2017-12-11 Thread Emil Velikov
From: Emil Velikov The latter is a legacy and somewhat of a hack. Since we explicitly know that this requires the X11, simply use the helper which will use the correct EGL_PLATFORM API. Cc: Ian Romanick Signed-off-by: Emil Velikov --- tests/egl/egl-util.c | 4 ++-- 1 file changed, 2 insertio

[Piglit] [PATCH 4/5] egl-util: introduce egl_util_create_native_pixmap helper

2017-12-11 Thread Emil Velikov
From: Emil Velikov Allows us to consolidate native platform specifics in once place. Will be reused in later commit(s). Cc: Ian Romanick Signed-off-by: Emil Velikov --- tests/egl/egl-util.c | 12 +--- tests/egl/egl-util.h | 3 +++ 2 files changed, 12 insertions(+), 3 deletions(-) di

[Piglit] [PATCH 1/5] egl: Call eglBindAPI after eglInitialize

2017-12-11 Thread Emil Velikov
From: Emil Velikov A couple of tests were calling eglBindAPI before eglInitialize. Some versions of Mesa had problem with such invocation order and the seeming consensus was that apps should not do that. This is likely a copy/paste mistake, that was also present in Xserver. Yet the latter was fi

[Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-11 Thread Emil Velikov
From: Emil Velikov Current Mesa implementation was overly cautious, flagging an error where it shouldn't - patch for Mesa is on the list. See the test for details. Cc: Ian Romanick Signed-off-by: Emil Velikov --- Nitpicks: - suggestions for test name and category? - should we bother at all

[Piglit] [PATCH 2/5] egl: split out a piglit_egl_get_display helper

2017-12-11 Thread Emil Velikov
From: Emil Velikov Some places (like the next patch) want to pass non-default dpy. Cc: Ian Romanick Signed-off-by: Emil Velikov --- tests/util/piglit-util-egl.c | 10 -- tests/util/piglit-util-egl.h | 11 ++- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/test

Re: [Piglit] Remove remaing Glean tests.

2017-12-11 Thread Fabian Bieler
On 2017-12-11 16:26, Michel Dänzer wrote: > On 2017-12-09 01:52 PM, Fabian Bieler wrote: >> This series removes the remaing Glean tests from Piglit. > > Yay! > > >> 3 subtests were cherry-picked and ported to Piglit. >> >> These test were removed without replacement: >> api2no real value

Re: [Piglit] Remove remaing Glean tests.

2017-12-11 Thread Adam Jackson
On Mon, 2017-12-11 at 16:26 +0100, Michel Dänzer wrote: > On 2017-12-09 01:52 PM, Fabian Bieler wrote: > > This series removes the remaing Glean tests from Piglit. > > Yay! Seconded! > > 3 subtests were cherry-picked and ported to Piglit. > > > > These test were removed without replacement: > >

Re: [Piglit] Remove remaing Glean tests.

2017-12-11 Thread Michel Dänzer
On 2017-12-09 01:52 PM, Fabian Bieler wrote: > This series removes the remaing Glean tests from Piglit. Yay! > 3 subtests were cherry-picked and ported to Piglit. > > These test were removed without replacement: > api2no real value > vertattrib GL_NV_vertex_program not supported by mes

Re: [Piglit] Remove remaing Glean tests.

2017-12-11 Thread Brian Paul
The series looks good to me. Thanks for doing this. Reviewed-by: Brian Paul On 12/09/2017 05:52 AM, Fabian Bieler wrote: This series removes the remaing Glean tests from Piglit. 3 subtests were cherry-picked and ported to Piglit. These test were removed without replacement: api2no r

Re: [Piglit] [PATCH] textureGather: add new options for testing mirror address modes

2017-12-11 Thread Brian Paul
On 12/09/2017 09:48 PM, srol...@vmware.com wrote: From: Roland Scheidegger The existing repeat and clamp modes are easy to implement. The mirror_repeat (GL_MIRRORED_REPEAT) and mirror_clamp (GL_MIRROR_CLAMP_TO_EDGE) modes however have some very interesting differences to "gather is just the sam