On 8/10/2009 5:18 PM, Mert Oztekin wrote:
Hi Paul,
As I agree some of your thoughts, I want to add my opinion also.
Yes the code should work. That is why we earn Money. If it doesnt work, then we are on
fire. But things like OOP or MVC weren't invented for a better running code. They are
inven
On 8/10/2009 1:20 AM, Andrea Giammarchi wrote:
So far I stopped at the first line, the constructor, where I can spot with what I can
read SQL injections "everywhere"
I hope here is a proper validation there, 'cause as is, sounds truly dangerous,
since you are not using bindParams or other PDO
Mert
(sorry for my english)
-Original Message-
From: Paul M Foster [mailto:pa...@quillandmouse.com]
Sent: Wednesday, October 07, 2009 7:54 PM
To: php-general@lists.php.net
Subject: Re: [PHP] Insult my code!
On Wed, Oct 07, 2009 at 05:34:35PM +1100, Eric Bauman wrote:
> Hi there,
On Wed, Oct 07, 2009 at 11:31:58PM +0100, David Otton wrote:
> 2009/10/7 Paul M Foster :
>
> > I think this is a bit extreme. It really depends on what's in your
> > parent model class. It could be something really simple, but something
> > you don't want to have to rewrite in every model you cod
2009/10/7 Paul M Foster :
> I think this is a bit extreme. It really depends on what's in your
> parent model class. It could be something really simple, but something
> you don't want to have to rewrite in every model you code. Thinking that
Have you got an example of something that is needed by
On Wed, Oct 07, 2009 at 09:09:29PM +0100, David Otton wrote:
> 2009/10/7 Eric Bauman :
> >
> > On 7/10/2009 7:25 PM, David Otton wrote:
> >>
> >> 2009/10/7 Eric Bauman:
> >>
> >>> Any thoughts would be much appreciated!
> >>
> >> One observation. "Model" isn't a synonym for "Database Table" - mode
2009/10/7 Eric Bauman :
>
> On 7/10/2009 7:25 PM, David Otton wrote:
>>
>> 2009/10/7 Eric Bauman:
>>
>>> Any thoughts would be much appreciated!
>>
>> One observation. "Model" isn't a synonym for "Database Table" - models
>> can be anything that encapsulates business logic. Requiring all your
>> mo
On Wed, Oct 07, 2009 at 05:34:35PM +1100, Eric Bauman wrote:
> Hi there,
>
> I'm in the process of trying to wrap my head around MVC, and as part of
> that, I'm attempting to implement a super-tiny MVC framework.
>
> I've created some mockups of how the framework might be used based
> around a ver
So far I stopped at the first line, the constructor, where I can spot with what
I can read SQL injections "everywhere"
I hope here is a proper validation there, 'cause as is, sounds truly dangerous,
since you are not using bindParams or other PDO related techniques to avoid
input problems.
Ab
On Wed, Oct 7, 2009 at 8:06 AM, Eric Bauman wrote:
> On 7/10/2009 7:25 PM, David Otton wrote:
>
>> 2009/10/7 Eric Bauman:
>>
>> Any thoughts would be much appreciated!
>>>
>>
>> One observation. "Model" isn't a synonym for "Database Table" - models
>> can be anything that encapsulates business l
On 7/10/2009 7:25 PM, David Otton wrote:
2009/10/7 Eric Bauman:
Any thoughts would be much appreciated!
One observation. "Model" isn't a synonym for "Database Table" - models
can be anything that encapsulates business logic. Requiring all your
models to inherit from Model is probably a bad id
On 7/10/2009 7:36 PM, Mert Oztekin wrote:
Seems ok.
Just a thought:
Your model seems to be coded just for retreiving data. IMO you should
code it for all possible actions(insert,update,delete,select). And also it
should run without any database calls(you may create a new bank user in
2009/10/7 Eric Bauman :
> Any thoughts would be much appreciated!
One observation. "Model" isn't a synonym for "Database Table" - models
can be anything that encapsulates business logic. Requiring all your
models to inherit from Model is probably a bad idea.
--
PHP General Mailing List (http://
Seems ok.
Just a thought:
Your model seems to be coded just for retreiving data. IMO you should
code it for all possible actions(insert,update,delete,select). And also it
should run without any database calls(you may create a new bank user in a page
and use it than throw it away, so yo
14 matches
Mail list logo
