Re: [PHP] Code Critique Please :)

2007-11-26 Thread Martin Alterisio
2007/11/21, Simeon F. Willbanks <[EMAIL PROTECTED]>: > > Hello, > > I am trying to increase my knowledge and understanding of OO and OO > Design Patterns. I'd like to request a critique of a program that > extracts MySQL table information and translates it into XML. In the > program, I tried to a

Re: [PHP] Code Critique Please :)

2007-11-26 Thread Philip Thompson
On Nov 22, 2007 11:52 AM, Robert Cummings <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-22 at 12:46 -0500, Oscar Gosdinski wrote: > > > > There is something that i always wonder about Singleton pattern in > > PHP, do you really have a benefit using this pattern in PHP? The idea > > behind this patt

Re: [PHP] Code Critique Please :)

2007-11-22 Thread Robert Cummings
On Thu, 2007-11-22 at 12:46 -0500, Oscar Gosdinski wrote: > > There is something that i always wonder about Singleton pattern in > PHP, do you really have a benefit using this pattern in PHP? The idea > behind this pattern is that only one instance of the class is created, > it works great in Java

Re: [PHP] Code Critique Please :)

2007-11-22 Thread Oscar Gosdinski
On Nov 21, 2007 2:05 PM, Simeon F. Willbanks <[EMAIL PROTECTED]> wrote: > 3. Object Oriented principles I see that you tried to implement Singleton pattern in the DB class, but you have a mistake. $dbConnection attribute is not a static member, so every time you call the constructor $dbConnection w

Re: [PHP] Code Critique Please :)

2007-11-22 Thread Simeon F. Willbanks
No I did not, thanks! For those that need more information, here is a good tutorial: http://en.wikibooks.org/wiki/XML_-_Managing_Data_Exchange/Converting_MySQL_to_XML Simeon On Nov 22, 2007, at 10:05 AM, [EMAIL PROTECTED] wrote: You know that mysql has an output option for producing XML

Re: [PHP] Code Critique Please :)

2007-11-22 Thread Per Jessen
Simeon F. Willbanks wrote: > Hello, > > I am trying to increase my knowledge and understanding of OO and OO > Design Patterns. I'd like to request a critique of a program that > extracts MySQL table information and translates it into XML. You know that mysql has an output option for producing

Re: [PHP] Code Critique Please :)

2007-11-21 Thread Jochem Maas
Simeon F. Willbanks wrote: > Jochem, > > Thanks for the tips. no worries, for the rest you stuff looks tidy and making use of phpDoc comments and using CS consistently are both recommended! with regard to OO I didn't really see enough [complexity] to be able to offer any worthwhile feedback - bu

Re: [PHP] Code Critique Please :)

2007-11-21 Thread Jochem Maas
Simeon F. Willbanks wrote: > Hello, > > I am trying to increase my knowledge and understanding of OO and OO > Design Patterns. I'd like to request a critique of a program that > extracts MySQL table information and translates it into XML. In the > program, I tried to accomplish a few things: >