Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-11 Thread Jason Greene
tmans" <[EMAIL PROTECTED]> To: "Jason Greene" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, April 11, 2001 5:21 PM Subject: Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c > Just curious. What does their pragma do? > > Andi > > At 03:16 AM 4/10/2

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-11 Thread Andi Gutmans
Just curious. What does their pragma do? Andi At 03:16 AM 4/10/2001 +, Jason Greene wrote: >jason Mon Apr 9 20:16:06 2001 EDT > > Modified files: > /php4/ext/sockets sockets.c > Log: > Fix for PR #9729, 9664, 9656, 8667. > All compilers on Solaris should build this e

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-10 Thread Jason Greene
hans" <[EMAIL PROTECTED]> To: "Jason Greene" <[EMAIL PROTECTED]> Cc: "Jani Taskinen" <[EMAIL PROTECTED]>; "Sascha Schumann" <[EMAIL PROTECTED]>; "PHP Quality Assurance Team Mailing List" <[EMAIL PROTECTED]> Sent: Tuesday, April 10,

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-10 Thread Jason Greene
Thanks, -Jason - Original Message - From: "Derick Rethans" <[EMAIL PROTECTED]> To: "Jason Greene" <[EMAIL PROTECTED]> Cc: "Jani Taskinen" <[EMAIL PROTECTED]>; "Jason Greene" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> S

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-10 Thread Derick Rethans
On Tue, 10 Apr 2001, Jason Greene wrote: > Out of those platforms you listed, I have tested this on Linux. I will test FreeBSD >today. > However, I do not have an OpenBSD box, does anyone out there want to try and > build the latest cvs with --enable-sockets on OpenBSD? I can test to build it..

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-10 Thread Jason Greene
kinen" <[EMAIL PROTECTED]> To: "Jason Greene" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Tuesday, April 10, 2001 5:01 AM Subject: Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c > > Have you tested it on Linux, FreeBSD, OpenBSD... ? :) > If yo

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-10 Thread Jani Taskinen
Have you tested it on Linux, FreeBSD, OpenBSD... ? :) If you know for sure it will work on these, go ahead. --Jani On Mon, 9 Apr 2001, Jason Greene wrote: >Everyone, > >Can I merge this into the current RC? This should not cause >any problems. > >-Jason > >- Original Message - >From: "

RE: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-10 Thread James Moore
> > Everyone, > > Can I merge this into the current RC? This should not cause > any problems. What are we doing with the current release right now? who is having problems and which problems are outstanding?? We have two possible MFH's that people want to do which shouldnt really be included at

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-04-09 Thread Jason Greene
Everyone, Can I merge this into the current RC? This should not cause any problems. -Jason - Original Message - From: "Jason Greene" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, April 09, 2001 10:16 PM Subject: [PHP-CVS] cvs: php4 /ext/sockets sockets.c > jason Mon Apr

RE: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-04 Thread Derick Rethans
On Fri, 2 Feb 2001, Colin Viebrock wrote: > I for one would like to see #8839 fixed ... hint, hint Derick! ;) Gr :) Derick Rethans - PHP: Scripting the Web - www.php.net - [EMAIL PROTECTED] --

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-03 Thread Andi Gutmans
By the way, often compilers change switch() to if()/else() if they know that it would be faster (if you only have like 2 cases) so if the code is much nicer you don't need to be too afraid of switch() :) Andi At 03:44 PM 2/3/2001 +0200, Boian Bonev wrote: >hi, > > > > > What do you mean, switc

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-03 Thread Boian Bonev
hi, > > What do you mean, switch() is expensive? > Well, isn't it slower? perhapse in php switch is slower. in c it sometimes is much faster than bunch of if statements. i mean the compiler makes jump tables for consequitive values and there are less comparisons etc. just a range check and jump

RE: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Colin Viebrock
> Well, sorry if it seemed harsh, but you tried to fix one problem and > introduced another without really understanding what needed to be done. True. I was relying on a fix somebody suggested. This is also why I noted in the CVS comments that somebody else should look at this. I'll be the fir

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Andrei Zmievski
On Fri, 02 Feb 2001, Colin Viebrock wrote: > > Ok, I fixed it. > > Thanks ... although "bogus patch" is kinda harsh, don't you think? :) Well, sorry if it seemed harsh, but you tried to fix one problem and introduced another without really understanding what needed to be done. -Andrei Give a

RE: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Colin Viebrock
> Ok, I fixed it. Thanks ... although "bogus patch" is kinda harsh, don't you think? :) - Colin -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECT

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Andrei Zmievski
On Fri, 02 Feb 2001, Colin Viebrock wrote: > I dunno. If I call the function with: > > > > I guess it doesn't matter what the port *is* ... it just won't return it. > Maybe just put if statements around any of the code that references port? Ok, I fixed it. -Andrei * What were the first

RE: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Colin Viebrock
> > Well, isn't it slower? > > No, not really. Ok. > > The goal is to make getpeername() not seg-fault and core dump when > > I only call it with 2 args. :) > > What should the value of 'port' be by default, then? I dunno. If I call the function with: I guess it doesn't matter wh

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Andrei Zmievski
On Fri, 02 Feb 2001, Colin Viebrock wrote: > Well, isn't it slower? No, not really. > The goal is to make getpeername() not seg-fault and core dump when > I only call it with 2 args. :) What should the value of 'port' be by default, then? -Andrei * Who is Ray and why would we want to selective

RE: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Colin Viebrock
> What do you mean, switch() is expensive? Well, isn't it slower? > Uh-uh - can't do that. What is your goal here, if port is not passed, it > defaults to 0? The goal is to make getpeername() not seg-fault and core dump when I only call it with 2 args. :) - Colin -- PHP CVS Mailing List (htt

Re: [PHP-CVS] cvs: php4 /ext/sockets sockets.c

2001-02-02 Thread Andrei Zmievski
On Fri, 02 Feb 2001, Colin Viebrock wrote: > cmv Fri Feb 2 12:55:27 2001 EDT > > Modified files: > /php4/ext/sockets sockets.c > Log: > Fix for http://bugs.php.net/bugs.php?id=9082 > > I know switch() is expensive, so someone rewrite this "properly" if you