pgsql: EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of fai

2026-02-25 Thread Noah Misch
EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of failing. Settings that ran the new test euc_kr.sql to completion would fail these older src/pl tests. Use alternative expected outputs, for which psql \gset and \if have reduced the maintenance burden. This fixes "LANG=ko_KR.euckr LC_M

pgsql: EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of fai

2026-02-25 Thread Noah Misch
EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of failing. Settings that ran the new test euc_kr.sql to completion would fail these older src/pl tests. Use alternative expected outputs, for which psql \gset and \if have reduced the maintenance burden. This fixes "LANG=ko_KR.euckr LC_M

pgsql: EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of fai

2026-02-25 Thread Noah Misch
EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of failing. Settings that ran the new test euc_kr.sql to completion would fail these older src/pl tests. Use alternative expected outputs, for which psql \gset and \if have reduced the maintenance burden. This fixes "LANG=ko_KR.euckr LC_M

pgsql: EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of fai

2026-02-25 Thread Noah Misch
EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of failing. Settings that ran the new test euc_kr.sql to completion would fail these older src/pl tests. Use alternative expected outputs, for which psql \gset and \if have reduced the maintenance burden. This fixes "LANG=ko_KR.euckr LC_M

pgsql: EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of fai

2026-02-25 Thread Noah Misch
EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of failing. Settings that ran the new test euc_kr.sql to completion would fail these older src/pl tests. Use alternative expected outputs, for which psql \gset and \if have reduced the maintenance burden. This fixes "LANG=ko_KR.euckr LC_M

pgsql: EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of fai

2026-02-25 Thread Noah Misch
EUC_CN, EUC_JP, EUC_KR, EUC_TW: Skip U+00A0 tests instead of failing. Settings that ran the new test euc_kr.sql to completion would fail these older src/pl tests. Use alternative expected outputs, for which psql \gset and \if have reduced the maintenance burden. This fixes "LANG=ko_KR.euckr LC_M

pgsql: Fix ProcWakeup() resetting wrong waitStart field.

2026-02-25 Thread Fujii Masao
Fix ProcWakeup() resetting wrong waitStart field. Previously, when one process woke another that was waiting on a lock, ProcWakeup() incorrectly cleared its own waitStart field (i.e., MyProc->waitStart) instead of that of the process being awakened. As a result, the awakened process retained a sta

pgsql: Fix ProcWakeup() resetting wrong waitStart field.

2026-02-25 Thread Fujii Masao
Fix ProcWakeup() resetting wrong waitStart field. Previously, when one process woke another that was waiting on a lock, ProcWakeup() incorrectly cleared its own waitStart field (i.e., MyProc->waitStart) instead of that of the process being awakened. As a result, the awakened process retained a sta

pgsql: Fix ProcWakeup() resetting wrong waitStart field.

2026-02-25 Thread Fujii Masao
Fix ProcWakeup() resetting wrong waitStart field. Previously, when one process woke another that was waiting on a lock, ProcWakeup() incorrectly cleared its own waitStart field (i.e., MyProc->waitStart) instead of that of the process being awakened. As a result, the awakened process retained a sta

pgsql: Fix ProcWakeup() resetting wrong waitStart field.

2026-02-25 Thread Fujii Masao
Fix ProcWakeup() resetting wrong waitStart field. Previously, when one process woke another that was waiting on a lock, ProcWakeup() incorrectly cleared its own waitStart field (i.e., MyProc->waitStart) instead of that of the process being awakened. As a result, the awakened process retained a sta

pgsql: Fix ProcWakeup() resetting wrong waitStart field.

2026-02-25 Thread Fujii Masao
Fix ProcWakeup() resetting wrong waitStart field. Previously, when one process woke another that was waiting on a lock, ProcWakeup() incorrectly cleared its own waitStart field (i.e., MyProc->waitStart) instead of that of the process being awakened. As a result, the awakened process retained a sta

pgsql: Fix ProcWakeup() resetting wrong waitStart field.

2026-02-25 Thread Fujii Masao
Fix ProcWakeup() resetting wrong waitStart field. Previously, when one process woke another that was waiting on a lock, ProcWakeup() incorrectly cleared its own waitStart field (i.e., MyProc->waitStart) instead of that of the process being awakened. As a result, the awakened process retained a sta

pgsql: doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE.

2026-02-25 Thread Fujii Masao
doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE. The documentation for the INCLUDING COMMENTS option of the LIKE clause in CREATE TABLE was inaccurate and incomplete. It stated that comments for copied columns, constraints, and indexes are copied, but regarding comments on constraint

pgsql: doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE.

2026-02-25 Thread Fujii Masao
doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE. The documentation for the INCLUDING COMMENTS option of the LIKE clause in CREATE TABLE was inaccurate and incomplete. It stated that comments for copied columns, constraints, and indexes are copied, but regarding comments on constraint

pgsql: doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE.

2026-02-25 Thread Fujii Masao
doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE. The documentation for the INCLUDING COMMENTS option of the LIKE clause in CREATE TABLE was inaccurate and incomplete. It stated that comments for copied columns, constraints, and indexes are copied, but regarding comments on constraint

pgsql: doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE.

2026-02-25 Thread Fujii Masao
doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE. The documentation for the INCLUDING COMMENTS option of the LIKE clause in CREATE TABLE was inaccurate and incomplete. It stated that comments for copied columns, constraints, and indexes are copied, but regarding comments on constraint

pgsql: doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE.

2026-02-25 Thread Fujii Masao
doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE. The documentation for the INCLUDING COMMENTS option of the LIKE clause in CREATE TABLE was inaccurate and incomplete. It stated that comments for copied columns, constraints, and indexes are copied, but regarding comments on constraint

pgsql: doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE.

2026-02-25 Thread Fujii Masao
doc: Clarify INCLUDING COMMENTS behavior in CREATE TABLE LIKE. The documentation for the INCLUDING COMMENTS option of the LIKE clause in CREATE TABLE was inaccurate and incomplete. It stated that comments for copied columns, constraints, and indexes are copied, but regarding comments on constraint

pgsql: Stabilize output of new isolation test insert-conflict-do-update

2026-02-25 Thread Tom Lane
Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3

pgsql: Stabilize output of new isolation test insert-conflict-do-update

2026-02-25 Thread Tom Lane
Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3

pgsql: Stabilize output of new isolation test insert-conflict-do-update

2026-02-25 Thread Tom Lane
Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3

pgsql: Stabilize output of new isolation test insert-conflict-do-update

2026-02-25 Thread Tom Lane
Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3

pgsql: Stabilize output of new isolation test insert-conflict-do-update

2026-02-25 Thread Tom Lane
Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3

pgsql: Stabilize output of new isolation test insert-conflict-do-update

2026-02-25 Thread Tom Lane
Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3

pgsql: Fix some cases of indirectly casting away const.

2026-02-25 Thread Tom Lane
Fix some cases of indirectly casting away const. Newest versions of gcc+glibc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char *" value to a target variable that's just "char *". This of course creat

pgsql: Fix some cases of indirectly casting away const.

2026-02-25 Thread Tom Lane
Fix some cases of indirectly casting away const. Newest versions of gcc+glibc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char *" value to a target variable that's just "char *". This of course creat

pgsql: Fix some cases of indirectly casting away const.

2026-02-25 Thread Tom Lane
Fix some cases of indirectly casting away const. Newest versions of gcc+glibc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char *" value to a target variable that's just "char *". This of course creat

pgsql: Fix some cases of indirectly casting away const.

2026-02-25 Thread Tom Lane
Fix some cases of indirectly casting away const. Newest versions of gcc+glibc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char *" value to a target variable that's just "char *". This of course creat

pgsql: Fix some cases of indirectly casting away const.

2026-02-25 Thread Tom Lane
Fix some cases of indirectly casting away const. Newest versions of gcc+glibc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char *" value to a target variable that's just "char *". This of course creat

pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

2026-02-25 Thread Tom Lane
Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc

pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

2026-02-25 Thread Tom Lane
Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc

pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

2026-02-25 Thread Tom Lane
Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc

pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

2026-02-25 Thread Tom Lane
Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc

pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

2026-02-25 Thread Tom Lane
Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code. Although clang claims to be compatible with gcc's printf format archetypes, this appears to be a falsehood: it likes __syslog__ (which gcc does not, on most platforms) and doesn't accept gnu_printf. This means that if you try to use gcc