pgsql: pg_waldump: Remove file-level global WalSegSz.

2026-01-27 Thread Robert Haas
pg_waldump: Remove file-level global WalSegSz. It's better style to pass the value around to just the places that need it. This makes it easier to determine whether the value is always properly initialized before use. Reviewed-by: Amul Sul Discussion: http://postgr.es/m/caaj_b94+wobpn-z1vecipns

pgsql: Fix crash introduced by incorrect backport 806555e300.

2026-01-27 Thread Jeff Davis
Fix crash introduced by incorrect backport 806555e300. Commit 7f007e4a04 in master depends on 1476028225, but the latter was not backported. Therefore 806555e300 (the backport of commit 7f007e4a04) incorrectly used pg_strfold() in a locale where ctype_is_c. The fix is to simply have the callers c

pgsql: oauth: Correct test dependency on oauth_hook_client

2026-01-27 Thread Jacob Champion
oauth: Correct test dependency on oauth_hook_client The oauth_validator tests missed the lessons of c89525d57 et al, so certain combinations of command-line build order and `meson test` options can result in Command 'oauth_hook_client' not found in [...] at src/test/perl/PostgreSQL/Test/Util

pgsql: oauth: Correct test dependency on oauth_hook_client

2026-01-27 Thread Jacob Champion
oauth: Correct test dependency on oauth_hook_client The oauth_validator tests missed the lessons of c89525d57 et al, so certain combinations of command-line build order and `meson test` options can result in Command 'oauth_hook_client' not found in [...] at src/test/perl/PostgreSQL/Test/Util

Re: pgsql: Fix crash introduced by incorrect backport 806555e300.

2026-01-27 Thread Jeff Davis
On Tue, 2026-01-27 at 16:16 +, Jeff Davis wrote: > Fix crash introduced by incorrect backport 806555e300. Note: this is a backbranch-only commit (only v18). Just highlighting that to avoid confusion. Regards, Jeff Davis

pgsql: Add output test for pg_dependencies statistics import

2026-01-27 Thread Michael Paquier
Add output test for pg_dependencies statistics import Commit 302879bd68d115 has added the ability to restore extended stats of the type "dependencies", but it has forgotten the addition of a test to verify that the value restored was actually set. This test is the pg_dependencies equivalent of th

pgsql: Fix pg_restore_extended_stats() with expressions

2026-01-27 Thread Michael Paquier
Fix pg_restore_extended_stats() with expressions This commit fixes an issue with the restore of ndistinct and dependencies statistics, causing the operation to fail when any of these kinds included expressions. In extended statistics, expressions use strictly negative attribute numbers, decrement