pgsql: pg_stat_statements: Rework test order

2026-01-20 Thread Michael Paquier
pg_stat_statements: Rework test order The test "squashing" was the last item of the REGRESS list, but "cleanup" should be the second to last, dropping the extension. "oldextversions" is the last item. In passing, the REGRESS list is cleaned up to include one item per line, so as diffs are minimiz

pgsql: pg_stat_statements: Clean up REGRESS list in Makefile

2026-01-20 Thread Michael Paquier
pg_stat_statements: Clean up REGRESS list in Makefile The "wal" and "entry_timestamp" items were still on the same line, which was not intentional. Thinko in f9afd56218af. Reported-by: Man Zeng Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- h

pgsql: Fix concurrent sequence drops during sequence synchronization.

2026-01-20 Thread Amit Kapila
Fix concurrent sequence drops during sequence synchronization. A recent BF failure showed that commit 7a485bd641 did not handle the case where a sequence is dropped concurrently during sequence synchronization on the subscriber. Previously, pg_get_sequence_data() would ERROR out if the sequence wa

Re: pgsql: tests: Add a test C++ extension module

2026-01-20 Thread Peter Smith
On Wed, Jan 21, 2026 at 2:43 AM Peter Eisentraut wrote: > > tests: Add a test C++ extension module > > While we already test that our headers are valid C++ using > headerscheck, it turns out that the macros we define might still > expand to invalid C++ code. This adds a minimal test extension tha

pgsql: Improve errdetail for logical replication conflict messages.

2026-01-20 Thread Amit Kapila
Improve errdetail for logical replication conflict messages. This change enhances the clarity and usefulness of error detail messages generated during logical replication conflicts. The following improvements have been made: 1. Eliminate redundant output: Avoid printing duplicate remote row and r

pgsql: tests: Add a test C++ extension module

2026-01-20 Thread Peter Eisentraut
tests: Add a test C++ extension module While we already test that our headers are valid C++ using headerscheck, it turns out that the macros we define might still expand to invalid C++ code. This adds a minimal test extension that is compiled using C++ to test that it's actually possible to build

pgsql: Use integer backend type when exec'ing a postmaster child

2026-01-20 Thread Álvaro Herrera
Use integer backend type when exec'ing a postmaster child This way we don't have to walk the entire process type array and strcmp() the string with the names therein. The integer value can be directly used as array index instead. Author: Álvaro Herrera Reviewed-by: Euler Taveira Discussion: ht

pgsql: Remove redundant pg_unreachable() after elog(ERROR) from ExecWai

2026-01-20 Thread Alexander Korotkov
Remove redundant pg_unreachable() after elog(ERROR) from ExecWaitStmt() elog(ERROR) never returns. Compilers don't always understand this. So, sometimes, we have to append pg_unreachable() to keep the compiler quiet about returning from a non-void function without a value. But pg_unreachable()

pgsql: Update some comments for fasthash

2026-01-20 Thread John Naylor
Update some comments for fasthash - Add advice about hashing multiple inputs with the incremental API - Generalize statements that were specific to C strings to include all variable length inputs, where applicable. - Update comments about the standalone functions and make it easy to find them.

pgsql: Fix for C++ compatibility

2026-01-20 Thread Peter Eisentraut
Fix for C++ compatibility After commit 476b35d4e31, some buildfarm members are complaining about not recognizing _Noreturn when building the new C++ module test_cplusplusext. This is not a C++ feature, but it was gated like #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L #de