pgsql: Remove redundant SET enable_partitionwise_join = on.

2026-01-05 Thread Robert Haas
Remove redundant SET enable_partitionwise_join = on. partition_join.sql keeps partitionwise join enabled for the entire file, so we don't need to enable it for this test case individually. Author: Ashutosh Bapat Discussion: http://postgr.es/m/CAExHW5uRW=Z==bmLR=nxm6vv3jgh4ruvb+rfft8tfjrfzuu...@

pgsql: Adjust errcode in checkPartition()

2026-01-05 Thread Alexander Korotkov
Adjust errcode in checkPartition() Replace ERRCODE_UNDEFINED_TABLE with ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE for the case where we don't find a parent-child relationship between the partitioned table and its partition. In this case, tables are present, but they are not in a prerequisite state

pgsql: Use WAIT FOR LSN in PostgreSQL::Test::Cluster::wait_for_catchup(

2026-01-05 Thread Alexander Korotkov
Use WAIT FOR LSN in PostgreSQL::Test::Cluster::wait_for_catchup() When the standby is passed as a PostgreSQL::Test::Cluster instance, use the WAIT FOR LSN command on the standby server to implement wait_for_catchup() for replay, write, and flush modes. This is more efficient than polling pg_stat_

pgsql: Extend xlogwait infrastructure with write and flush wait types

2026-01-05 Thread Alexander Korotkov
Extend xlogwait infrastructure with write and flush wait types Add support for waiting on WAL write and flush LSNs in addition to the existing replay LSN wait type. This provides the foundation for extending the WAIT FOR command with MODE parameter. Key changes are following. - Add WAIT_LSN_TYPE_

pgsql: Add tab completion for the WAIT FOR LSN MODE option

2026-01-05 Thread Alexander Korotkov
Add tab completion for the WAIT FOR LSN MODE option Update psql tab completion to support the optional MODE option in the WAIT FOR LSN command. After specifying an LSN value, completion now offers both MODE and WITH keywords. The MODE option specifies which LSN type to wait for. In particular,

pgsql: Add the MODE option to the WAIT FOR LSN command

2026-01-05 Thread Alexander Korotkov
Add the MODE option to the WAIT FOR LSN command This commit extends the WAIT FOR LSN command with an optional MODE option in the WITH clause that specifies which LSN type to wait for: WAIT FOR LSN '' [WITH (MODE '', ...)] where mode can be: - 'standby_replay' (default): Wait for WAL to be rep

pgsql: Update to latest Snowball sources.

2026-01-05 Thread Tom Lane
Update to latest Snowball sources. It's been almost a year since we last did this, and upstream has been busy. They've added stemmers for Polish and Esperanto, and also deprecated their old Dutch stemmer in favor of the Kraaij-Pohlmann algorithm. (The "dutch" stemmer is now the latter, and "dutc

pgsql: Fix typo in parallel.c.

2026-01-05 Thread Masahiko Sawada
Fix typo in parallel.c. Author: kelan Reviewed-by: Chao Li Reviewed-by: Masahiko Sawada Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d351063e49ac79399338b3aa5b9da39cde746030

pgsql: ci: Remove ulimit -p for netbsd/openbsd

2026-01-05 Thread Andres Freund
ci: Remove ulimit -p for netbsd/openbsd Previously the ulimit -p 256 was needed to increase the limit on openbsd. However, sometimes the limit actually was too low, causing "could not fork new process for connection: Resource temporarily unavailable" errors. Most commonly on netbsd, but also on

pgsql: ci: Remove ulimit -p for netbsd/openbsd

2026-01-05 Thread Andres Freund
ci: Remove ulimit -p for netbsd/openbsd Previously the ulimit -p 256 was needed to increase the limit on openbsd. However, sometimes the limit actually was too low, causing "could not fork new process for connection: Resource temporarily unavailable" errors. Most commonly on netbsd, but also on

Re: pgsql: Update to latest Snowball sources.

2026-01-05 Thread Jelte Fennema-Nio
On Mon, 5 Jan 2026 at 21:23, Tom Lane wrote: > > Update to latest Snowball sources. On my own CI I got some failures seemingly related to this: https://cirrus-ci.com/task/5989391459418112 Might be build cache issues or something (that I don't have time to look into right now), but wanted to call

Re: pgsql: Update to latest Snowball sources.

2026-01-05 Thread Tom Lane
Jelte Fennema-Nio writes: > On my own CI I got some failures seemingly related to this: > https://cirrus-ci.com/task/5989391459418112 If it's in a meson build, yeah ... fixed ... regards, tom lane

pgsql: Clarify where various catcache.h dlist_nodes are used

2026-01-05 Thread David Rowley
Clarify where various catcache.h dlist_nodes are used Also remove a comment which mentions we don't currently divide the per-cache lists into hash buckets. Since 473182c95, we do. Author: ChangAo Chen Discussion: https://postgr.es/m/[email protected] Branch -

pgsql: Fix misleading comment for GetOperatorFromCompareType

2026-01-05 Thread David Rowley
Fix misleading comment for GetOperatorFromCompareType The comment claimed *strat got set to InvalidStrategy when the function lookup fails. This isn't true; an ERROR is raised when that happens. Author: Paul A Jungwirth Reviewed-by: Neil Chen Discussion: https://postgr.es/m/ca+renyxorjlacp_nh

pgsql: Fix misleading comment for GetOperatorFromCompareType

2026-01-05 Thread David Rowley
Fix misleading comment for GetOperatorFromCompareType The comment claimed *strat got set to InvalidStrategy when the function lookup fails. This isn't true; an ERROR is raised when that happens. Author: Paul A Jungwirth Discussion: https://postgr.es/m/ca+renyxorjlacp_nhqequf2w+zcoy2q5kpqcfg05v

pgsql: Simplify GetOperatorFromCompareType() code

2026-01-05 Thread David Rowley
Simplify GetOperatorFromCompareType() code The old code would set *opid = InvalidOid to determine if the get_opclass_opfamily_and_input_type() worked or not. This means more moving parts that what's really needed here. Let's just fail immediately if the get_opclass_opfamily_and_input_type() look

pgsql: pg_visibility: Fix incorrect buffer lock description in comment.

2026-01-05 Thread Masahiko Sawada
pg_visibility: Fix incorrect buffer lock description in comment. Although the comment in collect_corrupt_items() stated that the buffer is locked in exclusive mode, it is actually locked in shared mode. Author: Chao Li Discussion: https://postgr.es/m/CAEoWx2kkhxgfp=kinpmetnwhaa0jjr6ybko_0gg0oiy

pgsql: Fix meson build of snowball code.

2026-01-05 Thread Tom Lane
Fix meson build of snowball code. include/snowball/libstemmer has to be in the -I search path, as it is in the autoconf build. It's not apparent to me how this ever worked before, nor why my recent commit made it stop working. Discussion: https://postgr.es/m/ld2iurl7kzexwydxmdfhdgarpa7xxsfrgvgg

pgsql: Use relation_close() more consistently in contrib/

2026-01-05 Thread Michael Paquier
Use relation_close() more consistently in contrib/ All the code paths updated here have been using index_close() to close a relation that was opened with relation_open(), in pgstattuple and pageinspect. index_close() does the same thing as relation_close(), so there is no harm, but being inconsis

pgsql: Fix typo in planner.c

2026-01-05 Thread Michael Paquier
Fix typo in planner.c b8cfcb9e00da did not get this change right. Author: Alexander Law Discussion: https://postgr.es/m/CAJ0YPFFWhJXs-e-=7iJz-FLp=b1dXfJA_qtrVAgto=bzmzd...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ae283736025c2d0b41a4106788b4

pgsql: Allow bgworkers to be terminated for database-related commands

2026-01-05 Thread Michael Paquier
Allow bgworkers to be terminated for database-related commands Background workers gain a new flag, called BGWORKER_INTERRUPTIBLE, that offers the possibility to terminate the workers when these are connected to a database that is involved in one of the following commands: ALTER DATABASE RENAME TO

pgsql: Update comments atop ReplicationSlotCreate.

2026-01-05 Thread Amit Kapila
Update comments atop ReplicationSlotCreate. Since commit 1462aad2e4, which introduced the ability to modify the two_phase property of a slot, the comments above ReplicationSlotCreate have become outdated. We have now added a cautionary note in the comments above ReplicationSlotAlter explaining whe

pgsql: Update comments atop ReplicationSlotCreate.

2026-01-05 Thread Amit Kapila
Update comments atop ReplicationSlotCreate. Since commit 1462aad2e4, which introduced the ability to modify the two_phase property of a slot, the comments above ReplicationSlotCreate have become outdated. We have now added a cautionary note in the comments above ReplicationSlotAlter explaining whe

pgsql: Add TAP test for GUC settings passed via CONNECTION in logical r

2026-01-05 Thread Fujii Masao
Add TAP test for GUC settings passed via CONNECTION in logical replication. Commit d926462d819 restored the behavior of passing GUC settings from the CONNECTION string to the publisher's walsender, allowing per-connection configuration. This commit adds a TAP test to verify that behavior works co

pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.

2026-01-05 Thread Fujii Masao
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Prior to v15, GUC settings supplied in the CONNECTION clause of CREATE SUBSCRIPTION were correctly passed through to the publisher's walsender. For example: CREATE SUBSCRIPTION mysub CONNECTION 'options=''-c wal_s

pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.

2026-01-05 Thread Fujii Masao
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Prior to v15, GUC settings supplied in the CONNECTION clause of CREATE SUBSCRIPTION were correctly passed through to the publisher's walsender. For example: CREATE SUBSCRIPTION mysub CONNECTION 'options=''-c wal_s

pgsql: Add TAP test for GUC settings passed via CONNECTION in logical r

2026-01-05 Thread Fujii Masao
Add TAP test for GUC settings passed via CONNECTION in logical replication. Commit d926462d819 restored the behavior of passing GUC settings from the CONNECTION string to the publisher's walsender, allowing per-connection configuration. This commit adds a TAP test to verify that behavior works co

pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.

2026-01-05 Thread Fujii Masao
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Prior to v15, GUC settings supplied in the CONNECTION clause of CREATE SUBSCRIPTION were correctly passed through to the publisher's walsender. For example: CREATE SUBSCRIPTION mysub CONNECTION 'options=''-c wal_s

pgsql: Add TAP test for GUC settings passed via CONNECTION in logical r

2026-01-05 Thread Fujii Masao
Add TAP test for GUC settings passed via CONNECTION in logical replication. Commit d926462d819 restored the behavior of passing GUC settings from the CONNECTION string to the publisher's walsender, allowing per-connection configuration. This commit adds a TAP test to verify that behavior works co

pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.

2026-01-05 Thread Fujii Masao
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Prior to v15, GUC settings supplied in the CONNECTION clause of CREATE SUBSCRIPTION were correctly passed through to the publisher's walsender. For example: CREATE SUBSCRIPTION mysub CONNECTION 'options=''-c wal_s

pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.

2026-01-05 Thread Fujii Masao
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Prior to v15, GUC settings supplied in the CONNECTION clause of CREATE SUBSCRIPTION were correctly passed through to the publisher's walsender. For example: CREATE SUBSCRIPTION mysub CONNECTION 'options=''-c wal_s

pgsql: Add TAP test for GUC settings passed via CONNECTION in logical r

2026-01-05 Thread Fujii Masao
Add TAP test for GUC settings passed via CONNECTION in logical replication. Commit d926462d819 restored the behavior of passing GUC settings from the CONNECTION string to the publisher's walsender, allowing per-connection configuration. This commit adds a TAP test to verify that behavior works co

pgsql: Add TAP test for GUC settings passed via CONNECTION in logical r

2026-01-05 Thread Fujii Masao
Add TAP test for GUC settings passed via CONNECTION in logical replication. Commit d926462d819 restored the behavior of passing GUC settings from the CONNECTION string to the publisher's walsender, allowing per-connection configuration. This commit adds a TAP test to verify that behavior works co

pgsql: Fix typo in slot.c.

2026-01-05 Thread Amit Kapila
Fix typo in slot.c. Author: Chao Li Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/cajdixggzxqz7bd0qctizdt6us9ax6zkk4dwxzgb5x3+tsvh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/63

pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

2026-01-05 Thread David Rowley
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION When processing the "publish" options of an ALTER PUBLICATION command, we call SplitIdentifierString() to split the options into a List of strings. Since SplitIdentifierString() modifies the delimiter character and puts NULs in their place, this

pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

2026-01-05 Thread David Rowley
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION When processing the "publish" options of an ALTER PUBLICATION command, we call SplitIdentifierString() to split the options into a List of strings. Since SplitIdentifierString() modifies the delimiter character and puts NULs in their place, this

pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

2026-01-05 Thread David Rowley
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION When processing the "publish" options of an ALTER PUBLICATION command, we call SplitIdentifierString() to split the options into a List of strings. Since SplitIdentifierString() modifies the delimiter character and puts NULs in their place, this

pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

2026-01-05 Thread David Rowley
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION When processing the "publish" options of an ALTER PUBLICATION command, we call SplitIdentifierString() to split the options into a List of strings. Since SplitIdentifierString() modifies the delimiter character and puts NULs in their place, this

pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

2026-01-05 Thread David Rowley
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION When processing the "publish" options of an ALTER PUBLICATION command, we call SplitIdentifierString() to split the options into a List of strings. Since SplitIdentifierString() modifies the delimiter character and puts NULs in their place, this

pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

2026-01-05 Thread David Rowley
Fix issue with EVENT TRIGGERS and ALTER PUBLICATION When processing the "publish" options of an ALTER PUBLICATION command, we call SplitIdentifierString() to split the options into a List of strings. Since SplitIdentifierString() modifies the delimiter character and puts NULs in their place, this

pgsql: doc: Fix outdated doc in pg_rewind.

2026-01-05 Thread Fujii Masao
doc: Fix outdated doc in pg_rewind. Update pg_rewind documentation to reflect the change that data checksums are now enabled by default during initdb. Backpatch to v18, where data checksums were changed to be enabled by default. Author: Zhijie Hou Reviewed-by: Chao Li Reviewed-by: Fujii Masao

pgsql: doc: Fix outdated doc in pg_rewind.

2026-01-05 Thread Fujii Masao
doc: Fix outdated doc in pg_rewind. Update pg_rewind documentation to reflect the change that data checksums are now enabled by default during initdb. Backpatch to v18, where data checksums were changed to be enabled by default. Author: Zhijie Hou Reviewed-by: Chao Li Reviewed-by: Fujii Masao

pgsql: Fix comment in tableam.c

2026-01-05 Thread Michael Paquier
Fix comment in tableam.c Author: shiyu qin Discussion: https://postgr.es/m/cajucm3ujjolr1zfkozd4j71t-hdefdfw1ktqomkywkzp0hz...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/877ae5db8968555d7a5634e69018dfe6c55976eb Modified Files -- sr

pgsql: Separate read and write pointers in pg_saslprep

2026-01-05 Thread Peter Eisentraut
Separate read and write pointers in pg_saslprep Use separate pointers for reading const input ('p') and writing to mutable output ('outp'), avoiding the need to cast away const on the input parameter. Author: Bertrand Drouvot Discussion: https://postgr.es/m/aUQHy/MmWq7c97wK%40ip-10-97-1-34.eu-w

pgsql: Use the GetPGProcByNumber() macro when possible

2026-01-05 Thread David Rowley
Use the GetPGProcByNumber() macro when possible A few places were accessing &ProcGlobal->allProcs directly, so adjust them to use the accessor macro instead. Author: Maksim Melnikov Reviewed-by: Chao Li Reviewed-by: David Rowley Discussion: https://postgr.es/m/80621c00-aba6-483c-88b1-a845461d

pgsql: Tighten up assertion on a local variable

2026-01-05 Thread Heikki Linnakangas
Tighten up assertion on a local variable 'lineindex' is 0-based, as mentioned in the comments. Backpatch to v18 where the assertion was added. Author: ChangAo Chen Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/[email protected] Backpa

pgsql: Tighten up assertion on a local variable

2026-01-05 Thread Heikki Linnakangas
Tighten up assertion on a local variable 'lineindex' is 0-based, as mentioned in the comments. Backpatch to v18 where the assertion was added. Author: ChangAo Chen Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/[email protected] Backpa