Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().

2025-06-11 Thread Robert Haas
On Tue, Jun 10, 2025 at 2:24 PM Jeff Davis wrote: > copyfromparse.c: use pg_ascii_tolower() rather than tolower(). > > Avoid dependence on setlocale(). No behavior change. > > Discussion: > https://postgr.es/m/[email protected] > Reviewed-by: Peter Eisentraut A

pgsql: Add tab completion for REJECT_LIMIT option.

2025-06-11 Thread Masahiko Sawada
Add tab completion for REJECT_LIMIT option. This addresses an oversight in commit 4ac2a9bec, which introduced the REJECT_LIMIT option to the COPY command. Author: Atsushi Torikoshi Reviewed-by: Yugo Nagata Discussion: https://postgr.es/m/[email protected] Branch

pgsql: Revert "nbtree: Remove useless row compare arg."

2025-06-11 Thread Peter Geoghegan
Revert "nbtree: Remove useless row compare arg." This reverts commit 54c6ea8c81db718508eeea50991d3c1c5dff54a5. Further analysis has shown that the forcenonrequired row compare behavior is in fact necessary, despite the new restrictions on RowCompares imposed by _bt_set_startikey following commit

pgsql: Revert support for improved tracking of nested queries

2025-06-11 Thread Michael Paquier
Revert support for improved tracking of nested queries This commit reverts the two following commits: - 499edb09741b, track more precisely query locations for nested statements. - 06450c7b8c70, a follow-up fix of 499edb09741b with query locations. The test introduced in this commit is not reverted

Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().

2025-06-11 Thread Robert Haas
On Wed, Jun 11, 2025 at 6:15 PM Jeff Davis wrote: > On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote: > > All 3 of these commits seem like things that could just as well have > > been done after we branch. > > Yeah, I called out my mistake here: > > https://www.postgresql.org/message-id/60e8c6

Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().

2025-06-11 Thread Jeff Davis
On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote: > All 3 of these commits seem like things that could just as well have > been done after we branch. Yeah, I called out my mistake here: https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710065.camel%40j-davis.com Nobody

pgsql: Revert a few small patches that were intended for version 19.

2025-06-11 Thread Jeff Davis
Revert a few small patches that were intended for version 19. - 4c787a24e7e220a60022e47c1776f22f72902899 - 78bd364ee39ca70a8f9cb8719282389866a08e14 - 7a6880fadc177873d5663961ec3a02d67e34dcbe - 8898082a5d3e94eef073f0e08124137e096e78ef Suggested-by: Robert Haas Discussion: https://postgr.es/m/CA+

pgsql: Make _bt_killitems drop pins it acquired itself.

2025-06-11 Thread Peter Geoghegan
Make _bt_killitems drop pins it acquired itself. Teach nbtree's _bt_killitems to leave the so->currPos page that it sets LP_DEAD items on in whatever state it was in when _bt_killitems was called. In particular, make sure that so->dropPin scans don't acquire a pin whose reference is saved in so->

pgsql: Make _bt_killitems drop pins it acquired itself.

2025-06-11 Thread Peter Geoghegan
Make _bt_killitems drop pins it acquired itself. Teach nbtree's _bt_killitems to leave the so->currPos page that it sets LP_DEAD items on in whatever state it was in when _bt_killitems was called. In particular, make sure that so->dropPin scans don't acquire a pin whose reference is saved in so->

pgsql: Make _bt_killitems drop pins it acquired itself.

2025-06-11 Thread Peter Geoghegan
Make _bt_killitems drop pins it acquired itself. Teach nbtree's _bt_killitems to leave the so->currPos page that it sets LP_DEAD items on in whatever state it was in when _bt_killitems was called. In particular, make sure that so->dropPin scans don't acquire a pin whose reference is saved in so->

pgsql: Make _bt_killitems drop pins it acquired itself.

2025-06-11 Thread Peter Geoghegan
Make _bt_killitems drop pins it acquired itself. Teach nbtree's _bt_killitems to leave the so->currPos page that it sets LP_DEAD items on in whatever state it was in when _bt_killitems was called. In particular, make sure that so->dropPin scans don't acquire a pin whose reference is saved in so->

pgsql: Make _bt_killitems drop pins it acquired itself.

2025-06-11 Thread Peter Geoghegan
Make _bt_killitems drop pins it acquired itself. Teach nbtree's _bt_killitems to leave the so->currPos page that it sets LP_DEAD items on in whatever state it was in when _bt_killitems was called. In particular, make sure that so->dropPin scans don't acquire a pin whose reference is saved in so->

pgsql: Make _bt_killitems drop pins it acquired itself.

2025-06-11 Thread Peter Geoghegan
Make _bt_killitems drop pins it acquired itself. Teach nbtree's _bt_killitems to leave the so->currPos page that it sets LP_DEAD items on in whatever state it was in when _bt_killitems was called. In particular, make sure that so->dropPin scans don't acquire a pin whose reference is saved in so->

pgsql: doc: Document that MAINTAIN privilege allows statistics manipula

2025-06-11 Thread Fujii Masao
doc: Document that MAINTAIN privilege allows statistics manipulation functions. Database object statistics manipulation functions were introduced in PostgreSQL 18 and are permitted under the MAINTAIN privilege. However, the documentation previously did not mention these functions in the list of al