pgsql: Remove assertion based on pending_since in pgstat_report_stat()

2025-04-22 Thread Michael Paquier
Remove assertion based on pending_since in pgstat_report_stat() This assertion, based on pending_since (timestamp used to prevent stats reports to be too frequent or should a partial flush happen), is reached when it is found that no data can be flushed but a previous call of pgstat_report_stat()

pgsql: Remove assertion based on pending_since in pgstat_report_stat()

2025-04-22 Thread Michael Paquier
Remove assertion based on pending_since in pgstat_report_stat() This assertion, based on pending_since (timestamp used to prevent stats reports to be too frequent or should a partial flush happen), is reached when it is found that no data can be flushed but a previous call of pgstat_report_stat()

pgsql: Remove assertion based on pending_since in pgstat_report_stat()

2025-04-22 Thread Michael Paquier
Remove assertion based on pending_since in pgstat_report_stat() This assertion, based on pending_since (timestamp used to prevent stats reports to be too frequent or should a partial flush happen), is reached when it is found that no data can be flushed but a previous call of pgstat_report_stat()

pgsql: Remove assertion based on pending_since in pgstat_report_stat()

2025-04-22 Thread Michael Paquier
Remove assertion based on pending_since in pgstat_report_stat() This assertion, based on pending_since (timestamp used to prevent stats reports to be too frequent or should a partial flush happen), is reached when it is found that no data can be flushed but a previous call of pgstat_report_stat()

pgsql: Fix an oversight in 3f28b2fcac.

2025-04-22 Thread Amit Kapila
Fix an oversight in 3f28b2fcac. Commit 3f28b2fcac tried to ensure that the replication origin shouldn't be advanced in case of an ERROR in the apply worker, so that it can request the same data again after restart. However, it is possible that an ERROR was caught and handled by a (say PL/pgSQL) fu

pgsql: Fix an oversight in 3f28b2fcac.

2025-04-22 Thread Amit Kapila
Fix an oversight in 3f28b2fcac. Commit 3f28b2fcac tried to ensure that the replication origin shouldn't be advanced in case of an ERROR in the apply worker, so that it can request the same data again after restart. However, it is possible that an ERROR was caught and handled by a (say PL/pgSQL) fu

pgsql: Fix an oversight in 3f28b2fcac.

2025-04-22 Thread Amit Kapila
Fix an oversight in 3f28b2fcac. Commit 3f28b2fcac tried to ensure that the replication origin shouldn't be advanced in case of an ERROR in the apply worker, so that it can request the same data again after restart. However, it is possible that an ERROR was caught and handled by a (say PL/pgSQL) fu

pgsql: gen_node_support.pl: improve error message for unclosed struct.

2025-04-22 Thread Tom Lane
gen_node_support.pl: improve error message for unclosed struct. This error message was 'runaway "struct_name"', which isn't all that clear; I think 'could not find closing brace for "struct_name"' is better. Also, provide the location of the struct start using the script's usual '$file:$lineno' s

pgsql: Avoid depending on post-UPDATE row order in float4/float8 tests.

2025-04-22 Thread Tom Lane
Avoid depending on post-UPDATE row order in float4/float8 tests. While heapam reproduces the insertion order of rows well, updates can move rows to varying places depending on autovacuum activity. In most regression tests we've guarded against getting variable results due to that, but float4.sql a

pgsql: psql: Rework TAP routine psql_fails_like() to define WAL sender

2025-04-22 Thread Michael Paquier
psql: Rework TAP routine psql_fails_like() to define WAL sender context The routine was coded so as a WAL sender was always used, state required only for one failure test related to START_REPLICATION. This test is changed so as a WAL sender is used by passing a replication option to psql_fails_li

pgsql: Re-enable SSL connect_fails tests, and fix related race conditio

2025-04-22 Thread Tom Lane
Re-enable SSL connect_fails tests, and fix related race conditions. Cluster.pm's connect_fails routine has long had the ability to sniff the postmaster log file for expected messages after a connection failure. However, that's always had a race condition: on some platforms it's possible for psql