Remove assertion checking query ID in execMain.c
This assertion has been added by 24f520594809, but Alexander Lakhin has
proved that the ExecutorRun() one can be broken by using a PL function
that manipulates compute_query_id and track_activities, while the ones
in ExecutorFinish() and ExecutorEnd
Refactor CopyFrom() in copyfrom.c.
This commit simplifies CopyFrom() by removing the unnecessary local variable
'skipped', which tracked the number of rows skipped due to on_error = 'ignore'.
That count is already handled by cstate->num_errors, so the 'skipped' variable
was redundant.
Additionall
Hi, Amit!
On Thu, Oct 3, 2024 at 6:01 AM Amit Langote wrote:
> Fix expression list handling in ATExecAttachPartition()
+* since it’s needed later to construct the constraint expression for
I don't think we're good about using unicode apostrophes. Could you,
please, switch to ascii?
--
On Thu, Oct 3, 2024 at 18:57 Alexander Korotkov
wrote:
> Hi, Amit!
>
> On Thu, Oct 3, 2024 at 6:01 AM Amit Langote
> wrote:
> > Fix expression list handling in ATExecAttachPartition()
>
> +* since it’s needed later to construct the constraint expression for
>
> I don't think we're good about
Replace Unicode apostrophe with ASCII apostrophe
In commit babb3993dbe9, I accidentally introduced a Unicode
apostrophe (U+2019). This commit replaces it with the ASCII
apostrophe (U+0027) for consistency.
Reported-by: Alexander Korotkov
Discussion:
https://postgr.es/m/capphfdunwmbjkjftqxjremk6
On Thu, Oct 3, 2024 at 7:12 PM Amit Langote wrote:
> On Thu, Oct 3, 2024 at 18:57 Alexander Korotkov wrote:
>>
>> Hi, Amit!
>>
>> On Thu, Oct 3, 2024 at 6:01 AM Amit Langote wrote:
>> > Fix expression list handling in ATExecAttachPartition()
>>
>> +* since it’s needed later to construct the
On Thu, Oct 3, 2024 at 2:02 PM Amit Langote wrote:
> On Thu, Oct 3, 2024 at 7:12 PM Amit Langote
> wrote:
> > On Thu, Oct 3, 2024 at 18:57 Alexander Korotkov
> wrote:
> >>
> >> Hi, Amit!
> >>
> >> On Thu, Oct 3, 2024 at 6:01 AM Amit Langote
> wrote:
> >> > Fix expression list handling in ATExe
Fix incorrect non-strict join recheck in MERGE WHEN NOT MATCHED BY SOURCE.
If a MERGE command contains WHEN NOT MATCHED BY SOURCE actions, the
merge join condition is used by the executor to distinguish MATCHED
from NOT MATCHED BY SOURCE cases. However, this qual is executed using
the output from
Fix incorrect non-strict join recheck in MERGE WHEN NOT MATCHED BY SOURCE.
If a MERGE command contains WHEN NOT MATCHED BY SOURCE actions, the
merge join condition is used by the executor to distinguish MATCHED
from NOT MATCHED BY SOURCE cases. However, this qual is executed using
the output from
Fix wrong varnullingrels error for MERGE WHEN NOT MATCHED BY SOURCE.
If a MERGE command contains WHEN NOT MATCHED BY SOURCE actions, the
source relation appears on the outer side of the join. Thus, any Vars
referring to the source in the merge join condition, actions, and
RETURNING list should be
Fix wrong varnullingrels error for MERGE WHEN NOT MATCHED BY SOURCE.
If a MERGE command contains WHEN NOT MATCHED BY SOURCE actions, the
source relation appears on the outer side of the join. Thus, any Vars
referring to the source in the merge join condition, actions, and
RETURNING list should be
11 matches
Mail list logo
