pgsql: tests: Restrict pg_locks queries in advisory_locks.sql to curren

2024-09-25 Thread Michael Paquier
tests: Restrict pg_locks queries in advisory_locks.sql to current database Otherwise testing an existing installation can fail, if there are other locks, e.g. from one of the isolation tests. This was originally applied as c3315a7da57b in 16~, but it is possible to see this test fail depending on

pgsql: tests: Restrict pg_locks queries in advisory_locks.sql to curren

2024-09-25 Thread Michael Paquier
tests: Restrict pg_locks queries in advisory_locks.sql to current database Otherwise testing an existing installation can fail, if there are other locks, e.g. from one of the isolation tests. This was originally applied as c3315a7da57b in 16~, but it is possible to see this test fail depending on

pgsql: tests: Restrict pg_locks queries in advisory_locks.sql to curren

2024-09-25 Thread Michael Paquier
tests: Restrict pg_locks queries in advisory_locks.sql to current database Otherwise testing an existing installation can fail, if there are other locks, e.g. from one of the isolation tests. This was originally applied as c3315a7da57b in 16~, but it is possible to see this test fail depending on

pgsql: tests: Restrict pg_locks queries in advisory_locks.sql to curren

2024-09-25 Thread Michael Paquier
tests: Restrict pg_locks queries in advisory_locks.sql to current database Otherwise testing an existing installation can fail, if there are other locks, e.g. from one of the isolation tests. This was originally applied as c3315a7da57b in 16~, but it is possible to see this test fail depending on

pgsql: Remove extra whitespace in pg_upgrade status message.

2024-09-25 Thread Nathan Bossart
Remove extra whitespace in pg_upgrade status message. There's no need to add another level of indentation to this status message. pg_log() will put it in the right place. Oversight in commit 347758b120. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/ZunW7XHLd2uTts4f%40nathan Bac

pgsql: Remove extra whitespace in pg_upgrade status message.

2024-09-25 Thread Nathan Bossart
Remove extra whitespace in pg_upgrade status message. There's no need to add another level of indentation to this status message. pg_log() will put it in the right place. Oversight in commit 347758b120. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/ZunW7XHLd2uTts4f%40nathan Bac

pgsql: Turn 'if' condition around to avoid Svace complaint

2024-09-25 Thread Alvaro Herrera
Turn 'if' condition around to avoid Svace complaint The unwritten assumption of this code is that both events->head and events->tail are NULL together (an empty list) or they aren't. So the code was testing events->head for nullness and using that as a cue to deference events->tail, which annoys