pgsql: Remove unnecessary code from be_lo_put()

2024-04-25 Thread Peter Eisentraut
Remove unnecessary code from be_lo_put() A permission check is performed in be_lo_put() just after returning from inv_open(), but the permission is already checked in inv_open(), so we can remove the second check. This check was added in 8d9881911f0, but then the refactoring in ae20b23a9e7 should

pgsql: Post-commit review fixes for slot synchronization.

2024-04-25 Thread Amit Kapila
Post-commit review fixes for slot synchronization. Allow pg_sync_replication_slots() to error out during promotion of standby. This makes the behavior of the SQL function consistent with the slot sync worker. We also ensured that pg_sync_replication_slots() cannot be executed if sync_replication_s

pgsql: doc: Add link to table

2024-04-25 Thread Peter Eisentraut
doc: Add link to table Formal tables should generally have an xref in the text that points to them. Add them here. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e03ec4641d2493db6fbfc60ff78d0f0b36d2ead1 Modified Files -- doc/src/sgml/func.sgml | 2 +-

pgsql: Avoid unnecessary "touch meson.build" in vpath builds

2024-04-25 Thread Andres Freund
Avoid unnecessary "touch meson.build" in vpath builds In e6927270cd1 I added a 'touch meson.build' to configure.ac, to ensure conflicts between in-tree configure based builds and meson builds are automatically detected. Unfortunately I omitted spaces around the condition restricting this to in-tre

pgsql: Avoid unnecessary "touch meson.build" in vpath builds

2024-04-25 Thread Andres Freund
Avoid unnecessary "touch meson.build" in vpath builds In e6927270cd1 I added a 'touch meson.build' to configure.ac, to ensure conflicts between in-tree configure based builds and meson builds are automatically detected. Unfortunately I omitted spaces around the condition restricting this to in-tre

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-25 Thread Heikki Linnakangas
On 24/04/2024 15:57, Peter Eisentraut wrote: On 08.04.24 03:25, Heikki Linnakangas wrote: Refactor libpq state machine for negotiating encryption This fixes the few corner cases noted in commit 705843d294, as shown by the changes in the test. Either this or something nearby appears to have br

pgsql: radixtree: Fix SIGSEGV at update of embeddable value to non-embe

2024-04-25 Thread Masahiko Sawada
radixtree: Fix SIGSEGV at update of embeddable value to non-embeddable. Also, fix a memory leak when updating from non-embeddable to embeddable. Both were unreachable without adding C code. Reported-by: Noah Misch Author: Noah Misch Reviewed-by: Masahiko Sawada, John Naylor Discussion: https://po

pgsql: pg_combinebackup: Detect checksum mismatches and document limita

2024-04-25 Thread Robert Haas
pg_combinebackup: Detect checksum mismatches and document limitation. If not all backups have the same checksum status, but the final backup has checksums enabled, then the output directory may include pages with invalid checksums. Document this limitation and explain how to work around it. In a