Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-20 Thread Daniel Gustafsson
> On 19 Nov 2023, at 21:08, Daniel Gustafsson wrote: > I'll have a look with fresh eyes in the morning, and hopefully it will be > fixable. If it get's messy it's quite possible that skipping v12 is the best > option. As an update, discussing with Andres off-list I have a potential patch for th

pgsql: Be more paranoid about OOM in search_path cache.

2023-11-20 Thread Jeff Davis
Be more paranoid about OOM in search_path cache. Recent commit f26c2368dc introduced a search_path cache, but left some potential out-of-memory hazards. Simplify the code and make it safer against OOM. This change reintroduces one list_copy(), losing a small amount of the performance gained in f2

pgsql: Optimize check_search_path() by using SearchPathCache.

2023-11-20 Thread Jeff Davis
Optimize check_search_path() by using SearchPathCache. A hash lookup is faster than re-validating the string, particularly because we use SplitIdentifierString() for validation. Important when search_path changes frequently. Discussion: https://postgr.es/m/04c8592dbd694e4114a3ed87139a7a04e43630

pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-20 Thread Andres Freund
meson: docs: Add {html,man} targets, rename install-doc-* We have toplevel html, man targets in the autoconf build as well. It'd be odd to have an 'html' target but have the install target be 'install-doc-html', thus rename the install targets to match. Reviewed-by: Christoph Berg Reviewed-by: P

pgsql: docs: meson: Change what 'docs' target builds

2023-11-20 Thread Andres Freund
docs: meson: Change what 'docs' target builds This undoes the change in what the 'docs' target builds 969509c3f2e. Tom was concerned with having a target to just build the html docs, which a prior commit now provided explicitly. A subsequent commit will overhaul the documentation for the document

pgsql: meson: Add 'world' target

2023-11-20 Thread Andres Freund
meson: Add 'world' target We have this for make as well. Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6614cfb43c8281feef5c4563ddc36ab04914014e Mod

pgsql: meson: Document build targets, add 'help' target

2023-11-20 Thread Andres Freund
meson: Document build targets, add 'help' target Currently important build targets are somewhat hard to discover. This commit documents important meson build targets in the sgml documentation. But it's awkward to have to lookup build targets in the docs when hacking, so this also adds a 'help' tar

pgsql: Log messages for replication slot acquisition and release.

2023-11-20 Thread Amit Kapila
Log messages for replication slot acquisition and release. This commit log messages (at LOG level when log_replication_commands is set, otherwise at DEBUG1 level) when walsenders acquire and release replication slots. These messages help to know the lifetime of a replication slot - one can know ho

pgsql: Simplify some logic in CreateReplicationSlot()

2023-11-20 Thread Michael Paquier
Simplify some logic in CreateReplicationSlot() This refactoring reduces the code in charge of creating replication slots from two "if" block to a single one, making it slightly cleaner. This change is possible since 1d04a59be31b, that has removed the intermediate code that existed between the two