pgsql: Commit b195e6d482 forgot to update meson.build.

2023-10-27 Thread Amit Kapila
Commit b195e6d482 forgot to update meson.build. Author: Hayato Kuroda Discussion: http://postgr.es/m/tycpr01mb58701ba358d80073ed1bd528f5...@tycpr01mb5870.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8949b978ff49a9b72455545e9bf08f4313a1b

pgsql: Adjust parallel_schedule with event triggers on authenticated lo

2023-10-27 Thread Alexander Korotkov
Adjust parallel_schedule with event triggers on authenticated login Event triggers on authenticated login could catch the connection of the concurrent test. In order to prevent this side effect we need to run the event_trigger test alone. Discussion: https://postgr.es/m/flat/camev5_ss5g7k1pcv2o

Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo

2023-10-27 Thread Alvaro Herrera
On 2023-Oct-27, Alexander Korotkov wrote: > Adjust parallel_schedule with event triggers on authenticated login > > Event triggers on authenticated login could catch the connection of the > concurrent test. In order to prevent this side effect we need to run > the event_trigger test alone. Hmm,

Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo

2023-10-27 Thread Alexander Korotkov
On Fri, Oct 27, 2023 at 1:48 PM Alvaro Herrera wrote: > On 2023-Oct-27, Alexander Korotkov wrote: > > > Adjust parallel_schedule with event triggers on authenticated login > > > > Event triggers on authenticated login could catch the connection of the > > concurrent test. In order to prevent this

Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo

2023-10-27 Thread Alvaro Herrera
On 2023-Oct-27, Alexander Korotkov wrote: > OK, I'm good with this. > Do you like me to push this? Or do you like to push it yourself? Please do. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/

pgsql: |--- gitweb subject length limit ----------------|-email limit-|

2023-10-27 Thread Bruce Momjian
|--- gitweb subject length limit |-email limit-| doc: fix first-person wording Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: master Branch -- master Details --- https://gi

pgsql: doc: clarify logical decoding's deadlock of system tables

2023-10-27 Thread Bruce Momjian
doc: clarify logical decoding's deadlock of system tables Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/16

pgsql: Fix calculation in brin_minmax_multi_distance_date

2023-10-27 Thread Tomas Vondra
Fix calculation in brin_minmax_multi_distance_date When calculating the distance between date values, make sure to subtract them in the right order, i.e. (larger - smaller). The distance is used to determine which values to merge, and is expected to be a positive value. The code unfortunately did

pgsql: Fix minmax-multi on infinite date/timestamp values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi on infinite date/timestamp values Make sure that infinite values in date/timestamp columns are treated as if in infinite distance. Infinite values should not be merged with other values, leaving them as outliers. The code however returned distance 0 in this case, so that infinite

pgsql: Fix overflow when calculating timestamp distance in BRIN

2023-10-27 Thread Tomas Vondra
Fix overflow when calculating timestamp distance in BRIN When calculating distances for timestamp values for BRIN minmax-multi indexes, we need to be careful about overflows for extreme values. If the value overflows into a negative value, the index may be inefficient. The new regression test che

pgsql: Fix minmax-multi distance for extreme interval values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi distance for extreme interval values When calculating distance for interval values, the code mostly mimicked interval_mi, i.e. it built a new interval value for the difference. That however does not work for sufficiently distant interval values, when the difference overflows the i

pgsql: Fix minmax-multi distance for extreme interval values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi distance for extreme interval values When calculating distance for interval values, the code mostly mimicked interval_mi, i.e. it built a new interval value for the difference. That however does not work for sufficiently distant interval values, when the difference overflows the i

pgsql: Fix minmax-multi on infinite date/timestamp values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi on infinite date/timestamp values Make sure that infinite values in date/timestamp columns are treated as if in infinite distance. Infinite values should not be merged with other values, leaving them as outliers. The code however returned distance 0 in this case, so that infinite

pgsql: Fix calculation in brin_minmax_multi_distance_date

2023-10-27 Thread Tomas Vondra
Fix calculation in brin_minmax_multi_distance_date When calculating the distance between date values, make sure to subtract them in the right order, i.e. (larger - smaller). The distance is used to determine which values to merge, and is expected to be a positive value. The code unfortunately did

pgsql: Fix overflow when calculating timestamp distance in BRIN

2023-10-27 Thread Tomas Vondra
Fix overflow when calculating timestamp distance in BRIN When calculating distances for timestamp values for BRIN minmax-multi indexes, we need to be careful about overflows for extreme values. If the value overflows into a negative value, the index may be inefficient. The new regression test che

pgsql: Fix minmax-multi distance for extreme interval values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi distance for extreme interval values When calculating distance for interval values, the code mostly mimicked interval_mi, i.e. it built a new interval value for the difference. That however does not work for sufficiently distant interval values, when the difference overflows the i

pgsql: Fix calculation in brin_minmax_multi_distance_date

2023-10-27 Thread Tomas Vondra
Fix calculation in brin_minmax_multi_distance_date When calculating the distance between date values, make sure to subtract them in the right order, i.e. (larger - smaller). The distance is used to determine which values to merge, and is expected to be a positive value. The code unfortunately did

pgsql: Fix overflow when calculating timestamp distance in BRIN

2023-10-27 Thread Tomas Vondra
Fix overflow when calculating timestamp distance in BRIN When calculating distances for timestamp values for BRIN minmax-multi indexes, we need to be careful about overflows for extreme values. If the value overflows into a negative value, the index may be inefficient. The new regression test che

pgsql: Fix minmax-multi on infinite date/timestamp values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi on infinite date/timestamp values Make sure that infinite values in date/timestamp columns are treated as if in infinite distance. Infinite values should not be merged with other values, leaving them as outliers. The code however returned distance 0 in this case, so that infinite

pgsql: Fix overflow when calculating timestamp distance in BRIN

2023-10-27 Thread Tomas Vondra
Fix overflow when calculating timestamp distance in BRIN When calculating distances for timestamp values for BRIN minmax-multi indexes, we need to be careful about overflows for extreme values. If the value overflows into a negative value, the index may be inefficient. The new regression test che

pgsql: Fix minmax-multi distance for extreme interval values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi distance for extreme interval values When calculating distance for interval values, the code mostly mimicked interval_mi, i.e. it built a new interval value for the difference. That however does not work for sufficiently distant interval values, when the difference overflows the i

pgsql: Fix calculation in brin_minmax_multi_distance_date

2023-10-27 Thread Tomas Vondra
Fix calculation in brin_minmax_multi_distance_date When calculating the distance between date values, make sure to subtract them in the right order, i.e. (larger - smaller). The distance is used to determine which values to merge, and is expected to be a positive value. The code unfortunately did

pgsql: Fix minmax-multi on infinite date/timestamp values

2023-10-27 Thread Tomas Vondra
Fix minmax-multi on infinite date/timestamp values Make sure that infinite values in date/timestamp columns are treated as if in infinite distance. Infinite values should not be merged with other values, leaving them as outliers. The code however returned distance 0 in this case, so that infinite

pgsql: Split event_trigger_login test from event_trigger test

2023-10-27 Thread Alexander Korotkov
Split event_trigger_login test from event_trigger test That allows to still run event_trigger test in parallel with oidjoins test, and save ~50ms of tests runtime. Discussion: https://postgr.es/m/202310271047.mnwkql6nhbwi%40alvherre.pgsql Author: Alvaro Herrera, Alexander Korotkov Branch --

Re: pgsql: Adjust parallel_schedule with event triggers on authenticated lo

2023-10-27 Thread Alexander Korotkov
On Fri, Oct 27, 2023 at 2:51 PM Alvaro Herrera wrote: > On 2023-Oct-27, Alexander Korotkov wrote: > > > OK, I'm good with this. > > Do you like me to push this? Or do you like to push it yourself? > > Please do. Done, thanks. -- Regards, Alexander Korotkov

pgsql: Teach contrib/amcheck to check the unique constraint violation

2023-10-27 Thread Alexander Korotkov
Teach contrib/amcheck to check the unique constraint violation Add the 'checkunique' argument to bt_index_check() and bt_index_parent_check(). When the flag is specified the procedures will check the unique constraint violation for unique indexes. Only one heap entry for all equal keys in the ind

pgsql: doc: wording improvements

2023-10-27 Thread Bruce Momjian
doc: wording improvements Discussion: https://postgr.es/m/[email protected] Author: Ekaterina Kiryanova Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a978565ffcec3ea31c0827fe1dcc524163bdbdfa Modified

pgsql: doc Improve C GUC-related comments

2023-10-27 Thread Bruce Momjian
doc Improve C GUC-related comments Discussion: https://postgr.es/m/CAEG8a3LZHTR5S+OPZCbZvECwsqdbx=pbrfzzydjkaatgoal...@mail.gmail.com Author: Junwang Zhao Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/12cf3ac7f328ac439a8eca2bfb7771fb6

pgsql: Clarify the result order of unnest(multirange).

2023-10-27 Thread Jeff Davis
Clarify the result order of unnest(multirange). It is best not to mention the storage order, because that is an implementation detail and has confused at least one user, who assumed that the storage order is the order in which the constituent ranges were written in SQL. Since the sorting order is

pgsql: doc: improve config syncfs wording

2023-10-27 Thread Bruce Momjian
doc: improve config syncfs wording Reported-by: Eric Mutta Discussion: https://postgr.es/m/[email protected] Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb544d7fd966ce8718573ffeb17dfe6d095

pgsql: doc: improve text around consistency of statistics values

2023-10-27 Thread Bruce Momjian
doc: improve text around consistency of statistics values Discussion: https://postgr.es/m/cakfquwz4cxttyr19vfbd9wwmw-4bvgaenmf2cfupx0lwwrp...@mail.gmail.com Author: David G. Johnston Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05ce7

pgsql: Allow relkind 'I' in type_sanity test.

2023-10-27 Thread Tom Lane
Allow relkind 'I' in type_sanity test. This is cosmetic at present, since no partitioned indexes have been created yet at the stage of the regression tests when type_sanity runs. But it's confusing that this list of allowed values doesn't match reality, so fix it. Noted by Jian He. Discussion: