pgsql: Update comment

2023-03-08 Thread Peter Eisentraut
Update comment There was apparently an attempt here to list all the object types that ACL_USAGE applies to, but it wasn't complete. So instead of trying to keep up, put in a more timeless comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/822e8e295166f000e337

pgsql: Break up long GETTEXT_FILES lists

2023-03-08 Thread Peter Eisentraut
Break up long GETTEXT_FILES lists One file per line seems best. We already did this in some cases. This adopts the same format everywhere (except in some cases where the list reasonably fits on one line). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2a71ad64cb27

pgsql: Clean up comments

2023-03-08 Thread Peter Eisentraut
Clean up comments Reformat some of the comments in MergeAttributes(). A lot of code has been added here over time, and the comments could use a bit of editing to make the code flow read better. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b1534ed99dc35878e1f9300

pgsql: Allow tailoring of ICU locales with custom rules

2023-03-08 Thread Peter Eisentraut
Allow tailoring of ICU locales with custom rules This exposes the ICU facility to add custom collation rules to a standard collation. New options are added to CREATE COLLATION, CREATE DATABASE, createdb, and initdb to set the rules. Reviewed-by: Laurenz Albe Reviewed-by: Daniel Verite Discussi

pgsql: 001_libpq_pipeline.pl: use Test::Differences if available

2023-03-08 Thread Alvaro Herrera
001_libpq_pipeline.pl: use Test::Differences if available When one of these tests fails to match the trace, this better shows what the problem is. Discussion: https://postgr.es/m/[email protected] Reviewed-by: Kyotaro Horiguchi Branch -- master Details ---

pgsql: meson: Add target for installing test files & improve install_te

2023-03-08 Thread Andres Freund
meson: Add target for installing test files & improve install_test_files The changes in b6a0d469cae prevented installation of the test files during a normal install. However, the buildfarm intentionally tries to trun the tests against a "real" installation. The new install-test-files target provid

Re: pgsql: Allow tailoring of ICU locales with custom rules

2023-03-08 Thread Jeff Davis
On Wed, 2023-03-08 at 16:03 +, Peter Eisentraut wrote: > Allow tailoring of ICU locales with custom rules Late review: * Should throw error when provider != icu and rules != NULL * Explain what the example means. By itself, users might get confused wondering why someone would want to do that

Re: pgsql: 001_libpq_pipeline.pl: use Test::Differences if available

2023-03-08 Thread Andrew Dunstan
On 2023-03-08 We 12:42, Alvaro Herrera wrote: 001_libpq_pipeline.pl: use Test::Differences if available When one of these tests fails to match the trace, this better shows what the problem is. Discussion: https://postgr.es/m/[email protected] Reviewed-by: Kyotaro

pgsql: doc: Add guidelines to generate coverage reports with meson

2023-03-08 Thread Michael Paquier
doc: Add guidelines to generate coverage reports with meson These instructions were already available for configure-based builds, but not the meson-based builds. This commit closes the gap. Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/d3751ca3-1ac9-cc5e-9315-cf9fb0eaa...@enterp

pgsql: meson: tests: Adjust with_icu/ZSTD env vars for pg_dump, pg_base

2023-03-08 Thread Andres Freund
meson: tests: Adjust with_icu/ZSTD env vars for pg_dump, pg_basebackup 396d348b0 omitted adding with_icu to the pg_dump tests under meson. Conversely, e6927270c exported ZSTD for pg_basebackup's tests, despite pg_basebackup's ZSTD support not having any tests. Reported-by: Justin Pryzby Discussi

pgsql: Fix race in SERIALIZABLE READ ONLY.

2023-03-08 Thread Thomas Munro
Fix race in SERIALIZABLE READ ONLY. Commit bdaabb9b started skipping doomed transactions when building the list of possible conflicts for SERIALIZABLE READ ONLY. That makes sense, because doomed transactions won't commit, but a couple of subtle things broke: 1. If all uncommitted r/w transactio

pgsql: Fix race in SERIALIZABLE READ ONLY.

2023-03-08 Thread Thomas Munro
Fix race in SERIALIZABLE READ ONLY. Commit bdaabb9b started skipping doomed transactions when building the list of possible conflicts for SERIALIZABLE READ ONLY. That makes sense, because doomed transactions won't commit, but a couple of subtle things broke: 1. If all uncommitted r/w transactio

pgsql: Fix race in SERIALIZABLE READ ONLY.

2023-03-08 Thread Thomas Munro
Fix race in SERIALIZABLE READ ONLY. Commit bdaabb9b started skipping doomed transactions when building the list of possible conflicts for SERIALIZABLE READ ONLY. That makes sense, because doomed transactions won't commit, but a couple of subtle things broke: 1. If all uncommitted r/w transactio

pgsql: Fix race in SERIALIZABLE READ ONLY.

2023-03-08 Thread Thomas Munro
Fix race in SERIALIZABLE READ ONLY. Commit bdaabb9b started skipping doomed transactions when building the list of possible conflicts for SERIALIZABLE READ ONLY. That makes sense, because doomed transactions won't commit, but a couple of subtle things broke: 1. If all uncommitted r/w transactio

pgsql: Fix race in SERIALIZABLE READ ONLY.

2023-03-08 Thread Thomas Munro
Fix race in SERIALIZABLE READ ONLY. Commit bdaabb9b started skipping doomed transactions when building the list of possible conflicts for SERIALIZABLE READ ONLY. That makes sense, because doomed transactions won't commit, but a couple of subtle things broke: 1. If all uncommitted r/w transactio

pgsql: Fix race in SERIALIZABLE READ ONLY.

2023-03-08 Thread Thomas Munro
Fix race in SERIALIZABLE READ ONLY. Commit bdaabb9b started skipping doomed transactions when building the list of possible conflicts for SERIALIZABLE READ ONLY. That makes sense, because doomed transactions won't commit, but a couple of subtle things broke: 1. If all uncommitted r/w transactio

pgsql: Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connec

2023-03-08 Thread Michael Paquier
Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connect.c A patch sent by Jacob Champion has been touching this area of the code, and the set of changes done in a9e9a9f has made a run of pgindent on these files a bit annoying to handle. So let's clean up a bit the area, first, to ease t

pgsql: Disallow specifying ICU rules unless locale provider is ICU

2023-03-08 Thread Peter Eisentraut
Disallow specifying ICU rules unless locale provider is ICU Follow-up for 30a53b7929; this was not checked in all cases. Reported-by: Jeff Davis Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/544b452a5a598dd14d7a38d15a778932e58d18b0 Modified Files --