pgsql: doc: Fix description of how the default user name is chosen

2022-11-24 Thread Peter Eisentraut
doc: Fix description of how the default user name is chosen This makes the distinction between operating-system user name and database user name a bit clearer. It also clarifies that the user name is determined first, and then the default database name. Author: David G. Johnston Discussion: ht

pgsql: Make multixact error message more explicit

2022-11-24 Thread Alvaro Herrera
Make multixact error message more explicit There are recent reports involving a very old error message that we have no history of hitting -- perhaps a recently introduced bug. Improve the error message in an attempt to improve our chances of investigating the bug. Per reports from Dimos Stamatak

pgsql: Make multixact error message more explicit

2022-11-24 Thread Alvaro Herrera
Make multixact error message more explicit There are recent reports involving a very old error message that we have no history of hitting -- perhaps a recently introduced bug. Improve the error message in an attempt to improve our chances of investigating the bug. Per reports from Dimos Stamatak

pgsql: Make multixact error message more explicit

2022-11-24 Thread Alvaro Herrera
Make multixact error message more explicit There are recent reports involving a very old error message that we have no history of hitting -- perhaps a recently introduced bug. Improve the error message in an attempt to improve our chances of investigating the bug. Per reports from Dimos Stamatak

pgsql: Make multixact error message more explicit

2022-11-24 Thread Alvaro Herrera
Make multixact error message more explicit There are recent reports involving a very old error message that we have no history of hitting -- perhaps a recently introduced bug. Improve the error message in an attempt to improve our chances of investigating the bug. Per reports from Dimos Stamatak

pgsql: Make multixact error message more explicit

2022-11-24 Thread Alvaro Herrera
Make multixact error message more explicit There are recent reports involving a very old error message that we have no history of hitting -- perhaps a recently introduced bug. Improve the error message in an attempt to improve our chances of investigating the bug. Per reports from Dimos Stamatak

pgsql: Make multixact error message more explicit

2022-11-24 Thread Alvaro Herrera
Make multixact error message more explicit There are recent reports involving a very old error message that we have no history of hitting -- perhaps a recently introduced bug. Improve the error message in an attempt to improve our chances of investigating the bug. Per reports from Dimos Stamatak

pgsql: Improve indenting in _hash_pgaddtup

2022-11-24 Thread David Rowley
Improve indenting in _hash_pgaddtup The Assert added in d09dbeb9b came out rather ugly after having run pgindent on that code. Here we adjust things to use some local variables so that the Assert remains within the 80-character margin. Author: Ted Yu Discussion: https://postgr.es/m/CALte62wLSir

Re: pgsql: Expand AclMode to 64 bits

2022-11-24 Thread David Rowley
On Thu, 24 Nov 2022 at 08:44, Andrew Dunstan wrote: > Expand AclMode to 64 bits I noticed this causes a few new warnings on MSVC: acl.c(629): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) acl.c(631): warning C4334: '<<': result of 32-bit

pgsql: Fix some 32-bit shift warnings in MSVC

2022-11-24 Thread David Rowley
Fix some 32-bit shift warnings in MSVC 7b378237a widened AclMode to 64 bits which resulted in 3 new additional warnings on MSVC. Here we make use of UINT64CONST to reassure the compiler that we do intend the bit shift expression to yield a 64-bit result. Discussion: https://postgr.es/m/CAApHDvo

pgsql: Introduce variables for initial and max nesting depth on configu

2022-11-24 Thread Michael Paquier
Introduce variables for initial and max nesting depth on configuration files The code has been assuming already in a few places that the initial recursion nesting depth is 0, and the recent changes in hba.c (mainly 783e8c6) have relies on this assumption in more places. The maximum recursion nest

pgsql: Fix uninitialized access to InitialRunningXacts during decoding.

2022-11-24 Thread Amit Kapila
Fix uninitialized access to InitialRunningXacts during decoding. In commit 272248a0c, we introduced an InitialRunningXacts array to remember transactions and subtransactions that were running when the xl_running_xacts record that we decoded was written. This array was allocated in the snapshot bui

pgsql: Fix uninitialized access to InitialRunningXacts during decoding.

2022-11-24 Thread Amit Kapila
Fix uninitialized access to InitialRunningXacts during decoding. In commit 272248a0c, we introduced an InitialRunningXacts array to remember transactions and subtransactions that were running when the xl_running_xacts record that we decoded was written. This array was allocated in the snapshot bui

pgsql: Fix uninitialized access to InitialRunningXacts during decoding.

2022-11-24 Thread Amit Kapila
Fix uninitialized access to InitialRunningXacts during decoding. In commit 272248a0c, we introduced an InitialRunningXacts array to remember transactions and subtransactions that were running when the xl_running_xacts record that we decoded was written. This array was allocated in the snapshot bui

pgsql: Fix uninitialized access to InitialRunningXacts during decoding.

2022-11-24 Thread Amit Kapila
Fix uninitialized access to InitialRunningXacts during decoding. In commit 272248a0c, we introduced an InitialRunningXacts array to remember transactions and subtransactions that were running when the xl_running_xacts record that we decoded was written. This array was allocated in the snapshot bui

pgsql: Fix uninitialized access to InitialRunningXacts during decoding.

2022-11-24 Thread Amit Kapila
Fix uninitialized access to InitialRunningXacts during decoding. In commit 272248a0c, we introduced an InitialRunningXacts array to remember transactions and subtransactions that were running when the xl_running_xacts record that we decoded was written. This array was allocated in the snapshot bui

Re: pgsql: Expand AclMode to 64 bits

2022-11-24 Thread Amit Langote
Hi Andrew, On Thu, Nov 24, 2022 at 10:18 AM Andrew Dunstan wrote: > On 2022-11-23 We 19:40, Michael Paquier wrote: > > Hi Andrew, > > > > On Wed, Nov 23, 2022 at 07:44:04PM +, Andrew Dunstan wrote: > >> Expand AclMode to 64 bits > >> > >> We're running out of bits for new permissions. This ch

pgsql: Skip TAP test for peer authentication if there are no unix-domai

2022-11-24 Thread Michael Paquier
Skip TAP test for peer authentication if there are no unix-domain sockets Peer connections require support for local connections to work, but the test missed the same check as the other ones in this suite. The buildfarm does not run the authentication tests on Windows, and, more surprisingly, the