Re: pgsql: Avoid improbable PANIC during heap_update.

2022-09-29 Thread Jaime Casanova
On Tue, Apr 13, 2021 at 04:17:39PM +, Tom Lane wrote: > Avoid improbable PANIC during heap_update. > > heap_update needs to clear any existing "all visible" flag on > the old tuple's page (and on the new page too, if different). > Per coding rules, to do this it must acquire pin on the appropr

pgsql: Update comment in ExecInsert() regarding batch insertion.

2022-09-29 Thread Etsuro Fujita
Update comment in ExecInsert() regarding batch insertion. Remove the stale text that is a leftover from an earlier version of the patch to add support for batch insertion, and adjust the wording in the remaining text. Back-patch to v14 where batch insertion came in. Review and wording adjustment

pgsql: Update comment in ExecInsert() regarding batch insertion.

2022-09-29 Thread Etsuro Fujita
Update comment in ExecInsert() regarding batch insertion. Remove the stale text that is a leftover from an earlier version of the patch to add support for batch insertion, and adjust the wording in the remaining text. Back-patch to v14 where batch insertion came in. Review and wording adjustment

pgsql: Update comment in ExecInsert() regarding batch insertion.

2022-09-29 Thread Etsuro Fujita
Update comment in ExecInsert() regarding batch insertion. Remove the stale text that is a leftover from an earlier version of the patch to add support for batch insertion, and adjust the wording in the remaining text. Back-patch to v14 where batch insertion came in. Review and wording adjustment

pgsql: Use actual backend IDs in pg_stat_get_backend_idset() and friend

2022-09-29 Thread Tom Lane
Use actual backend IDs in pg_stat_get_backend_idset() and friends. Up to now, the ID values returned by pg_stat_get_backend_idset() and used by pg_stat_get_backend_activity() and allied functions were just indexes into a local array of sessions seen by the last stats refresh. This is problematic f

pgsql: Improve wording of log messages triggered by max_slot_wal_keep_s

2022-09-29 Thread Tom Lane
Improve wording of log messages triggered by max_slot_wal_keep_size. The one about "terminating process to release replication slot" told you nothing about why that was happening. The one about "invalidating slot because its restart_lsn exceeds max_slot_wal_keep_size" told you what was happening,

pgsql: Fix bogus behavior of PQsslAttribute(conn, "library").

2022-09-29 Thread Tom Lane
Fix bogus behavior of PQsslAttribute(conn, "library"). Commit ebc8b7d44 intended to change the behavior of PQsslAttribute(NULL, "library"), but accidentally also changed what happens with a non-NULL conn pointer. Undo that so that only the intended behavior change happens. Clarify some associate

pgsql: Fix bogus behavior of PQsslAttribute(conn, "library").

2022-09-29 Thread Tom Lane
Fix bogus behavior of PQsslAttribute(conn, "library"). Commit ebc8b7d44 intended to change the behavior of PQsslAttribute(NULL, "library"), but accidentally also changed what happens with a non-NULL conn pointer. Undo that so that only the intended behavior change happens. Clarify some associate

pgsql: ci: Add 32bit build and test

2022-09-29 Thread Andres Freund
ci: Add 32bit build and test It's easy enough to make changes that break on 32bit platforms and few people test that locally. Add a test for that to CI. LLVM is disabled on 32bit because installing it would bloat the image size further. The debian w/ meson task is fast enough that we can afford t

pgsql: Remove useless argument from UnpinBuffer()

2022-09-29 Thread Michael Paquier
Remove useless argument from UnpinBuffer() The last caller of UnpinBuffer() that did not want to adjust CurrentResourceOwner was removed in 2d115e4, and nothing has been introduced in bufmgr.c to do the same thing since. This simplifies 10 code paths. Author: Aleksander Alekseev Reviewed-by: Nat