pgsql: Further -Wshadow=compatible-local warning fixes

2022-08-24 Thread David Rowley
Further -Wshadow=compatible-local warning fixes These should have been included in 421892a19 as these shadowed variable warnings can also be fixed by adjusting the scope of the shadowed variable to put the declaration for it in an inner scope. This is part of the same effort as f01592f91. By my

pgsql: Remove initialization of MyClientConnectionInfo at backend start

2022-08-24 Thread Michael Paquier
Remove initialization of MyClientConnectionInfo at backend startup This stuff should be already initialized at process startup, so adding this extra step is confusing for no gain. Per gripe from Tom Lane and Jacob Champion. Discussion: https://postgr.es/m/bbf2b922-4ff7-5c30-e3ef-2a8bdcdd1...@ti

pgsql: Fix ICU locale option handling in CREATE DATABASE

2022-08-24 Thread Peter Eisentraut
Fix ICU locale option handling in CREATE DATABASE The code took the LOCALE option as the default/fallback for ICU_LOCALE, but this was neither documented nor intended, so remove it. (It was probably left in from an earlier patch version.) Reported-by: Marina Polyakova Discussion: https://www.p

pgsql: Fix ICU locale option handling in CREATE DATABASE

2022-08-24 Thread Peter Eisentraut
Fix ICU locale option handling in CREATE DATABASE The code took the LOCALE option as the default/fallback for ICU_LOCALE, but this was neither documented nor intended, so remove it. (It was probably left in from an earlier patch version.) Reported-by: Marina Polyakova Discussion: https://www.p

pgsql: Doc: remove duplicate "a" from func.sgml

2022-08-24 Thread David Rowley
Doc: remove duplicate "a" from func.sgml Author: Shinya Kato Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15, where that change was introduced Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a73d6c87f2eb19681fe5

pgsql: Doc: remove duplicate "a" from func.sgml

2022-08-24 Thread David Rowley
Doc: remove duplicate "a" from func.sgml Author: Shinya Kato Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15, where that change was introduced Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e6828053d9d62

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: Defend against stack overrun in a few more places.

2022-08-24 Thread Tom Lane
Defend against stack overrun in a few more places. SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c, and regex_selectivity_sub() in selectivity estimation could recurse until stack overflow; fix by adding check_stack_depth() calls. So could next() in the regex compiler, but th

pgsql: pg_dump: Dump colliculocale

2022-08-24 Thread Peter Eisentraut
pg_dump: Dump colliculocale This was forgotten when the new column was introduced. Author: Marina Polyakova Reviewed-by: Julien Rouhaud Discussion: https://www.postgresql.org/message-id/7ad26354e75259f59c4a6c6997b8ee32%40postgrespro.ru Branch -- REL_15_STABLE Details --- https://git.

pgsql: pg_dump: Dump colliculocale

2022-08-24 Thread Peter Eisentraut
pg_dump: Dump colliculocale This was forgotten when the new column was introduced. Author: Marina Polyakova Reviewed-by: Julien Rouhaud Discussion: https://www.postgresql.org/message-id/7ad26354e75259f59c4a6c6997b8ee32%40postgrespro.ru Branch -- master Details --- https://git.postgre

Re: pgsql: pg_dump: Dump colliculocale

2022-08-24 Thread Tom Lane
Peter Eisentraut writes: > pg_dump: Dump colliculocale The *BSD buildfarm members don't seem too happy with the new test case. regards, tom lane

pgsql: Fix code comments still referring to pg_start/stop_backup()

2022-08-24 Thread Peter Eisentraut
Fix code comments still referring to pg_start/stop_backup() pg_start_backup() and pg_stop_backup() have been respectively renamed to pg_backup_start() and pg_backup_stop() as of 39969e2, but a few comments did not get the call. Reviewed-by: Kyotaro Horiguchi, David Steele Discussion: https://post

pgsql: Include RelFileLocator fields individually in BufferTag.

2022-08-24 Thread Robert Haas
Include RelFileLocator fields individually in BufferTag. This is preparatory work for a project to increase the number of bits in a RelFileNumber from 32 to 56. Along the way, introduce static inline accessor functions for a couple of BufferTag fields. Dilip Kumar, reviewed by me. The overall pa

Re: pgsql: pg_dump: Dump colliculocale

2022-08-24 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> pg_dump: Dump colliculocale > The *BSD buildfarm members don't seem too happy with the new test case. Not just those. I found that on my RHEL8 box, the new pg_dump test passes if the environment has LANG=en_US.utf8, and fails if LANG=C.

pgsql: Remove rule to generate postgres.o, not needed for 20+ years

2022-08-24 Thread Andres Freund
Remove rule to generate postgres.o, not needed for 20+ years Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/68fc18d14c7e1150823cf4a5728089459723c9da Modified Files -- s

pgsql: aix: Fix SHLIB_EXPORTS reference in VPATH builds

2022-08-24 Thread Andres Freund
aix: Fix SHLIB_EXPORTS reference in VPATH builds The dependencies here aren't quite right independent of vpath builds or not, but this at least makes vpath builds succeed. And it's pretty rare to change the exports.txt file anyway... The referenced thread has a patch that will clean that up furthe

pgsql: solaris: Use versioning scripts instead of -Bsymbolic

2022-08-24 Thread Andres Freund
solaris: Use versioning scripts instead of -Bsymbolic -Bsymbolic causes a lot of "ld: warning: symbol referencing errors" warnings. It's quite easy to add the symbol versioning script, we just need a slightly different parameter name. Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/

pgsql: Remove SUBSYS.o rule in common.mk, hasn't been used in a long ti

2022-08-24 Thread Andres Freund
Remove SUBSYS.o rule in common.mk, hasn't been used in a long time Apparently I missed that this SUBSYS.o rule isn't needed anymore in a4ebbd27527, likely because there still is a reference to it due to AIX - but that's self contained in src/backend/Makefile Discussion: https://postgr.es/m/20220

Re: pgsql: pg_dump: Dump colliculocale

2022-08-24 Thread Marina Polyakova
Hello! Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me... On 2022-08-25 04:46, Tom Lane wrote: I wrote: The *BSD buildfarm members don't seem too happy with the new test case. Not just those. I found that on my RHEL8 box, the new pg_dump test passes if the environment has

pgsql: pg_dump: Fix new ICU tests

2022-08-24 Thread Peter Eisentraut
pg_dump: Fix new ICU tests ICU doesn't support some server encodings, so we need to exclude them if a non-supported encoding was set up. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b4ddf3ee30bfb5b7da60411cabcf0589bdbd3f42 Modified Files -- src/bin/p

pgsql: pg_dump: Fix new ICU tests

2022-08-24 Thread Peter Eisentraut
pg_dump: Fix new ICU tests ICU doesn't support some server encodings, so we need to exclude them if a non-supported encoding was set up. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f2dcf1acfbd8d23e1651293cd3c83c0443b45143 Modified Files -- sr

Re: pgsql: pg_dump: Dump colliculocale

2022-08-24 Thread Marina Polyakova
More precisely, diff_fix_002_pg_dump_v2.patch... On 2022-08-25 07:50, Marina Polyakova wrote: Hello! Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me... On 2022-08-25 04:46, Tom Lane wrote: I wrote: The *BSD buildfarm members don't seem too happy with the new test case. N

pgsql: Remove unused symbol __aarch64

2022-08-24 Thread John Naylor
Remove unused symbol __aarch64 This was added as a possible variant of __aarch64__ back when 64-bit ARM was vaporware. It hasn't shown up in the wild since then, so remove. Nathan Bossart Discussion: https://www.postgresql.org/message-id/CAFBsxsEN5nW3uRh%3Djrs-QexDrC1btu0ZfriD3FFfb%3D3J6tAngg%4