Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-11 Thread John Naylor
On Wed, May 11, 2022 at 6:43 AM David Rowley wrote: > > I pushed this after I made a small adjustment to #ifdef out the > qsort_tuple_signed sort specialization in 32-bit builds. On testing a > 32-bit build with the patch I proposed, I was getting a warning about > that function being unused. Ea

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-11 Thread David Rowley
On Wed, 11 May 2022 at 20:42, John Naylor wrote: > Earlier I looked at your patch, but didn't think to check the rest of > the code affected by this commit. Do we also need something like the > attached, for the ApplyXYZSortComparator functions? (I don't have a > 32-bit platform to test on) I did

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-11 Thread Michael Paquier
On Wed, May 11, 2022 at 03:42:05PM +0700, John Naylor wrote: > Earlier I looked at your patch, but didn't think to check the rest of > the code affected by this commit. Do we also need something like the > attached, for the ApplyXYZSortComparator functions? (I don't have a > 32-bit platform to test

pgsql: relnotes: update foreign key partition and add sort items

2022-05-11 Thread Bruce Momjian
relnotes: update foreign key partition and add sort items Reported-by: David Rowley, Amit Langote Discussion: https://postgr.es/m/ca+hiwqfcedbninfk94atgbjkmtkygdtkpnjt3b0fvzki+wz...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/279d957efebb4fe063

pgsql: relnotes: adjustments from Álvaro Herrera

2022-05-11 Thread Bruce Momjian
relnotes: adjustments from Álvaro Herrera Reported-by: Álvaro Herrera Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/78ccd6cca48dab098fcce62528c2b471f7a0010a Modified Files -- d

pgsql: Remove non-functional code for unloading loadable modules.

2022-05-11 Thread Robert Haas
Remove non-functional code for unloading loadable modules. The code for unloading a library has been commented-out for over 12 years, ever since commit 602a9ef5a7c60151e10293ae3c4bb3fbb0132d03, and we're no closer to supporting it now than we were back then. Nathan Bossart, reviewed by Michael Pa

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-11 Thread David Rowley
On Wed, 11 May 2022 at 20:42, John Naylor wrote: > (I don't have a > 32-bit platform to test on) I had to do as Michael mentioned yesterday to test this. FWIW, I compiled and ran the tests on my machine with -m32 and no compile or test failures. Also, looking at the patch, it seems fine to me.

pgsql: relnote: improve sorting entries

2022-05-11 Thread Bruce Momjian
relnote: improve sorting entries Reported-by: David Rowley Discussion: https://postgr.es/m/caaphdvrtohfvl-w03vsi6t50uscyhrdugzttculajdjtrf8...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/922d1a27e9bd3415522a5ec5578c7c1324b16b93 Modified Files

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-11 Thread John Naylor
On Thu, May 12, 2022 at 4:50 AM David Rowley wrote: > > On Wed, 11 May 2022 at 20:42, John Naylor > wrote: > > (I don't have a > > 32-bit platform to test on) > > I had to do as Michael mentioned yesterday to test this. > > FWIW, I compiled and ran the tests on my machine with -m32 and no > comp

pgsql: relnotes: update for non-exclusive backup mode removal

2022-05-11 Thread Bruce Momjian
relnotes: update for non-exclusive backup mode removal Reported-by: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jmlbmamxjcew12-yntb7m3fh-8a2+qb7+rybzp1w9...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/da82c62469865e11c29881b42e9

pgsql: relnotes: add author to in-memory sorts item

2022-05-11 Thread Bruce Momjian
relnotes: add author to in-memory sorts item Reported-by: Thomas Munro Discussion: https://postgr.es/m/ca+hukgkha50-h2ye-9x3pjwu5wbq_mpc2rmvkm1xj0tl+nt...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d70b95a7178af84212487438b5509871090f5b05 Mod

pgsql: Use correct datum macros in more tuplesort specialization functi

2022-05-11 Thread John Naylor
Use correct datum macros in more tuplesort specialization functions. Also clarify that ApplySignedSortComparator() is not built on 32-bit machines. Folow-up to c90c16591 Reviewed-by: David Rowley Discussion: https://www.postgresql.org/message-id/CAFBsxsFmt4_JUP8XgSJqwaAS9a9s8K8_PvMu%3Dj%3DDfwU%

pgsql: relnotes: mention non-exclusive backup mode was deprecated

2022-05-11 Thread Bruce Momjian
relnotes: mention non-exclusive backup mode was deprecated Reported-by: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=j9vhsfxun+xv5qzxqv7gj-6tkqqwvlsgz5zu7f8nh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6bfecf33f6ed558deee4f80

pgsql: Add some missing PGDLLIMPORT markings

2022-05-11 Thread Michael Paquier
Add some missing PGDLLIMPORT markings Three variables in pqsignal.h (UnBlockSig, BlockSig and StartupBlockSig) were not marked with PGDLLIMPORT, as they are declared in a way that prevents mark_pgdllimport.pl to detect them. These variables are redefined in a style more consistent with the other