Re: pgsql: Make node output prefix match node structure name

2021-10-05 Thread Vik Fearing
On 9/15/21 5:30 PM, Tom Lane wrote: > Peter Eisentraut writes: >> Make node output prefix match node structure name > > Just for the record, this should have included a catversion bump, > since it surely broke stored rules. It did. I just ran into a problem cause by the lack of catversion bump.

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Doc: improve description of UNION/INTERSECT/EXCEPT syntax.

2021-10-05 Thread Tom Lane
Doc: improve description of UNION/INTERSECT/EXCEPT syntax. queries.sgml failed to mention the rather important point that INTERSECT binds more tightly than UNION or EXCEPT. I thought it could also use more discussion of the role of parentheses in these constructs. Per gripe from Christopher Pain

pgsql: Make recovery report error message when invalid page header is f

2021-10-05 Thread Fujii Masao
Make recovery report error message when invalid page header is found. Commit 0668719801 changed XLogPageRead() so that it validated the page header, if invalid page header was found reset the error message and retried reading the page, to fix the scenario where streaming standby got stuck at a con

pgsql: Flexible options for BASE_BACKUP.

2021-10-05 Thread Robert Haas
Flexible options for BASE_BACKUP. Previously, BASE_BACKUP used an entirely hard-coded syntax, but that's hard to extend. Instead, adopt the same kind of syntax we've used for SQL commands such as VACUUM, ANALYZE, COPY, and EXPLAIN, where it's not necessary for all of the option names to be parser

pgsql: Flexible options for CREATE_REPLICATION_SLOT.

2021-10-05 Thread Robert Haas
Flexible options for CREATE_REPLICATION_SLOT. Like BASE_BACKUP, CREATE_REPLICATION_SLOT has historically used a hard-coded syntax. To improve future extensibility, adopt a flexible options syntax here, too. In the new syntax, instead of three mutually exclusive options EXPORT_SNAPSHOT, USE_SNAPS

Re: pgsql: Flexible options for BASE_BACKUP.

2021-10-05 Thread Alvaro Herrera
On 2021-Oct-05, Robert Haas wrote: > In the new syntax, the FAST option has been replaced by a > CHECKSUM option whose value may be 'fast' or 'spread'. This was supposed to be CHECKPOINT -- | K_FAST { $$ = makeDefElem("checkpoint",

Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c

2021-10-05 Thread Andrey Borodin
Hi! > 6 июля 2021 г., в 19:36, Tom Lane написал(а): > > Avoid doing catalog lookups in postgres_fdw's conversion_error_callback. I'm observing a related coredump in + ForeignScan *fsplan = castNode(ForeignScan, fsstate->ss.ps.plan); #0 conversion_error_callback (arg=0x7ffe445cdf40) at ./b

Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c

2021-10-05 Thread Tom Lane
Andrey Borodin writes: > I'm observing a related coredump in > + ForeignScan *fsplan = castNode(ForeignScan, fsstate->ss.ps.plan); Could we have a test case for that please? It seems to be related to ANALYZE, but I'm unexcited about reverse-engineering the details. reg

Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c

2021-10-05 Thread Andrey Borodin
> 5 окт. 2021 г., в 22:08, Tom Lane написал(а): > > Andrey Borodin writes: >> I'm observing a related coredump in >> + ForeignScan *fsplan = castNode(ForeignScan, fsstate->ss.ps.plan); > > Could we have a test case for that please? It seems to be related > to ANALYZE, but I'm unexcited ab

Re: pgsql: Flexible options for BASE_BACKUP.

2021-10-05 Thread Robert Haas
On Tue, Oct 5, 2021 at 2:33 PM Alvaro Herrera wrote: > On 2021-Oct-05, Robert Haas wrote: > > In the new syntax, the FAST option has been replaced by a > > CHECKSUM option whose value may be 'fast' or 'spread'. > > This was supposed to be CHECKPOINT -- > > | K_FAST > {

Re: pgsql: Fix backup manifests to generate correct WAL-Ranges across timel

2021-10-05 Thread Thomas Munro
On Mon, Aug 23, 2021 at 2:10 PM Michael Paquier wrote: > Fix backup manifests to generate correct WAL-Ranges across timelines +$primary->append_conf('standby.signal'); I think this needs a second argument, to silence a warning visible in regress_log_007_wal.

Re: pgsql: Fix backup manifests to generate correct WAL-Ranges across timel

2021-10-05 Thread Michael Paquier
On Wed, Oct 06, 2021 at 03:47:26PM +1300, Thomas Munro wrote: > +$primary->append_conf('standby.signal'); > > I think this needs a second argument, to silence a warning visible in > regress_log_007_wal. Oops, will fix. Thanks! -- Michael signature.asc Description: PGP signature

pgsql: Fix warning in TAP test of pg_verifybackup

2021-10-05 Thread Michael Paquier
Fix warning in TAP test of pg_verifybackup Oversight in a3fcbcd. Reported-by: Thomas Munro Discussion: https://postgr.es/m/ca+hukgknajzewe91otjro9kqlcmggfhh2vvfn8tghgbyn4b...@mail.gmail.com Backpatch-through: 13 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdi

pgsql: Fix warning in TAP test of pg_verifybackup

2021-10-05 Thread Michael Paquier
Fix warning in TAP test of pg_verifybackup Oversight in a3fcbcd. Reported-by: Thomas Munro Discussion: https://postgr.es/m/ca+hukgknajzewe91otjro9kqlcmggfhh2vvfn8tghgbyn4b...@mail.gmail.com Backpatch-through: 13 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdi

pgsql: Fix warning in TAP test of pg_verifybackup

2021-10-05 Thread Michael Paquier
Fix warning in TAP test of pg_verifybackup Oversight in a3fcbcd. Reported-by: Thomas Munro Discussion: https://postgr.es/m/ca+hukgknajzewe91otjro9kqlcmggfhh2vvfn8tghgbyn4b...@mail.gmail.com Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ec21

pgsql: Fix loop variable signedness

2021-10-05 Thread Peter Eisentraut
Fix loop variable signedness Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ba216d3b54ac334729c505ec8a725db3826290a2 Modified Files -- src/test/modules/worker_spi/worker_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)