Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.

2021-07-13 Thread Thomas Munro
Here's a better patch. I check if there is any declaration at all, which ancient HPUX should fail based on: command.c:5062:4: warning: implicit declaration of function 'sigwait' Then I also check that there isn't an incompatible declaration with the technique from thread_test.c, which Solaris sh

Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.

2021-07-13 Thread Tom Lane
Thomas Munro writes: > Here's a better patch. I didn't like the way you'd done this as two independent tests; the second one falsely reports success if there isn't actually any declaration of sigwait. I see you hacked around that by checking both results in c.h, but the printed result is still v

Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.

2021-07-13 Thread Tom Lane
I wrote: > Here's a revised patch that I've tested (albeit lightly) on > both HPUX and Solaris. Hm, I'd verified the configure results, but I didn't wait around for the builds to finish, which was a mistake. On Solaris 11: command.c: In function 'do_watch': command.c:5062:8: error: too many argu

pgsql: Rename debug_invalidate_system_caches_always to debug_discard_ca

2021-07-13 Thread Tom Lane
Rename debug_invalidate_system_caches_always to debug_discard_caches. The name introduced by commit 4656e3d66 was agreed to be unreasonably long. To match this change, rename initdb's recently-added --clobber-cache option to --discard-caches. Discussion: https://postgr.es/m/1374320.1625430...@ss

pgsql: Rename debug_invalidate_system_caches_always to debug_discard_ca

2021-07-13 Thread Tom Lane
Rename debug_invalidate_system_caches_always to debug_discard_caches. The name introduced by commit 4656e3d66 was agreed to be unreasonably long. To match this change, rename initdb's recently-added --clobber-cache option to --discard-caches. Discussion: https://postgr.es/m/1374320.1625430...@ss

pgsql: Change the name of the Result Cache node to Memoize

2021-07-13 Thread David Rowley
Change the name of the Result Cache node to Memoize "Result Cache" was never a great name for this node, but nobody managed to come up with another name that anyone liked enough. That was until David Johnston mentioned "Node Memoization", which Tom Lane revised to just "Memoize". People seem to

pgsql: Change the name of the Result Cache node to Memoize

2021-07-13 Thread David Rowley
Change the name of the Result Cache node to Memoize "Result Cache" was never a great name for this node, but nobody managed to come up with another name that anyone liked enough. That was until David Johnston mentioned "Node Memoization", which Tom Lane revised to just "Memoize". People seem to

pgsql: Install properly fe-auth-sasl.h

2021-07-13 Thread Michael Paquier
Install properly fe-auth-sasl.h The internals of the frontend-side callbacks for SASL are visible in libpq-int.h, but the header was not getting installed. This would cause compilation failures for applications playing with the internals of libpq. Issue introduced in 9fd8557. Author: Mikhail Ku

Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.

2021-07-13 Thread Thomas Munro
On Wed, Jul 14, 2021 at 6:17 AM Tom Lane wrote: > Just how badly did you want to use sigwait here? I'm having > considerable second thoughts about the value of that change > versus the hoops we're going to have to jump through to use it. I'm sure I could find another way if it comes to it. The