pgsql: Put some psql documentation pieces back into alphabetical order

2021-05-21 Thread Peter Eisentraut
Put some psql documentation pieces back into alphabetical order Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/124966c1a35b950210e12048e64533963960febd Modified Files -- doc/src/sgml/ref/psql-ref.sgml | 16 src/bin/psql/help.c

pgsql: Restore the portal-level snapshot after procedure COMMIT/ROLLBAC

2021-05-21 Thread Tom Lane
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK. COMMIT/ROLLBACK necessarily destroys all snapshots within the session. The original implementation of intra-procedure transactions just cavalierly did that, ignoring the fact that this left us executing in a rather different enviro

pgsql: Restore the portal-level snapshot after procedure COMMIT/ROLLBAC

2021-05-21 Thread Tom Lane
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK. COMMIT/ROLLBACK necessarily destroys all snapshots within the session. The original implementation of intra-procedure transactions just cavalierly did that, ignoring the fact that this left us executing in a rather different enviro

pgsql: Restore the portal-level snapshot after procedure COMMIT/ROLLBAC

2021-05-21 Thread Tom Lane
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK. COMMIT/ROLLBACK necessarily destroys all snapshots within the session. The original implementation of intra-procedure transactions just cavalierly did that, ignoring the fact that this left us executing in a rather different enviro

pgsql: Restore the portal-level snapshot after procedure COMMIT/ROLLBAC

2021-05-21 Thread Tom Lane
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK. COMMIT/ROLLBACK necessarily destroys all snapshots within the session. The original implementation of intra-procedure transactions just cavalierly did that, ignoring the fact that this left us executing in a rather different enviro

pgsql: Fix usage of "tableoid" in GENERATED expressions.

2021-05-21 Thread Tom Lane
Fix usage of "tableoid" in GENERATED expressions. We consider this supported (though I've got my doubts that it's a good idea, because tableoid is not immutable). However, several code paths failed to fill the field in soon enough, causing such a GENERATED expression to see zero or the wrong valu

pgsql: Fix usage of "tableoid" in GENERATED expressions.

2021-05-21 Thread Tom Lane
Fix usage of "tableoid" in GENERATED expressions. We consider this supported (though I've got my doubts that it's a good idea, because tableoid is not immutable). However, several code paths failed to fill the field in soon enough, causing such a GENERATED expression to see zero or the wrong valu

pgsql: Fix usage of "tableoid" in GENERATED expressions.

2021-05-21 Thread Tom Lane
Fix usage of "tableoid" in GENERATED expressions. We consider this supported (though I've got my doubts that it's a good idea, because tableoid is not immutable). However, several code paths failed to fill the field in soon enough, causing such a GENERATED expression to see zero or the wrong valu

pgsql: Disallow whole-row variables in GENERATED expressions.

2021-05-21 Thread Tom Lane
Disallow whole-row variables in GENERATED expressions. This was previously allowed, but I think that was just an oversight. It's a clear violation of the rule that a generated column cannot depend on itself or other generated columns. Moreover, because the code was relying on the assumption that

pgsql: Disallow whole-row variables in GENERATED expressions.

2021-05-21 Thread Tom Lane
Disallow whole-row variables in GENERATED expressions. This was previously allowed, but I think that was just an oversight. It's a clear violation of the rule that a generated column cannot depend on itself or other generated columns. Moreover, because the code was relying on the assumption that

pgsql: Disallow whole-row variables in GENERATED expressions.

2021-05-21 Thread Tom Lane
Disallow whole-row variables in GENERATED expressions. This was previously allowed, but I think that was just an oversight. It's a clear violation of the rule that a generated column cannot depend on itself or other generated columns. Moreover, because the code was relying on the assumption that

pgsql: doc: more XML markup for PG 14 release notes

2021-05-21 Thread Bruce Momjian
doc: more XML markup for PG 14 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/55370f8db96c8416940ad0b05be7a00a9f059a9f Modified Files -- doc/src/sgml/release-14.sgml | 265 ++- 1 file changed, 134 in

pgsql: doc: complete adding XML markup to PG 14 relnotes

2021-05-21 Thread Bruce Momjian
doc: complete adding XML markup to PG 14 relnotes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0cdaa05b40e9f28e5d6d58ccd06fe19f3cd920c9 Modified Files -- doc/src/sgml/release-14.sgml | 245 +++ 1 file changed, 1

pgsql: Fix planner's use of Result Cache with unique joins

2021-05-21 Thread David Rowley
Fix planner's use of Result Cache with unique joins When the planner considered using a Result Cache node to cache results from the inner side of a Nested Loop Join, it failed to consider that the inner path's parameterization may not be the entire join condition. If the join was marked as inner_