pgsql: Fix typo in test

2020-07-06 Thread Peter Eisentraut
Fix typo in test The test was supposed to error but didn't. Apparently, a copy and paste and string replace mistake from a nearby similar test. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bae9e8a58bf642aa383f5dc01b2c5947bae533dd Modified Files -- s

pgsql: Create composite array types for initdb-created relations.

2020-07-06 Thread Tom Lane
Create composite array types for initdb-created relations. When we invented arrays of composite types (commit bc8036fc6), we excluded system catalogs, basically just on the grounds of not wanting to bloat pg_type. However, it's definitely inconsistent that catalogs' composite types can't be put i

pgsql: Remove unnecessary PageIsEmpty() nbtree build check.

2020-07-06 Thread Peter Geoghegan
Remove unnecessary PageIsEmpty() nbtree build check. nbtree index builds cannot write out an empty page. That would mean that there was no way to create a pivot tuple pointing to the page one level up, since _bt_truncate() generates one based on page's firstright tuple. Replace the unnecessary P