pgsql: Read until EOF vice stat-reported size in read_binary_file

2020-07-04 Thread Joe Conway
Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Read until EOF vice stat-reported size in read_binary_file

2020-07-04 Thread Joe Conway
Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Read until EOF vice stat-reported size in read_binary_file

2020-07-04 Thread Joe Conway
Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Read until EOF vice stat-reported size in read_binary_file

2020-07-04 Thread Joe Conway
Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

2020-07-04 Thread Joe Conway
Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

2020-07-04 Thread Joe Conway
Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

2020-07-04 Thread Joe Conway
Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

2020-07-04 Thread Joe Conway
Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by