pgsql: Use CP_SMALL_TLIST for hash aggregate

2020-05-31 Thread Tomas Vondra
Use CP_SMALL_TLIST for hash aggregate Commit 1f39bce021 added disk-based hash aggregation, which may spill incoming tuples to disk. It however did not request projection to make the tuples as narrow as possible, which may mean having to spill much more data than necessary (increasing I/O, pushing

pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Andrew Dunstan
Make install-tests target work with vpath builds Also add a top-level install-tests target. Backpatch to all live branches. Craig Ringer, tweaked by me. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/af4ea507c3d9217579a8d75fc17f4796a9bab0bb Modified Files --

pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Andrew Dunstan
Make install-tests target work with vpath builds Also add a top-level install-tests target. Backpatch to all live branches. Craig Ringer, tweaked by me. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7f92218b8a0c3b9232dbb37f6026bfeaf2346e7c Modified Files

pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Andrew Dunstan
Make install-tests target work with vpath builds Also add a top-level install-tests target. Backpatch to all live branches. Craig Ringer, tweaked by me. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f4f4d64eafcd07880fee570e367422af757d3f02 Modified Files

pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Andrew Dunstan
Make install-tests target work with vpath builds Also add a top-level install-tests target. Backpatch to all live branches. Craig Ringer, tweaked by me. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cb9795eb2e17a49825146bafb7c409a1c1573298 Modified Files

pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Andrew Dunstan
Make install-tests target work with vpath builds Also add a top-level install-tests target. Backpatch to all live branches. Craig Ringer, tweaked by me. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b9f152d25a11e535975df971e536a2e27386179a Modified Files

pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Andrew Dunstan
Make install-tests target work with vpath builds Also add a top-level install-tests target. Backpatch to all live branches. Craig Ringer, tweaked by me. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bb45c5de2750f8aa5ab501aa327ababafed890d2 Modified Files

pgsql: Fix crashes with currtid() and currtid2()

2020-05-31 Thread Michael Paquier
Fix crashes with currtid() and currtid2() A relation that has no storage initializes rd_tableam to NULL, which caused those two functions to crash because of a pointer dereference. Note that in 11 and older versions, this has always failed with a confusing error "could not open file". These two f

pgsql: Fix crashes with currtid() and currtid2()

2020-05-31 Thread Michael Paquier
Fix crashes with currtid() and currtid2() A relation that has no storage initializes rd_tableam to NULL, which caused those two functions to crash because of a pointer dereference. Note that in 11 and older versions, this has always failed with a confusing error "could not open file". These two f

pgsql: Fix use-after-release mistake in currtid() and currtid2() for vi

2020-05-31 Thread Michael Paquier
Fix use-after-release mistake in currtid() and currtid2() for views This issue has been present since the introduction of this code as of a3519a2 from 2002, and has been found by buildfarm member prion that uses RELCACHE_FORCE_RELEASE via the tests introduced recently in e786be5. Discussion: http

pgsql: Fix use-after-release mistake in currtid() and currtid2() for vi

2020-05-31 Thread Michael Paquier
Fix use-after-release mistake in currtid() and currtid2() for views This issue has been present since the introduction of this code as of a3519a2 from 2002, and has been found by buildfarm member prion that uses RELCACHE_FORCE_RELEASE via the tests introduced recently in e786be5. Discussion: http

pgsql: Fix use-after-release mistake in currtid() and currtid2() for vi

2020-05-31 Thread Michael Paquier
Fix use-after-release mistake in currtid() and currtid2() for views This issue has been present since the introduction of this code as of a3519a2 from 2002, and has been found by buildfarm member prion that uses RELCACHE_FORCE_RELEASE via the tests introduced recently in e786be5. Discussion: http

pgsql: Fix use-after-release mistake in currtid() and currtid2() for vi

2020-05-31 Thread Michael Paquier
Fix use-after-release mistake in currtid() and currtid2() for views This issue has been present since the introduction of this code as of a3519a2 from 2002, and has been found by buildfarm member prion that uses RELCACHE_FORCE_RELEASE via the tests introduced recently in e786be5. Discussion: http

pgsql: Fix use-after-release mistake in currtid() and currtid2() for vi

2020-05-31 Thread Michael Paquier
Fix use-after-release mistake in currtid() and currtid2() for views This issue has been present since the introduction of this code as of a3519a2 from 2002, and has been found by buildfarm member prion that uses RELCACHE_FORCE_RELEASE via the tests introduced recently in e786be5. Discussion: http

pgsql: Fix use-after-release mistake in currtid() and currtid2() for vi

2020-05-31 Thread Michael Paquier
Fix use-after-release mistake in currtid() and currtid2() for views This issue has been present since the introduction of this code as of a3519a2 from 2002, and has been found by buildfarm member prion that uses RELCACHE_FORCE_RELEASE via the tests introduced recently in e786be5. Discussion: http

Re: pgsql: Make install-tests target work with vpath builds

2020-05-31 Thread Michael Paquier
Hi Andrew, On Sun, May 31, 2020 at 10:37:17PM +, Andrew Dunstan wrote: > Make install-tests target work with vpath builds > > Also add a top-level install-tests target. > > Backpatch to all live branches. > > Craig Ringer, tweaked by me. Please note that you have forgotten a "Discussion:"