pgsql: Fix intermittent self-test failures caused by the stats_ext test

2019-09-15 Thread Dean Rasheed
Fix intermittent self-test failures caused by the stats_ext test. Commit d7f8d26d9 added new tests to the stats_ext regression test that included creating a view in the public schema, without realising that the stats_ext test runs in the same parallel group as the rules test, which makes doing tha

pgsql: Fix intermittent self-test failures caused by the stats_ext test

2019-09-15 Thread Dean Rasheed
Fix intermittent self-test failures caused by the stats_ext test. Commit d7f8d26d9 added new tests to the stats_ext regression test that included creating a view in the public schema, without realising that the stats_ext test runs in the same parallel group as the rules test, which makes doing tha

pgsql: Fix bogus sizeof calculations.

2019-09-15 Thread Tom Lane
Fix bogus sizeof calculations. Noted by Coverity. Typo in 27cc7cd2b, so back-patch to v12 as that was. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/27bc87985c4135f27bdcddd905baad3b62a3f03a Modified Files -- src/backend/executor/execMain.c | 4

pgsql: Fix bogus sizeof calculations.

2019-09-15 Thread Tom Lane
Fix bogus sizeof calculations. Noted by Coverity. Typo in 27cc7cd2b, so back-patch to v12 as that was. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8122578098d3ff20a9a12d25807e56cecac673c Modified Files -- src/backend/executor/execMain.c | 4 ++-- 1

Re: pgsql: Test pg_atomic_fetch_add_ with variable addend and 16-bit edge c

2019-09-15 Thread Alvaro Herrera
On 2019-Sep-14, Noah Misch wrote: > Test pg_atomic_fetch_add_ with variable addend and 16-bit edge cases. I don't understand this. if (pg_atomic_fetch_add_u32(&var, INT_MAX) != INT_MAX) elog(ERROR, "pg_atomic_add_fetch_u32() #3 wrong"); pg_atomic_fetch_add_u32(&var, 2); /* wra

Re: pgsql: Test pg_atomic_fetch_add_ with variable addend and 16-bit edge c

2019-09-15 Thread Noah Misch
On Sun, Sep 15, 2019 at 01:00:21PM -0300, Alvaro Herrera wrote: > On 2019-Sep-14, Noah Misch wrote: > > Test pg_atomic_fetch_add_ with variable addend and 16-bit edge cases. > > I don't understand this. > > if (pg_atomic_fetch_add_u32(&var, INT_MAX) != INT_MAX) > elog(ERROR, "pg_atomi

Re: pgsql: Test pg_atomic_fetch_add_ with variable addend and 16-bit edge c

2019-09-15 Thread Andres Freund
Hi, On 2019-09-15 15:14:50 -0700, Noah Misch wrote: > On Sun, Sep 15, 2019 at 01:00:21PM -0300, Alvaro Herrera wrote: > > On 2019-Sep-14, Noah Misch wrote: > > > Test pg_atomic_fetch_add_ with variable addend and 16-bit edge cases. > > > > I don't understand this. > > > > if (pg_atomic_fetch