pgsql: Upgrade internal error message to external

2019-06-24 Thread Peter Eisentraut
Upgrade internal error message to external As part of REINDEX CONCURRENTLY, this formerly internal-only error message becomes potentially user-visible (see regression tests), so change from errmsg_internal() to errmsg(), and update comment. Branch -- master Details --- https://git.postgr

pgsql: Drop test user when done with it.

2019-06-24 Thread Tom Lane
Drop test user when done with it. Commit d7f8d26d9 added a test case that created a user, but forgot to drop it again. This is no good; for one thing, it causes repeated "make installcheck" runs to fail. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f3bbe81db

pgsql: Correct obsolete amcheck comments.

2019-06-24 Thread Peter Geoghegan
Correct obsolete amcheck comments. Oversight in commit dd299df8. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b00326df7ad4ab7d21aad3b6fe6558ea6b61897d Modified Files -- contrib/amcheck/verify_nbtree.c | 22 -- 1 file changed, 12 in

pgsql: Further fix ALTER COLUMN TYPE's handling of indexes and index co

2019-06-24 Thread Tom Lane
Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit e76de8861, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying th

pgsql: Further fix ALTER COLUMN TYPE's handling of indexes and index co

2019-06-24 Thread Tom Lane
Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit e76de8861, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying th

pgsql: Further fix ALTER COLUMN TYPE's handling of indexes and index co

2019-06-24 Thread Tom Lane
Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit e76de8861, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying th

pgsql: Further fix ALTER COLUMN TYPE's handling of indexes and index co

2019-06-24 Thread Tom Lane
Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit e76de8861, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying th

pgsql: Further fix ALTER COLUMN TYPE's handling of indexes and index co

2019-06-24 Thread Tom Lane
Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit e76de8861, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying th

pgsql: Further fix ALTER COLUMN TYPE's handling of indexes and index co

2019-06-24 Thread Tom Lane
Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit e76de8861, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying th

pgsql: Correct script name in README file

2019-06-24 Thread Peter Eisentraut
Correct script name in README file Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb8d05bfeca416a970cc33af5915ec7b4f4a2f69 Modified Files -- src/common/unicode/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Update unicode_norm_table.h to Unicode 12.1.0

2019-06-24 Thread Peter Eisentraut
Update unicode_norm_table.h to Unicode 12.1.0 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/82be666ee36842af2a1b81e570bd5578f264de65 Modified Files -- src/include/common/unicode_norm_table.h | 3982 --- 1 file changed, 2017 i

pgsql: Make script output more pgindent compatible

2019-06-24 Thread Peter Eisentraut
Make script output more pgindent compatible Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2cadefbb97ff8e5566476780dc200db06af6ba09 Modified Files -- src/common/unicode/generate-unicode_norm_table.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

pgsql: Purely-cosmetic adjustments in tablecmds.c.

2019-06-24 Thread Tom Lane
Purely-cosmetic adjustments in tablecmds.c. Move ATExecAlterColumnGenericOptions away from where it was unthinkingly dropped, in the middle of a lot of ALTER COLUMN TYPE code. I don't have any high principles about where to put it instead, so let's just put it after ALTER COLUMN TYPE and before A

pgsql: Remove misleading comment from pathnodes.h.

2019-06-24 Thread Thomas Munro
Remove misleading comment from pathnodes.h. As of commit e5253fdc, it is no longer true that the leader always executes the subplan of a Gather Merge node. Remove comment to that effect. Back-patch to 11. Discussion: https://postgr.es/m/CA%2BhUKGJEaZJYezXAOutuiWT%2BfxCA44%2BoKtVPAND2ubLiigR%3D

pgsql: Remove misleading comment from pathnodes.h.

2019-06-24 Thread Thomas Munro
Remove misleading comment from pathnodes.h. As of commit e5253fdc, it is no longer true that the leader always executes the subplan of a Gather Merge node. Remove comment to that effect. Back-patch to 11. Discussion: https://postgr.es/m/CA%2BhUKGJEaZJYezXAOutuiWT%2BfxCA44%2BoKtVPAND2ubLiigR%3D

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- master Details --- h

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL_11_STABLE Details --

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL_10_STABLE Details --

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL9_6_STABLE Details --

pgsql: Don't unset MAKEFLAGS in non-GNU Makefile.

2019-06-24 Thread Thomas Munro
Don't unset MAKEFLAGS in non-GNU Makefile. It's useful to be able to pass down options like -s and -j. Back-patch to 9.5, like commit a76200de. Discussion: https://postgr.es/m/CA%2BhUKG%2Be1M8-BbL%3DPqhTp6oO6XPO6%2Bs9WGQMLfbuZ%3DG9CtzyXg%40mail.gmail.com Branch -- REL9_5_STABLE Details --

pgsql: Add toast-level reloption for vacuum_index_cleanup

2019-06-24 Thread Michael Paquier
Add toast-level reloption for vacuum_index_cleanup a96c41f has introduced the option for heap, but it still lacked the variant to control the behavior for toast relations. While on it, refactor the tests so as they stress more scenarios with the various values that vacuum_index_cleanup can use.

pgsql: Fix thinkos in LookupFuncName() for function name lookups

2019-06-24 Thread Michael Paquier
Fix thinkos in LookupFuncName() for function name lookups This could trigger valgrind failures when doing ambiguous function name lookups when no arguments are provided by the caller. The problem has been introduced in aefeb68, so backpatch to v10. HEAD is fine thanks to the refactoring done in

pgsql: Fix thinkos in LookupFuncName() for function name lookups

2019-06-24 Thread Michael Paquier
Fix thinkos in LookupFuncName() for function name lookups This could trigger valgrind failures when doing ambiguous function name lookups when no arguments are provided by the caller. The problem has been introduced in aefeb68, so backpatch to v10. HEAD is fine thanks to the refactoring done in

Re: pgsql: Drop test user when done with it.

2019-06-24 Thread Dean Rasheed
On Mon, 24 Jun 2019 at 17:37, Tom Lane wrote: > > Drop test user when done with it. > > Commit d7f8d26d9 added a test case that created a user, but forgot > to drop it again. This is no good; for one thing, it causes repeated > "make installcheck" runs to fail. > Ah, I see .. yes, my bad. Thanks