pgsql: Fix docs indentation in pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Fix docs indentation in pgtrgm.sgml 5871b884 introduced pg_trgm.word_similarity_threshold GUC, but its documentation contains wrong indentation. This commit fixes that. Backpatch for easier backpatching of other documentation fixes. Discussion: https://postgr.es/m/4c735d30-ab59-fc0e-45d8-f90eb

pgsql: Add docs of missing GUC to pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Add docs of missing GUC to pgtrgm.sgml be8a7a68 introduced pg_trgm.strict_word_similarity_threshold GUC, but missed docs for that. This commit fixes that. Discussion: https://postgr.es/m/fc907f70-448e-fda3-3aa4-209a59597af0%402ndquadrant.com Author: Ian Barwick Reviewed-by: Masahiko Sawada, Mic

pgsql: Fix operator naming in pg_trgm GUC option descriptions

2019-06-10 Thread Alexander Korotkov
Fix operator naming in pg_trgm GUC option descriptions Descriptions of pg_trgm GUC options have % replaced with %% like it was a printf-like format. But that's not needed since they are just plain strings. This commit fixed that. Backpatch to last supported version since this error present from

pgsql: Fix docs indentation in pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Fix docs indentation in pgtrgm.sgml 5871b884 introduced pg_trgm.word_similarity_threshold GUC, but its documentation contains wrong indentation. This commit fixes that. Backpatch for easier backpatching of other documentation fixes. Discussion: https://postgr.es/m/4c735d30-ab59-fc0e-45d8-f90eb

pgsql: Fix operator naming in pg_trgm GUC option descriptions

2019-06-10 Thread Alexander Korotkov
Fix operator naming in pg_trgm GUC option descriptions Descriptions of pg_trgm GUC options have % replaced with %% like it was a printf-like format. But that's not needed since they are just plain strings. This commit fixed that. Backpatch to last supported version since this error present from

pgsql: Add docs of missing GUC to pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Add docs of missing GUC to pgtrgm.sgml be8a7a68 introduced pg_trgm.strict_word_similarity_threshold GUC, but missed docs for that. This commit fixes that. Discussion: https://postgr.es/m/fc907f70-448e-fda3-3aa4-209a59597af0%402ndquadrant.com Author: Ian Barwick Reviewed-by: Masahiko Sawada, Mic

pgsql: Fix docs indentation in pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Fix docs indentation in pgtrgm.sgml 5871b884 introduced pg_trgm.word_similarity_threshold GUC, but its documentation contains wrong indentation. This commit fixes that. Backpatch for easier backpatching of other documentation fixes. Discussion: https://postgr.es/m/4c735d30-ab59-fc0e-45d8-f90eb

pgsql: Fix operator naming in pg_trgm GUC option descriptions

2019-06-10 Thread Alexander Korotkov
Fix operator naming in pg_trgm GUC option descriptions Descriptions of pg_trgm GUC options have % replaced with %% like it was a printf-like format. But that's not needed since they are just plain strings. This commit fixed that. Backpatch to last supported version since this error present from

pgsql: Add docs of missing GUC to pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Add docs of missing GUC to pgtrgm.sgml be8a7a68 introduced pg_trgm.strict_word_similarity_threshold GUC, but missed docs for that. This commit fixes that. Discussion: https://postgr.es/m/fc907f70-448e-fda3-3aa4-209a59597af0%402ndquadrant.com Author: Ian Barwick Reviewed-by: Masahiko Sawada, Mic

pgsql: Fix operator naming in pg_trgm GUC option descriptions

2019-06-10 Thread Alexander Korotkov
Fix operator naming in pg_trgm GUC option descriptions Descriptions of pg_trgm GUC options have % replaced with %% like it was a printf-like format. But that's not needed since they are just plain strings. This commit fixed that. Backpatch to last supported version since this error present from

pgsql: Fix docs indentation in pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Fix docs indentation in pgtrgm.sgml 5871b884 introduced pg_trgm.word_similarity_threshold GUC, but its documentation contains wrong indentation. This commit fixes that. Backpatch for easier backpatching of other documentation fixes. Discussion: https://postgr.es/m/4c735d30-ab59-fc0e-45d8-f90eb

pgsql: Add docs of missing GUC to pgtrgm.sgml

2019-06-10 Thread Alexander Korotkov
Add docs of missing GUC to pgtrgm.sgml be8a7a68 introduced pg_trgm.strict_word_similarity_threshold GUC, but missed docs for that. This commit fixes that. Discussion: https://postgr.es/m/fc907f70-448e-fda3-3aa4-209a59597af0%402ndquadrant.com Author: Ian Barwick Reviewed-by: Masahiko Sawada, Mic

Re: pgsql: Fix operator naming in pg_trgm GUC option descriptions

2019-06-10 Thread Alexander Korotkov
On Mon, Jun 10, 2019 at 8:19 PM Alexander Korotkov wrote: > Backpatch-through: 9.4 Sorry, this appears to be wrong. Backpatch was needed only to 9.6. In 9.5 and earlier there wasn't GUC option. Threshold was operated just by set_limit()/show_limit() functions. -- Alexander Korotkov Postgre

Re: pgsql: Stop using spelling "nonexistant".

2019-06-10 Thread Robert Haas
This is a good cleanup. I think there is room to hope that further deviations from now-established policy will be practically nonexistant. On Sat, Jun 8, 2019 at 1:13 PM Noah Misch wrote: > > Stop using spelling "nonexistant". > > The documentation used "nonexistent" exclusively, and the source

pgsql: Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (repr

2019-06-10 Thread Alvaro Herrera
Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise) Using PARTITION OF can result in column ordering being changed from the database being dumped, if the partition uses a column layout different from the parent's. It's not pg_dump's job to editorialize on table definitions, so th

pgsql: Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (repr

2019-06-10 Thread Alvaro Herrera
Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise) Using PARTITION OF can result in column ordering being changed from the database being dumped, if the partition uses a column layout different from the parent's. It's not pg_dump's job to editorialize on table definitions, so th

pgsql: Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (repr

2019-06-10 Thread Alvaro Herrera
Make pg_dump emit ATTACH PARTITION instead of PARTITION OF (reprise) Using PARTITION OF can result in column ordering being changed from the database being dumped, if the partition uses a column layout different from the parent's. It's not pg_dump's job to editorialize on table definitions, so th

pgsql: tableam: Fix index_build_range_scan parameter name.

2019-06-10 Thread Robert Haas
tableam: Fix index_build_range_scan parameter name. All of the other code thinks that the 8th parameter is the number of blocks, but this declaration thinks that it's the ending block number. Repair this inconsistency. Patch by me, reviewed by Andres Freund. Discussion: http://postgr.es/m/ca+tg

pgsql: Fix documentation of ALTER TABLE for stored values

2019-06-10 Thread Michael Paquier
Fix documentation of ALTER TABLE for stored values Author: Masahiko Sawada Discussion: https://postgr.es/m/cad21aoaa_gvz002u6kovohu0fsm7ieoczdsqwbd7_kaql0u...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/727e45c8a457ab7378494ff33bf3b50607d303a8 M

pgsql: postgres_fdw: Reorder C includes.

2019-06-10 Thread Etsuro Fujita
postgres_fdw: Reorder C includes. Reorder header files in postgres_fdw.c and connection.c in alphabetical order. Author: Etsuro Fujita Reviewed-by: Alvaro Herrera Discussion: https://postgr.es/m/capmgk17zmnb-eelqu8lmmh2t2ufdbfwnvdefdo5-bpejhpo...@mail.gmail.com Branch -- master Details ---