pgsql: Fix double-phrase typo in message

2019-05-31 Thread Alvaro Herrera
Fix double-phrase typo in message New in 147e3722f7e5. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d22f885f895add7e0184b08a78ba92ff091e36c4 Modified Files -- src/backend/access/table/tableam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Make our perfect hash functions be valid C++.

2019-05-31 Thread Tom Lane
Make our perfect hash functions be valid C++. While C is happy to cast "const void *" to "const unsigned char *" silently, C++ insists on an explicit cast. Since we put these functions into header files, cpluspluscheck whines about that. Add the cast to pacify it. Discussion: https://postgr.es/m

pgsql: Fix assorted header files that failed to compile standalone.

2019-05-31 Thread Tom Lane
Fix assorted header files that failed to compile standalone. We have a longstanding project convention that all .h files should be includable with no prerequisites other than postgres.h. This is tested/relied-on by cpluspluscheck. However, cpluspluscheck has not historically been applied to most

pgsql: Fix C++ incompatibilities in plpgsql's header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in plpgsql's header files. Rename some exposed parameters so that they don't conflict with C++ reserved words. Back-patch to all supported versions. George Tarasov Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE

pgsql: Fix C++ incompatibilities in plpgsql's header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in plpgsql's header files. Rename some exposed parameters so that they don't conflict with C++ reserved words. Back-patch to all supported versions. George Tarasov Discussion: https://postgr.es/m/[email protected] Branch -- master Details

pgsql: Fix C++ incompatibilities in plpgsql's header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in plpgsql's header files. Rename some exposed parameters so that they don't conflict with C++ reserved words. Back-patch to all supported versions. George Tarasov Discussion: https://postgr.es/m/[email protected] Branch -- REL9_4_STABLE

pgsql: Fix C++ incompatibilities in plpgsql's header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in plpgsql's header files. Rename some exposed parameters so that they don't conflict with C++ reserved words. Back-patch to all supported versions. George Tarasov Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE

pgsql: Fix C++ incompatibilities in plpgsql's header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in plpgsql's header files. Rename some exposed parameters so that they don't conflict with C++ reserved words. Back-patch to all supported versions. George Tarasov Discussion: https://postgr.es/m/[email protected] Branch -- REL9_5_STABLE

pgsql: Fix C++ incompatibilities in plpgsql's header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in plpgsql's header files. Rename some exposed parameters so that they don't conflict with C++ reserved words. Back-patch to all supported versions. George Tarasov Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE

pgsql: Fix C++ incompatibilities in ecpg/preproc/ header files.

2019-05-31 Thread Tom Lane
Fix C++ incompatibilities in ecpg/preproc/ header files. There's probably no need to back-patch this, since it seems unlikely that anybody would be inserting C++ code into ecpg's preprocessor. Discussion: https://postgr.es/m/[email protected] Branch -- master Detail

pgsql: Adjust ecpg expected-results files for commit 7640f9312.

2019-05-31 Thread Tom Lane
Adjust ecpg expected-results files for commit 7640f9312. Mea culpa for not rechecking check-world at the last step :-( Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ec66ec8b21d3d779047313ac214fba7bcd29a97c Modified Files -- src/interfac

pgsql: Fix incorrect parameter name in comment

2019-05-31 Thread David Rowley
Fix incorrect parameter name in comment Author: Antonin Houska Discussion: https://postgr.es/m/22370.1559293357@localhost Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/72b6223f766d6ba9076d7b1ebdf05df75e83ba5c Modified Files -- src/include/access/table

pgsql: Integrate cpluspluscheck into build system.

2019-05-31 Thread Andres Freund
Integrate cpluspluscheck into build system. Previously cpluspluscheck wouldn't work in vpath builds, this commit fixes that. To make it easier to invoke, there's a top-level cpluspluscheck target. Discussion: https://postgr.es/[email protected] Branch -- maste

pgsql: Improve coverage of cpluspluscheck.

2019-05-31 Thread Tom Lane
Improve coverage of cpluspluscheck. Formerly, cpluspluscheck was only meant to examine headers that we thought of as exported --- but its notion of what we export was well behind the times. Let's just make it check *all* .h files, except for a well-defined blacklist, instead. While at it, improv