Re: pgsql: Track block level checksum failures in pg_stat_database

2019-05-01 Thread Julien Rouhaud
On Wed, May 1, 2019 at 12:48 AM Julien Rouhaud wrote: > > On Tue, Apr 30, 2019 at 11:56 PM Tom Lane wrote: > > > > Julien Rouhaud writes: > > > On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra > > > wrote: > > >> It seems this commit forgot to add PgStat_MsgChecksumFailure to the > > >> PgStat_Msg

Re: pgsql: Track block level checksum failures in pg_stat_database

2019-05-01 Thread Magnus Hagander
On Wed, May 1, 2019 at 9:56 AM Julien Rouhaud wrote: > On Wed, May 1, 2019 at 12:48 AM Julien Rouhaud wrote: > > > > On Tue, Apr 30, 2019 at 11:56 PM Tom Lane wrote: > > > > > > Julien Rouhaud writes: > > > > On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra > > > > wrote: > > > >> It seems this c

Re: pgsql: Track block level checksum failures in pg_stat_database

2019-05-01 Thread Julien Rouhaud
On Wed, May 1, 2019 at 12:04 PM Magnus Hagander wrote: > > Looks good to me in general > > I don't see the reasoning behind changing the name from msg_autovacuum to > msg_autovacuum_start anywhere, perhaps I missed a part of the discussion? Was > that a change intended to be part of it? That wa

Re: pgsql: Track block level checksum failures in pg_stat_database

2019-05-01 Thread Magnus Hagander
On Wed, May 1, 2019 at 12:12 PM Julien Rouhaud wrote: > On Wed, May 1, 2019 at 12:04 PM Magnus Hagander > wrote: > > > > Looks good to me in general > > > > I don't see the reasoning behind changing the name from msg_autovacuum > to msg_autovacuum_start anywhere, perhaps I missed a part of the >

pgsql: Fix union for pgstat message types

2019-05-01 Thread Magnus Hagander
Fix union for pgstat message types The message type for temp files and for checksum failures were missing from the union. Due to the coding style used there was no compiler error when this happend. So change the code to actively use the union thereby producing a compiler error if the same mistake

Re: pgsql: Track block level checksum failures in pg_stat_database

2019-05-01 Thread Julien Rouhaud
On Wed, May 1, 2019 at 12:35 PM Magnus Hagander wrote: > > On Wed, May 1, 2019 at 12:12 PM Julien Rouhaud wrote: >> >> On Wed, May 1, 2019 at 12:04 PM Magnus Hagander wrote: >> > >> > Looks good to me in general >> > >> > I don't see the reasoning behind changing the name from msg_autovacuum to

pgsql: doc: clarify behavior of pg_upgrade's clone mode

2019-05-01 Thread Bruce Momjian
doc: clarify behavior of pg_upgrade's clone mode Be more precise about the benefits of using clone mode. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/26950273dc27ec7775029cffe1140165f942325d Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 10 +++