pgsql: Fix handling of temp and unlogged tables in FOR ALL TABLES publi

2019-04-18 Thread Peter Eisentraut
Fix handling of temp and unlogged tables in FOR ALL TABLES publications If a FOR ALL TABLES publication exists, temporary and unlogged tables are ignored for publishing changes. But CheckCmdReplicaIdentity() would still check in that case that such a table has a replica identity set before accept

pgsql: Fix handling of temp and unlogged tables in FOR ALL TABLES publi

2019-04-18 Thread Peter Eisentraut
Fix handling of temp and unlogged tables in FOR ALL TABLES publications If a FOR ALL TABLES publication exists, temporary and unlogged tables are ignored for publishing changes. But CheckCmdReplicaIdentity() would still check in that case that such a table has a replica identity set before accept

pgsql: Fix handling of temp and unlogged tables in FOR ALL TABLES publi

2019-04-18 Thread Peter Eisentraut
Fix handling of temp and unlogged tables in FOR ALL TABLES publications If a FOR ALL TABLES publication exists, temporary and unlogged tables are ignored for publishing changes. But CheckCmdReplicaIdentity() would still check in that case that such a table has a replica identity set before accept

Re: pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-04-18 Thread Tom Lane
Amit Langote writes: > On 2019/02/23 2:23, Tom Lane wrote: >> Fix plan created for inherited UPDATE/DELETE with all tables excluded. > I noticed that we may have forgotten to fix one more thing in this commit > -- nominalRelation may refer to a range table entry that's not referenced > elsewhere

pgsql: Fix potential use-after-free for BEFORE UPDATE row triggers on n

2019-04-18 Thread Andres Freund
Fix potential use-after-free for BEFORE UPDATE row triggers on non-core AMs. When such a trigger returns the old row version, it naturally get stored in the slot for the trigger result. When a table AMs doesn't store HeapTuples internally, ExecBRUpdateTriggers() frees the old row version passed to

pgsql: Remove dependency to pageinspect in recovery tests

2019-04-18 Thread Michael Paquier
Remove dependency to pageinspect in recovery tests If contrib/pageinspect is not installed, this causes the test checking the minimum recovery point to fail. The point is that the dependency with pageinspect is not really necessary as the test does also all checks with an offline cluster by scann