pgsql: Return NULL for checksum failures if checksums are not enabled

2019-04-17 Thread Magnus Hagander
Return NULL for checksum failures if checksums are not enabled Returning 0 could falsely indicate that there is no problem. NULL correctly indicates that there is no information about potential problems. Also return 0 as numbackends instead of NULL for shared objects (as no connection can be made

pgsql: Minor jsonpath fixes.

2019-04-17 Thread Tom Lane
Minor jsonpath fixes. Restore missed "make clean" rule, fix misspelling. John Naylor Discussion: https://postgr.es/m/cacpnzct5b8jdccgqifosuqmg-za_ncy4qdiobtlanrih9+-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b4f96d69ad197731c1f5b959e1234c9

pgsql: Fix assorted minor bogosity in GSSAPI transport error messages.

2019-04-17 Thread Tom Lane
Fix assorted minor bogosity in GSSAPI transport error messages. I noted that some buildfarm members were complaining about %ld being used to format values that are (probably) declared size_t. Use %zu instead, and insert a cast just in case some versions of the GSSAPI API declare the length field

pgsql: Fix unportable code in pgbench.

2019-04-17 Thread Tom Lane
Fix unportable code in pgbench. The buildfarm points out that UINT64_FORMAT might not work with sscanf; it's calibrated for our printf implementation, which might not agree with the platform-supplied sscanf. Fall back to just accepting an unsigned long, which is already more than the documentatio

pgsql: Fix unportable code in pgbench.

2019-04-17 Thread Tom Lane
Fix unportable code in pgbench. The buildfarm points out that UINT64_FORMAT might not work with sscanf; it's calibrated for our printf implementation, which might not agree with the platform-supplied sscanf. Fall back to just accepting an unsigned long, which is already more than the documentatio

pgsql: docs: clarify pg_upgrade's recovery behavior

2019-04-17 Thread Bruce Momjian
docs: clarify pg_upgrade's recovery behavior The previous paragraph trying to explain --check, --link, and no --link modes and the various points of failure was too complex. Instead, use bullet lists and sublists. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/qtqiv7hI87s_Xvz5Z

pgsql: docs: clarify pg_upgrade's recovery behavior

2019-04-17 Thread Bruce Momjian
docs: clarify pg_upgrade's recovery behavior The previous paragraph trying to explain --check, --link, and no --link modes and the various points of failure was too complex. Instead, use bullet lists and sublists. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/qtqiv7hI87s_Xvz5Z

pgsql: docs: clarify pg_upgrade's recovery behavior

2019-04-17 Thread Bruce Momjian
docs: clarify pg_upgrade's recovery behavior The previous paragraph trying to explain --check, --link, and no --link modes and the various points of failure was too complex. Instead, use bullet lists and sublists. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/qtqiv7hI87s_Xvz5Z

pgsql: docs: clarify pg_upgrade's recovery behavior

2019-04-17 Thread Bruce Momjian
docs: clarify pg_upgrade's recovery behavior The previous paragraph trying to explain --check, --link, and no --link modes and the various points of failure was too complex. Instead, use bullet lists and sublists. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/qtqiv7hI87s_Xvz5Z

pgsql: docs: clarify pg_upgrade's recovery behavior

2019-04-17 Thread Bruce Momjian
docs: clarify pg_upgrade's recovery behavior The previous paragraph trying to explain --check, --link, and no --link modes and the various points of failure was too complex. Instead, use bullet lists and sublists. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/qtqiv7hI87s_Xvz5Z

pgsql: docs: clarify pg_upgrade's recovery behavior

2019-04-17 Thread Bruce Momjian
docs: clarify pg_upgrade's recovery behavior The previous paragraph trying to explain --check, --link, and no --link modes and the various points of failure was too complex. Instead, use bullet lists and sublists. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/qtqiv7hI87s_Xvz5Z

pgsql: postgresql.conf.sample: add proper defaults for include actions

2019-04-17 Thread Bruce Momjian
postgresql.conf.sample: add proper defaults for include actions Previously, include actions include_dir, include_if_exists, and include listed commented-out values which were not the defaults, which is inconsistent with other entries. Instead, replace them with '', which is the default value. R

pgsql: postgresql.conf.sample: add proper defaults for include actions

2019-04-17 Thread Bruce Momjian
postgresql.conf.sample: add proper defaults for include actions Previously, include actions include_dir, include_if_exists, and include listed commented-out values which were not the defaults, which is inconsistent with other entries. Instead, replace them with '', which is the default value. R

pgsql: postgresql.conf.sample: add proper defaults for include actions

2019-04-17 Thread Bruce Momjian
postgresql.conf.sample: add proper defaults for include actions Previously, include actions include_dir, include_if_exists, and include listed commented-out values which were not the defaults, which is inconsistent with other entries. Instead, replace them with '', which is the default value. R

pgsql: postgresql.conf.sample: add proper defaults for include actions

2019-04-17 Thread Bruce Momjian
postgresql.conf.sample: add proper defaults for include actions Previously, include actions include_dir, include_if_exists, and include listed commented-out values which were not the defaults, which is inconsistent with other entries. Instead, replace them with '', which is the default value. R

pgsql: postgresql.conf.sample: add proper defaults for include actions

2019-04-17 Thread Bruce Momjian
postgresql.conf.sample: add proper defaults for include actions Previously, include actions include_dir, include_if_exists, and include listed commented-out values which were not the defaults, which is inconsistent with other entries. Instead, replace them with '', which is the default value. R

pgsql: postgresql.conf.sample: add proper defaults for include actions

2019-04-17 Thread Bruce Momjian
postgresql.conf.sample: add proper defaults for include actions Previously, include actions include_dir, include_if_exists, and include listed commented-out values which were not the defaults, which is inconsistent with other entries. Instead, replace them with '', which is the default value. R

pgsql: psql: display tablespace for partitioned indexes

2019-04-17 Thread Alvaro Herrera
psql: display tablespace for partitioned indexes Nothing was shown previously. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b036982db786f7ef6c118419e7e832167ad4a6a7 Modified Files -- src/bin/psql/describe.c | 3 ++- src/test/regress/

pgsql: Tie loose ends in psql's new \dP command

2019-04-17 Thread Alvaro Herrera
Tie loose ends in psql's new \dP command * Remove one unnecessary pg_class join in SQL command. Not needed, because we use a regclass cast instead. * Doc: refer to "partitioned relations" rather than specifically tables, since indexes are also displayed. * Rename "On table" column to "Table

pgsql: docs: cleanup/remove/update references to OID column.

2019-04-17 Thread Andres Freund
docs: cleanup/remove/update references to OID column. I (Andres) missed these in 578b229718e8f. Author: Justin Pryzby, editorialized a bit by Andres Freund Reviewed-By: Daniel Verite, Andres Freund Discussion: https://postgr.es/m/[email protected] Branch -- master Details -

pgsql: pg_dump: Remove stray option parsing support for -o.

2019-04-17 Thread Andres Freund
pg_dump: Remove stray option parsing support for -o. I (Andres) missed this in 578b229718e8f, the removal of WITH OIDS support. Author: Daniel Verite Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresq

pgsql: docs: correct typo-ed path to heapam_handler.c.

2019-04-17 Thread Andres Freund
docs: correct typo-ed path to heapam_handler.c. Reported-By: Michael Paquier, Michel Pelletier Discussion: https://postgr.es/m/[email protected] https://postgr.es/m/CACxu=v+u_qtefqdajchv3i4qmzv_63arvb57r19dsktthds...@mail.gmail.com Branch -- master Details --- http

Re: pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-04-17 Thread Amit Langote
On 2019/02/23 2:23, Tom Lane wrote: > Fix plan created for inherited UPDATE/DELETE with all tables excluded. > > In the case where inheritance_planner() finds that every table has > been excluded by constraints, it thought it could get away with > making a plan consisting of just a dummy Result no