pgsql: MSYS: Skip src/test/recovery/t/017_shm.pl.

2019-04-14 Thread Noah Misch
MSYS: Skip src/test/recovery/t/017_shm.pl. Commit 947a35014fdc2ec74cbf06c7dbac6eea6fae90c6 relied on a feature available in v11 and later, so back-patching it to v10 and v9.6 was invalid. In those branches, revert it and skip the test on msys. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIc

pgsql: MSYS: Translate REGRESS_SHLIB to a Windows file name.

2019-04-14 Thread Noah Misch
MSYS: Translate REGRESS_SHLIB to a Windows file name. Per buildfarm member jacana. Back-patch to v11; earlier branches skip the affected test under msys. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@

pgsql: MSYS: Translate REGRESS_SHLIB to a Windows file name.

2019-04-14 Thread Noah Misch
MSYS: Translate REGRESS_SHLIB to a Windows file name. Per buildfarm member jacana. Back-patch to v11; earlier branches skip the affected test under msys. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@

pgsql: MSYS: Skip src/test/recovery/t/017_shm.pl.

2019-04-14 Thread Noah Misch
MSYS: Skip src/test/recovery/t/017_shm.pl. Commit 947a35014fdc2ec74cbf06c7dbac6eea6fae90c6 relied on a feature available in v11 and later, so back-patching it to v10 and v9.6 was invalid. In those branches, revert it and skip the test on msys. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIc

pgsql: Switch TAP tests of pg_rewind to use non-superuser role, take tw

2019-04-14 Thread Michael Paquier
Switch TAP tests of pg_rewind to use non-superuser role, take two Up to now the tests of pg_rewind have been using a superuser for all its tests (which is the default of many tests actually, and something that ought to be reviewed) when involving an online source server, still it is possible to us

Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-14 Thread Michael Paquier
On Sat, Apr 13, 2019 at 11:12:25AM -0400, Alvaro Herrera wrote: > I'm not sure that reverting and re-committing a slightly improved patch > is a better approach than just waiting for the (presumably small) fix to > be committed. Leaving a small number of animals in red for a small > period is not

Re: pgsql: Increase upper limit for vacuum_cleanup_index_scale_factor

2019-04-14 Thread Piotr Stefaniak
On 26/06/2018 14.35, Alexander Korotkov wrote: > Increase upper limit for vacuum_cleanup_index_scale_factor > > Upper limits for vacuum_cleanup_index_scale_factor GUC and reloption > were initially set to 100.0 in 857f9c36. However, after further > discussion, it appears that some users like to d

Re: pgsql: Increase upper limit for vacuum_cleanup_index_scale_factor

2019-04-14 Thread Alexander Korotkov
Hi! On Sun, Apr 14, 2019 at 11:00 PM Piotr Stefaniak wrote: > On 26/06/2018 14.35, Alexander Korotkov wrote: > > Increase upper limit for vacuum_cleanup_index_scale_factor > > > > Upper limits for vacuum_cleanup_index_scale_factor GUC and reloption > > were initially set to 100.0 in 857f9c36. Ho

pgsql: Fix SHOW ALL command for non-superusers with replication connect

2019-04-14 Thread Michael Paquier
Fix SHOW ALL command for non-superusers with replication connection Since Postgres 10, SHOW commands can be triggered with replication connections in a WAL sender context, however it missed that a transaction context is needed for syscache lookups. This commit makes sure that the syscache lookups

pgsql: Fix SHOW ALL command for non-superusers with replication connect

2019-04-14 Thread Michael Paquier
Fix SHOW ALL command for non-superusers with replication connection Since Postgres 10, SHOW commands can be triggered with replication connections in a WAL sender context, however it missed that a transaction context is needed for syscache lookups. This commit makes sure that the syscache lookups

pgsql: Fix SHOW ALL command for non-superusers with replication connect

2019-04-14 Thread Michael Paquier
Fix SHOW ALL command for non-superusers with replication connection Since Postgres 10, SHOW commands can be triggered with replication connections in a WAL sender context, however it missed that a transaction context is needed for syscache lookups. This commit makes sure that the syscache lookups

pgsql: Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port.

2019-04-14 Thread Noah Misch
Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port. Commit c098509927f9a49ebceb301a2cb6a477ecd4ac3c changed PostgresNode::get_new_node() to probe 0.0.0.0 instead of 127.0.0.1, but the new test was less effective for Windows native Perl. This increased the failure rate of buildfarm me

pgsql: Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port.

2019-04-14 Thread Noah Misch
Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port. Commit c098509927f9a49ebceb301a2cb6a477ecd4ac3c changed PostgresNode::get_new_node() to probe 0.0.0.0 instead of 127.0.0.1, but the new test was less effective for Windows native Perl. This increased the failure rate of buildfarm me

pgsql: Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port.

2019-04-14 Thread Noah Misch
Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port. Commit c098509927f9a49ebceb301a2cb6a477ecd4ac3c changed PostgresNode::get_new_node() to probe 0.0.0.0 instead of 127.0.0.1, but the new test was less effective for Windows native Perl. This increased the failure rate of buildfarm me

pgsql: Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port.

2019-04-14 Thread Noah Misch
Test both 0.0.0.0 and 127.0.0.x addresses to find a usable port. Commit c098509927f9a49ebceb301a2cb6a477ecd4ac3c changed PostgresNode::get_new_node() to probe 0.0.0.0 instead of 127.0.0.1, but the new test was less effective for Windows native Perl. This increased the failure rate of buildfarm me