Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-13 Thread Alvaro Herrera
On 2019-Apr-13, Michael Paquier wrote: > On Fri, Apr 12, 2019 at 11:54:48PM -0400, Tom Lane wrote: > > Hm. Seems like that test case could also use some work so that it's > > more obvious when it has connection problems. > > For the problem reported, the deal is that we need to add in > pg_inden

pgsql: Prevent memory leaks associated with relcache rd_partcheck struc

2019-04-13 Thread Tom Lane
Prevent memory leaks associated with relcache rd_partcheck structures. The original coding of generate_partition_qual() just copied the list of predicate expressions into the global CacheMemoryContext, making it effectively impossible to clean up when the owning relcache entry is destroyed --- the

pgsql: Prevent memory leaks associated with relcache rd_partcheck struc

2019-04-13 Thread Tom Lane
Prevent memory leaks associated with relcache rd_partcheck structures. The original coding of generate_partition_qual() just copied the list of predicate expressions into the global CacheMemoryContext, making it effectively impossible to clean up when the owning relcache entry is destroyed --- the

pgsql: Prevent memory leaks associated with relcache rd_partcheck struc

2019-04-13 Thread Tom Lane
Prevent memory leaks associated with relcache rd_partcheck structures. The original coding of generate_partition_qual() just copied the list of predicate expressions into the global CacheMemoryContext, making it effectively impossible to clean up when the owning relcache entry is destroyed --- the

pgsql: When Perl "kill(9, ...)" fails, try "pg_ctl kill".

2019-04-13 Thread Noah Misch
When Perl "kill(9, ...)" fails, try "pg_ctl kill". Per buildfarm member jacana, the former fails under msys Perl 5.8.8. Back-patch to 9.6, like the code in question. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0M

pgsql: When Perl "kill(9, ...)" fails, try "pg_ctl kill".

2019-04-13 Thread Noah Misch
When Perl "kill(9, ...)" fails, try "pg_ctl kill". Per buildfarm member jacana, the former fails under msys Perl 5.8.8. Back-patch to 9.6, like the code in question. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0M

pgsql: When Perl "kill(9, ...)" fails, try "pg_ctl kill".

2019-04-13 Thread Noah Misch
When Perl "kill(9, ...)" fails, try "pg_ctl kill". Per buildfarm member jacana, the former fails under msys Perl 5.8.8. Back-patch to 9.6, like the code in question. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0M

pgsql: When Perl "kill(9, ...)" fails, try "pg_ctl kill".

2019-04-13 Thread Noah Misch
When Perl "kill(9, ...)" fails, try "pg_ctl kill". Per buildfarm member jacana, the former fails under msys Perl 5.8.8. Back-patch to 9.6, like the code in question. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0M