pgsql: Revert "Consistently test for in-use shared memory."

2019-04-05 Thread Noah Misch
Revert "Consistently test for in-use shared memory." This reverts commits 2f932f71d9f2963bbd201129d7b971c8f5f077fd, 16ee6eaf80a40007a138b60bb5661660058d0422 and 6f0e190056fe441f7cf788ff19b62b13c94f68f3. The buildfarm has revealed several bugs. Back-patch like the original commits. Discussion: h

pgsql: Revert "Consistently test for in-use shared memory."

2019-04-05 Thread Noah Misch
Revert "Consistently test for in-use shared memory." This reverts commits 2f932f71d9f2963bbd201129d7b971c8f5f077fd, 16ee6eaf80a40007a138b60bb5661660058d0422 and 6f0e190056fe441f7cf788ff19b62b13c94f68f3. The buildfarm has revealed several bugs. Back-patch like the original commits. Discussion: h

pgsql: Revert "Consistently test for in-use shared memory."

2019-04-05 Thread Noah Misch
Revert "Consistently test for in-use shared memory." This reverts commits 2f932f71d9f2963bbd201129d7b971c8f5f077fd, 16ee6eaf80a40007a138b60bb5661660058d0422 and 6f0e190056fe441f7cf788ff19b62b13c94f68f3. The buildfarm has revealed several bugs. Back-patch like the original commits. Discussion: h

pgsql: Revert "Consistently test for in-use shared memory."

2019-04-05 Thread Noah Misch
Revert "Consistently test for in-use shared memory." This reverts commits 2f932f71d9f2963bbd201129d7b971c8f5f077fd, 16ee6eaf80a40007a138b60bb5661660058d0422 and 6f0e190056fe441f7cf788ff19b62b13c94f68f3. The buildfarm has revealed several bugs. Back-patch like the original commits. Discussion: h

pgsql: Revert "Consistently test for in-use shared memory."

2019-04-05 Thread Noah Misch
Revert "Consistently test for in-use shared memory." This reverts commits 2f932f71d9f2963bbd201129d7b971c8f5f077fd, 16ee6eaf80a40007a138b60bb5661660058d0422 and 6f0e190056fe441f7cf788ff19b62b13c94f68f3. The buildfarm has revealed several bugs. Back-patch like the original commits. Discussion: h

pgsql: Revert "Consistently test for in-use shared memory."

2019-04-05 Thread Noah Misch
Revert "Consistently test for in-use shared memory." This reverts commits 2f932f71d9f2963bbd201129d7b971c8f5f077fd, 16ee6eaf80a40007a138b60bb5661660058d0422 and 6f0e190056fe441f7cf788ff19b62b13c94f68f3. The buildfarm has revealed several bugs. Back-patch like the original commits. Discussion: h

pgsql: Fix compiler warning

2019-04-05 Thread Peter Eisentraut
Fix compiler warning Rewrite get_attgenerated() to avoid compiler warning if the compiler does not recognize that elog(ERROR) does not return. Reported-by: David Rowley Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/edda32ee250fe480701083d4e072e06929991bf9 Modif

Re: pgsql: Generated columns

2019-04-05 Thread Peter Eisentraut
On 2019-04-05 03:47, David Rowley wrote: > On Sat, 30 Mar 2019 at 20:25, Peter Eisentraut wrote: >> src/backend/utils/cache/lsyscache.c | 33 + > > This change has caused a new compiler warning for compilers that don't > understand that elog(ERROR) can't return. > > The attached fixe

pgsql: Doc: Update documentation on partitioning vs. foreign tables.

2019-04-05 Thread Etsuro Fujita
Doc: Update documentation on partitioning vs. foreign tables. The limitations that it is not allowed to create/attach a foreign table as a partition of an indexed partitioned table were not documented. Reported-By: Stepan Yankevych Author: Etsuro Fujita Reviewed-By: Amit Langote Backpatch-through

pgsql: Doc: Update documentation on partitioning vs. foreign tables.

2019-04-05 Thread Etsuro Fujita
Doc: Update documentation on partitioning vs. foreign tables. The limitations that it is not allowed to create/attach a foreign table as a partition of an indexed partitioned table were not documented. Reported-By: Stepan Yankevych Author: Etsuro Fujita Reviewed-By: Amit Langote Backpatch-through

pgsql: table: docs: fix typos and grammar.

2019-04-05 Thread Andres Freund
table: docs: fix typos and grammar. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/86cc06d1cf9c30be3b79207242e6746f0f0b681c Modified Files -- doc/src/sgml/catalo

pgsql: Ensure consistent name matching behavior in processSQLNamePatter

2019-04-05 Thread Tom Lane
Ensure consistent name matching behavior in processSQLNamePattern(). Prior to v12, if you used a collation-sensitive regex feature in a pattern handled by processSQLNamePattern() (for instance, \d '\\w+' in psql), the behavior you got matched the database's default collation. Since commit 586b98fd

pgsql: Fix missing word.

2019-04-05 Thread Robert Haas
Fix missing word. Nathan Bossart Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6665305e17edff3e2c43d71396ea5b6a69e7b6f3 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 2

pgsql: Wake up interested backends when a checkpoint fails.

2019-04-05 Thread Thomas Munro
Wake up interested backends when a checkpoint fails. Commit c6c9474a switched to condition variables instead of sleep loops to notify backends of checkpoint start and stop, but forgot to broadcast in case of checkpoint failure. Author: Thomas Munro Discussion: https://postgr.es/m/CA%2BhUKGJKbCd%

pgsql: Add facility to copy replication slots

2019-04-05 Thread Alvaro Herrera
Add facility to copy replication slots This allows the user to create duplicates of existing replication slots, either logical or physical, and even changing properties such as whether they are temporary or the output plugin used. There are multiple uses for this, such as initializing multiple re

pgsql: Use Append rather than MergeAppend for scanning ordered partitio

2019-04-05 Thread Tom Lane
Use Append rather than MergeAppend for scanning ordered partitions. If we need ordered output from a scan of a partitioned table, but the ordering matches the partition ordering, then we don't need to use a MergeAppend to combine the pre-ordered per-partition scan results: a plain Append will prod

pgsql: Add support TCP user timeout in libpq and the backend server

2019-04-05 Thread Michael Paquier
Add support TCP user timeout in libpq and the backend server Similarly to the set of parameters for keepalive, a connection parameter for libpq is added as well as a backend GUC, called tcp_user_timeout. Increasing the TCP user timeout is useful to allow a connection to survive extended periods w