pgsql: Remove unnecessary use of PROCEDURAL

2019-02-25 Thread Peter Eisentraut
Remove unnecessary use of PROCEDURAL Remove some unnecessary, legacy-looking use of the PROCEDURAL keyword before LANGUAGE. We mostly don't use this anymore, so some of these look a bit old. There is still some use in pg_dump, which is harder to remove because it's baked into the archive format,

pgsql: psql: Remove obsolete code

2019-02-25 Thread Peter Eisentraut
psql: Remove obsolete code The check in create_help.pl for a null end tag () has been obsolete since the conversion from SGML to XML, since XML does not allow that anymore. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b6926dee0e1304368964e1161bfd60dd4b01b25d Mod

pgsql: Correct obsolete nbtree page deletion comment.

2019-02-25 Thread Peter Geoghegan
Correct obsolete nbtree page deletion comment. Commit efada2b8e92, which made the nbtree page deletion algorithm more robust, removed _bt_getstackbuf() calls from _bt_pagedel(). It failed to update a comment that referenced the earlier approach. Update the comment to explain that the _bt_getstac

pgsql: Remove unneeded argument from _bt_getstackbuf().

2019-02-25 Thread Peter Geoghegan
Remove unneeded argument from _bt_getstackbuf(). _bt_getstackbuf() is called at exactly two points following commit efada2b8e92 (one call site is concerned with page splits, while the other is concerned with page deletion). The parent buffer returned by _bt_getstackbuf() is write-locked in both c

pgsql: Simplify some code in pg_rewind when syncing target directory

2019-02-25 Thread Michael Paquier
Simplify some code in pg_rewind when syncing target directory 9a4059d simplified the flush of target data folder when finishing processing, and could have done a bit more. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgre