pgsql: Use EXECUTE FUNCTION syntax for triggers more

2019-02-07 Thread Peter Eisentraut
Use EXECUTE FUNCTION syntax for triggers more Change pg_dump and ruleutils.c to use the FUNCTION keyword instead of PROCEDURE in trigger and event trigger definitions. This completes the pieces of the transition started in 0a63f996e018ac508c858e87fa39cc254a5db49f that were kept out of PostgreSQL

pgsql: Fix searchpath and module location for pg_rewind and ssl TAP tes

2019-02-07 Thread Andrew Dunstan
Fix searchpath and module location for pg_rewind and ssl TAP tests The modules RewindTest.pm and ServerSetup.pm are really only useful for TAP tests, so they really belong in the TAP test directories. In addition, ServerSetup.pm is renamed to SSLServer.pm. The test scripts have their own director

pgsql: Fix searchpath and module location for pg_rewind and ssl TAP tes

2019-02-07 Thread Andrew Dunstan
Fix searchpath and module location for pg_rewind and ssl TAP tests The modules RewindTest.pm and ServerSetup.pm are really only useful for TAP tests, so they really belong in the TAP test directories. In addition, ServerSetup.pm is renamed to SSLServer.pm. The test scripts have their own director

pgsql: Fix searchpath and module location for pg_rewind and ssl TAP tes

2019-02-07 Thread Andrew Dunstan
Fix searchpath and module location for pg_rewind and ssl TAP tests The modules RewindTest.pm and ServerSetup.pm are really only useful for TAP tests, so they really belong in the TAP test directories. In addition, ServerSetup.pm is renamed to SSLServer.pm. The test scripts have their own director

pgsql: Fix searchpath and module location for pg_rewind and ssl TAP tes

2019-02-07 Thread Andrew Dunstan
Fix searchpath and module location for pg_rewind and ssl TAP tests The modules RewindTest.pm and ServerSetup.pm are really only useful for TAP tests, so they really belong in the TAP test directories. In addition, ServerSetup.pm is renamed to SSLServer.pm. The test scripts have their own director

pgsql: Fix searchpath and module location for pg_rewind and ssl TAP tes

2019-02-07 Thread Andrew Dunstan
Fix searchpath and module location for pg_rewind and ssl TAP tests The modules RewindTest.pm and ServerSetup.pm are really only useful for TAP tests, so they really belong in the TAP test directories. In addition, ServerSetup.pm is renamed to SSLServer.pm. The test scripts have their own director

pgsql: Fix perl searchpath for gen_keywordlist.pl

2019-02-07 Thread Andrew Dunstan
Fix perl searchpath for gen_keywordlist.pl as found by running src/tools/perlcheck/pgperlsyncheck Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/51b025933d442823b076e36f4dbe756d25b1a159 Modified Files -- src/tools/gen_keywordlist.pl | 4 1 file cha

pgsql: Ensure that foreign scans with lateral refs are planned correctl

2019-02-07 Thread Tom Lane
Ensure that foreign scans with lateral refs are planned correctly. As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw neglected to mark plain baserel foreign paths as parameterized when the relation has lateral_relids. Other FDWs have surely copied this mistake, so rather th

pgsql: Ensure that foreign scans with lateral refs are planned correctl

2019-02-07 Thread Tom Lane
Ensure that foreign scans with lateral refs are planned correctly. As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw neglected to mark plain baserel foreign paths as parameterized when the relation has lateral_relids. Other FDWs have surely copied this mistake, so rather th

pgsql: Ensure that foreign scans with lateral refs are planned correctl

2019-02-07 Thread Tom Lane
Ensure that foreign scans with lateral refs are planned correctly. As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw neglected to mark plain baserel foreign paths as parameterized when the relation has lateral_relids. Other FDWs have surely copied this mistake, so rather th

pgsql: Ensure that foreign scans with lateral refs are planned correctl

2019-02-07 Thread Tom Lane
Ensure that foreign scans with lateral refs are planned correctly. As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw neglected to mark plain baserel foreign paths as parameterized when the relation has lateral_relids. Other FDWs have surely copied this mistake, so rather th

pgsql: Split create_foreignscan_path() into three functions.

2019-02-07 Thread Tom Lane
Split create_foreignscan_path() into three functions. Up to now postgres_fdw has been using create_foreignscan_path() to generate not only base-relation paths, but also paths for foreign joins and foreign upperrels. This is wrong, because create_foreignscan_path() calls get_baserel_parampathinfo(

pgsql: Ensure that foreign scans with lateral refs are planned correctl

2019-02-07 Thread Tom Lane
Ensure that foreign scans with lateral refs are planned correctly. As reported in bug #15613 from Srinivasan S A, file_fdw and postgres_fdw neglected to mark plain baserel foreign paths as parameterized when the relation has lateral_relids. Other FDWs have surely copied this mistake, so rather th

pgsql: Add pg_partition_root to display top-most parent of a partition

2019-02-07 Thread Michael Paquier
Add pg_partition_root to display top-most parent of a partition tree This is useful when looking at partition trees with multiple layers, and combined with pg_partition_tree, it provides the possibility to show up an entire tree by just knowing one member at any level. Author: Michael Paquier Rev

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-07 Thread Michael Paquier
On Thu, Feb 07, 2019 at 07:52:13AM +, Peter Eisentraut wrote: > Allow some recovery parameters to be changed with reload > > Change > > archive_cleanup_command > promote_trigger_file > recovery_end_command > recovery_min_apply_delay > > from PGC_POSTMASTER to PGC_SIGHUP. This did not requir