pgsql: pg_dump: Fix dumping of WITH OIDS tables

2018-11-13 Thread Peter Eisentraut
pg_dump: Fix dumping of WITH OIDS tables A table with OIDs that was the first in the dump output would not get dumped with OIDs enabled. Fix that. The reason was that the currWithOids flag was declared to be bool but actually also takes a -1 value for "don't know yet". But under stdbool.h seman

pgsql: pg_dump: Fix dumping of WITH OIDS tables

2018-11-13 Thread Peter Eisentraut
pg_dump: Fix dumping of WITH OIDS tables A table with OIDs that was the first in the dump output would not get dumped with OIDs enabled. Fix that. The reason was that the currWithOids flag was declared to be bool but actually also takes a -1 value for "don't know yet". But under stdbool.h seman

pgsql: doc: Fix minor whitespace issue

2018-11-13 Thread Peter Eisentraut
doc: Fix minor whitespace issue Reported-by: David G. Johnston Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d20dceaf50ea093234ef6a66bb2dae485468bea2 Modified Files -- doc/src/sgml/ref/pg_waldump.sgml | 4 +--- 1 file changed, 1 insertion(+), 3 deleti

Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-13 Thread Tom Lane
Thomas Munro writes: > On Tue, Nov 13, 2018 at 6:54 PM Tom Lane wrote: >> Hm, what warnings? > Apple ships OpenLDAP headers that tell you to ditch it and use Apple > OpenDirectory Framework: Oh, that. I just use -Wno-deprecated-declarations. A bigger issue to my mind is that configure bleats

pgsql: Remove unused code in ECPG.

2018-11-13 Thread Tom Lane
Remove unused code in ECPG. scanner_init/scanner_finish weren't actually called from anywhere, and the scanbuf variables they set up weren't used either. Remove unused declaration for mm_realloc, too. John Naylor Discussion: https://postgr.es/m/CAJVSVGWGqY9YBs2EwtRUkbNv=hxkn8yrpood1wxe6cogvvr.

pgsql: Align ECPG lexer more closely with the core and psql lexers.

2018-11-13 Thread Tom Lane
Align ECPG lexer more closely with the core and psql lexers. Make a bunch of basically-cosmetic changes to reduce the diffs between the flex rules in scan.l, psqlscan.l, and pgc.l. Reorder some code, adjust a lot of whitespace, sync some comments, make use of flex start condition scopes to do tha

pgsql: Fix realfailN lexer rules to not make assumptions about input fo

2018-11-13 Thread Tom Lane
Fix realfailN lexer rules to not make assumptions about input format. The realfail1 and realfail2 backup-prevention rules always returned token type FCONST, ignoring the possibility that what we've scanned is more appropriately described as ICONST. I think that at the time that code was added, it

pgsql: Fix incorrect results for numeric data passed through an ECPG SQ

2018-11-13 Thread Tom Lane
Fix incorrect results for numeric data passed through an ECPG SQLDA. Numeric values with leading zeroes were incorrectly copied into a SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs. Report and patch by Daisuke Higuchi. Back-patch to all supported versions. Discussion:

pgsql: Fix incorrect results for numeric data passed through an ECPG SQ

2018-11-13 Thread Tom Lane
Fix incorrect results for numeric data passed through an ECPG SQLDA. Numeric values with leading zeroes were incorrectly copied into a SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs. Report and patch by Daisuke Higuchi. Back-patch to all supported versions. Discussion:

pgsql: Fix incorrect results for numeric data passed through an ECPG SQ

2018-11-13 Thread Tom Lane
Fix incorrect results for numeric data passed through an ECPG SQLDA. Numeric values with leading zeroes were incorrectly copied into a SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs. Report and patch by Daisuke Higuchi. Back-patch to all supported versions. Discussion:

pgsql: Fix incorrect results for numeric data passed through an ECPG SQ

2018-11-13 Thread Tom Lane
Fix incorrect results for numeric data passed through an ECPG SQLDA. Numeric values with leading zeroes were incorrectly copied into a SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs. Report and patch by Daisuke Higuchi. Back-patch to all supported versions. Discussion:

pgsql: Fix incorrect results for numeric data passed through an ECPG SQ

2018-11-13 Thread Tom Lane
Fix incorrect results for numeric data passed through an ECPG SQLDA. Numeric values with leading zeroes were incorrectly copied into a SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs. Report and patch by Daisuke Higuchi. Back-patch to all supported versions. Discussion:

pgsql: Fix incorrect results for numeric data passed through an ECPG SQ

2018-11-13 Thread Tom Lane
Fix incorrect results for numeric data passed through an ECPG SQLDA. Numeric values with leading zeroes were incorrectly copied into a SQLDA (SQL Descriptor Area), leading to wrong results in ECPG programs. Report and patch by Daisuke Higuchi. Back-patch to all supported versions. Discussion:

pgsql: Add INSERT ON CONFLICT test on partitioned tables with transitio

2018-11-13 Thread Alvaro Herrera
Add INSERT ON CONFLICT test on partitioned tables with transition table This case was uncovered by existing tests, so breakage went undetected. Make sure it remains stable. Extracted from a larger patch by Author: David Rowley Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAKJS1f-aGC

pgsql: Refactor code creating PartitionBoundInfo

2018-11-13 Thread Michael Paquier
Refactor code creating PartitionBoundInfo The code building PartitionBoundInfo based on the constituent partition data read from catalogs has been located in partcache.c, with a specific set of routines dedicated to bound types, like sorting or bound data creation. All this logic is moved to part

pgsql: Add flag values in WAL description to all heap records

2018-11-13 Thread Michael Paquier
Add flag values in WAL description to all heap records Hexadecimal is consistently used as format to not bloat too much the output but keep it readable. This information is useful mainly for debugging purposes with for example pg_waldump. Author: Michael Paquier Reviewed-by: Nathan Bossart, Dmit

pgsql: Initialize TransactionState and user ID consistently at transact

2018-11-13 Thread Michael Paquier
Initialize TransactionState and user ID consistently at transaction start If a failure happens when a transaction is starting between the moment the transaction status is changed from TRANS_DEFAULT to TRANS_START and the moment the current user ID and security context flags are fetched via GetUser

pgsql: Initialize TransactionState and user ID consistently at transact

2018-11-13 Thread Michael Paquier
Initialize TransactionState and user ID consistently at transaction start If a failure happens when a transaction is starting between the moment the transaction status is changed from TRANS_DEFAULT to TRANS_START and the moment the current user ID and security context flags are fetched via GetUser

pgsql: Initialize TransactionState and user ID consistently at transact

2018-11-13 Thread Michael Paquier
Initialize TransactionState and user ID consistently at transaction start If a failure happens when a transaction is starting between the moment the transaction status is changed from TRANS_DEFAULT to TRANS_START and the moment the current user ID and security context flags are fetched via GetUser

pgsql: Initialize TransactionState and user ID consistently at transact

2018-11-13 Thread Michael Paquier
Initialize TransactionState and user ID consistently at transaction start If a failure happens when a transaction is starting between the moment the transaction status is changed from TRANS_DEFAULT to TRANS_START and the moment the current user ID and security context flags are fetched via GetUser

pgsql: Initialize TransactionState and user ID consistently at transact

2018-11-13 Thread Michael Paquier
Initialize TransactionState and user ID consistently at transaction start If a failure happens when a transaction is starting between the moment the transaction status is changed from TRANS_DEFAULT to TRANS_START and the moment the current user ID and security context flags are fetched via GetUser

pgsql: Initialize TransactionState and user ID consistently at transact

2018-11-13 Thread Michael Paquier
Initialize TransactionState and user ID consistently at transaction start If a failure happens when a transaction is starting between the moment the transaction status is changed from TRANS_DEFAULT to TRANS_START and the moment the current user ID and security context flags are fetched via GetUser