pgsql: Add ssl_library preset parameter

2018-07-30 Thread Peter Eisentraut
Add ssl_library preset parameter This allows querying the SSL implementation used on the server side. It's analogous to using PQsslAttribute(conn, "library") in libpq. Reviewed-by: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/98efa76fe313f62f8

Re: Tips on committing

2018-07-30 Thread Peter Eisentraut
On 23/07/2018 05:58, Tom Lane wrote: > 013f320dc reminds me of something I check for religiously: look for > alternative output files for any regression test you're updating the > output of. > > Actually updating said files, once you notice you need to, can be tricky > in itself. Most of the time

pgsql: Doc: fix oversimplified example for CREATE POLICY.

2018-07-30 Thread Tom Lane
Doc: fix oversimplified example for CREATE POLICY. As written, this policy constrained only the post-image not the pre-image of rows, meaning that users could delete other users' rows or take ownership of such rows, contrary to what the docs claimed would happen. We need two separate policies to a

pgsql: Doc: fix oversimplified example for CREATE POLICY.

2018-07-30 Thread Tom Lane
Doc: fix oversimplified example for CREATE POLICY. As written, this policy constrained only the post-image not the pre-image of rows, meaning that users could delete other users' rows or take ownership of such rows, contrary to what the docs claimed would happen. We need two separate policies to a

pgsql: Doc: fix oversimplified example for CREATE POLICY.

2018-07-30 Thread Tom Lane
Doc: fix oversimplified example for CREATE POLICY. As written, this policy constrained only the post-image not the pre-image of rows, meaning that users could delete other users' rows or take ownership of such rows, contrary to what the docs claimed would happen. We need two separate policies to a

pgsql: Doc: fix oversimplified example for CREATE POLICY.

2018-07-30 Thread Tom Lane
Doc: fix oversimplified example for CREATE POLICY. As written, this policy constrained only the post-image not the pre-image of rows, meaning that users could delete other users' rows or take ownership of such rows, contrary to what the docs claimed would happen. We need two separate policies to a

pgsql: Doc: fix oversimplified example for CREATE POLICY.

2018-07-30 Thread Tom Lane
Doc: fix oversimplified example for CREATE POLICY. As written, this policy constrained only the post-image not the pre-image of rows, meaning that users could delete other users' rows or take ownership of such rows, contrary to what the docs claimed would happen. We need two separate policies to a

pgsql: Fix pg_dump's failure to dump REPLICA IDENTITY for constraint in

2018-07-30 Thread Tom Lane
Fix pg_dump's failure to dump REPLICA IDENTITY for constraint indexes. pg_dump knew about printing ALTER TABLE ... REPLICA IDENTITY USING INDEX for indexes declared as indexes, but it failed to print that for indexes declared as unique or primary-key constraints. Per report from Achilleas Mantzio

pgsql: Fix pg_dump's failure to dump REPLICA IDENTITY for constraint in

2018-07-30 Thread Tom Lane
Fix pg_dump's failure to dump REPLICA IDENTITY for constraint indexes. pg_dump knew about printing ALTER TABLE ... REPLICA IDENTITY USING INDEX for indexes declared as indexes, but it failed to print that for indexes declared as unique or primary-key constraints. Per report from Achilleas Mantzio

pgsql: Fix pg_dump's failure to dump REPLICA IDENTITY for constraint in

2018-07-30 Thread Tom Lane
Fix pg_dump's failure to dump REPLICA IDENTITY for constraint indexes. pg_dump knew about printing ALTER TABLE ... REPLICA IDENTITY USING INDEX for indexes declared as indexes, but it failed to print that for indexes declared as unique or primary-key constraints. Per report from Achilleas Mantzio

pgsql: Fix pg_dump's failure to dump REPLICA IDENTITY for constraint in

2018-07-30 Thread Tom Lane
Fix pg_dump's failure to dump REPLICA IDENTITY for constraint indexes. pg_dump knew about printing ALTER TABLE ... REPLICA IDENTITY USING INDEX for indexes declared as indexes, but it failed to print that for indexes declared as unique or primary-key constraints. Per report from Achilleas Mantzio

pgsql: Fix pg_dump's failure to dump REPLICA IDENTITY for constraint in

2018-07-30 Thread Tom Lane
Fix pg_dump's failure to dump REPLICA IDENTITY for constraint indexes. pg_dump knew about printing ALTER TABLE ... REPLICA IDENTITY USING INDEX for indexes declared as indexes, but it failed to print that for indexes declared as unique or primary-key constraints. Per report from Achilleas Mantzio

pgsql: Fix pg_dump's failure to dump REPLICA IDENTITY for constraint in

2018-07-30 Thread Tom Lane
Fix pg_dump's failure to dump REPLICA IDENTITY for constraint indexes. pg_dump knew about printing ALTER TABLE ... REPLICA IDENTITY USING INDEX for indexes declared as indexes, but it failed to print that for indexes declared as unique or primary-key constraints. Per report from Achilleas Mantzio

pgsql: doc: Improve CREATE COLLATION locking documentation

2018-07-30 Thread Peter Eisentraut
doc: Improve CREATE COLLATION locking documentation Move out of the concurrency control chapter, where mostly only user table locks are discussed, and move to CREATE COLLATION reference page. Author: Amit Langote Author: Kyotaro HORIGUCHI Branch -- master Details --- https://git.postg

pgsql: Set ActiveSnapshot when logically replaying inserts

2018-07-30 Thread Alvaro Herrera
Set ActiveSnapshot when logically replaying inserts Input functions for the inserted tuples may require a snapshot, when they are replayed by native logical replication. An example is a domain with a constraint using a SQL-language function, which prior to this commit failed to apply on the subsc

pgsql: Set ActiveSnapshot when logically replaying inserts

2018-07-30 Thread Alvaro Herrera
Set ActiveSnapshot when logically replaying inserts Input functions for the inserted tuples may require a snapshot, when they are replayed by native logical replication. An example is a domain with a constraint using a SQL-language function, which prior to this commit failed to apply on the subsc

pgsql: Set ActiveSnapshot when logically replaying inserts

2018-07-30 Thread Alvaro Herrera
Set ActiveSnapshot when logically replaying inserts Input functions for the inserted tuples may require a snapshot, when they are replayed by native logical replication. An example is a domain with a constraint using a SQL-language function, which prior to this commit failed to apply on the subsc

pgsql: Ensure we build generated headers at the start of some more case

2018-07-30 Thread Tom Lane
Ensure we build generated headers at the start of some more cases. "make installcheck" and some related cases, when invoked from the toplevel directory, start out by doing "make all" in src/test/regress. Since that's one make recursion level down, the submake-generated-headers target will do noth

pgsql: Ensure we build generated headers at the start of some more case

2018-07-30 Thread Tom Lane
Ensure we build generated headers at the start of some more cases. "make installcheck" and some related cases, when invoked from the toplevel directory, start out by doing "make all" in src/test/regress. Since that's one make recursion level down, the submake-generated-headers target will do noth

pgsql: Verify range bounds to bms_add_range when necessary

2018-07-30 Thread Alvaro Herrera
Verify range bounds to bms_add_range when necessary Now that the bms_add_range boundary protections are gone, some alternative ones are needed in a few places. Author: Amit Langote Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE D

pgsql: Change bms_add_range to be a no-op for empty ranges

2018-07-30 Thread Alvaro Herrera
Change bms_add_range to be a no-op for empty ranges In commit 84940644de93, bms_add_range was added with an API to fail with an error if an empty range was specified. This seems arbitrary and unhelpful, so turn that case into a no-op instead. Callers that require further verification on the argu

pgsql: Verify range bounds to bms_add_range when necessary

2018-07-30 Thread Alvaro Herrera
Verify range bounds to bms_add_range when necessary Now that the bms_add_range boundary protections are gone, some alternative ones are needed in a few places. Author: Amit Langote Discussion: https://postgr.es/m/[email protected] Branch -- master Details

pgsql: Change bms_add_range to be a no-op for empty ranges

2018-07-30 Thread Alvaro Herrera
Change bms_add_range to be a no-op for empty ranges In commit 84940644de93, bms_add_range was added with an API to fail with an error if an empty range was specified. This seems arbitrary and unhelpful, so turn that case into a no-op instead. Callers that require further verification on the argu

pgsql: Remove dead code left behind by 1b6801051.

2018-07-30 Thread Tom Lane
Remove dead code left behind by 1b6801051. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6574f19127ea539408267c1891ccc12ca5ebeca2 Modified Files -- src/backend/nodes/bitmapset.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

pgsql: Remove dead code left behind by 1b6801051.

2018-07-30 Thread Tom Lane
Remove dead code left behind by 1b6801051. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5a71d3e58333f764b4fc34f3cf93521c964f64f6 Modified Files -- src/backend/nodes/bitmapset.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)