Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes.

2018-02-21 Thread Peter Geoghegan
On Tue, Feb 20, 2018 at 9:34 PM, Andres Freund wrote: > Doesn't appear to have fixed the problem entirely: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2018-02-20%2017%3A10%3A01 > > relevant excerpt: > ==12452== Syscall param write(buf) points to uninitialised byte(s) > ==124

Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes.

2018-02-21 Thread Peter Geoghegan
On Wed, Feb 21, 2018 at 10:55 AM, Peter Geoghegan wrote: > Sure, but it looks like it has the exact same underlying cause to the > LogicalTapeFreeze() issue. It shouldn't be very hard to write an > equivalent patch for LogicalTapeRewindForRead() -- I pointed out that > this could happen there inst

Re: pgsql: Allow UNIQUE indexes on partitioned tables

2018-02-21 Thread David Rowley
On 20 February 2018 at 09:40, Alvaro Herrera wrote: > Modified Files > -- > doc/src/sgml/ddl.sgml | 9 +- Attached is a very small fix to a small error this patch created in the docs. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQ

pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

2018-02-21 Thread Tom Lane
Repair pg_upgrade's failure to preserve relfrozenxid for matviews. This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the pr

pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

2018-02-21 Thread Tom Lane
Repair pg_upgrade's failure to preserve relfrozenxid for matviews. This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the pr

pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

2018-02-21 Thread Tom Lane
Repair pg_upgrade's failure to preserve relfrozenxid for matviews. This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the pr

pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

2018-02-21 Thread Tom Lane
Repair pg_upgrade's failure to preserve relfrozenxid for matviews. This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the pr

pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

2018-02-21 Thread Tom Lane
Repair pg_upgrade's failure to preserve relfrozenxid for matviews. This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the pr

pgsql: Repair pg_upgrade's failure to preserve relfrozenxid for matview

2018-02-21 Thread Tom Lane
Repair pg_upgrade's failure to preserve relfrozenxid for matviews. This oversight led to data corruption in matviews, manifesting as "could not access status of transaction" before our most recent releases, and "found xmin from before relfrozenxid" errors since then. The proximate cause of the pr

pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.

2018-02-21 Thread Robert Haas
Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes. Previously, Append didn't charge anything at all, and MergeAppend charged only cpu_operator_cost, about half the value used here. This change might make MergeAppend plans slightly more likely to be chosen than before, since this commit

Re: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes.

2018-02-21 Thread Tom Lane
Robert Haas writes: > Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes. This seems to have produced some plan instability in the buildfarm. regards, tom lane