Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-15 Thread Rhialto
On Thu 07 Jan 2016 at 18:53:53 +0100, Detlef Graef wrote: > Maybe someone can tell me if the function "c_str()" from std::string can > be simply replaced with "str" from StringView struct? > > See line 72 here: > > https://git.gnome.org/browse/pan2/tree/pan/general/string-view.h I'd say so, yes.

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-13 Thread Petr Kovar
On Thu, 7 Jan 2016 18:53:53 +0100 Detlef Graef wrote: > Am 06.01.2016 um 20:19 schrieb Rhialto: > > > On Wed 06 Jan 2016 at 14:04:10 +0100, Detlef Graef wrote: > >> Is this fix ok? > > > > Disclaimer: I don't know the innards of Pan and I hardly ever use C++, > > but it looks like an improvemen

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-06 Thread Rhialto
On Wed 06 Jan 2016 at 14:21:36 -0700, Zan Lynx wrote: > On 01/06/2016 12:19 PM, Rhialto wrote: > > So keeping every step of the way in the StringView realm is definitely > > better. Whether the actual string storage is safe in the long term, I > > didn't look at, but presumably it is or more things

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-06 Thread Zan Lynx
On 01/06/2016 12:19 PM, Rhialto wrote: > So keeping every step of the way in the StringView realm is definitely > better. Whether the actual string storage is safe in the long term, I > didn't look at, but presumably it is or more things would go wrong > (probably). Whereas I believe the opposite:

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-06 Thread Rhialto
On Wed 06 Jan 2016 at 14:04:10 +0100, Detlef Graef wrote: > Is this fix ok? Disclaimer: I don't know the innards of Pan and I hardly ever use C++, but it looks like an improvement to me. Before, prefs_string is a StringView, which would be converted to a temporary std::string (when returning from

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-05 Thread Duncan
Alan Taylor posted on Tue, 05 Jan 2016 17:53:30 -0400 as excerpted: > Slightly off-topic, I would like to submit a report of a different > annoying bug. (Or search to see if it's already reported.) Where might > instructions be found in how to use Bugzilla for pan bugs. The easiest way to repor

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-05 Thread Alan Taylor
Slightly off-topic, I would like to submit a report of a different annoying bug. (Or search to see if it's already reported.) Where might instructions be found in how to use Bugzilla for pan bugs. (This post should be plain text - I have turned off formatting for it in Gmail. Lets see if that w

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2016-01-05 Thread Zan Lynx
On January 5, 2016 12:12:19 PM MST, Detlef Graef wrote: >Am 29.12.2015 um 03:39 schrieb Duncan: > >> Detlef Graef posted on Mon, 28 Dec 2015 15:53:59 +0100 as excerpted: >> >>> I've some update to this bug: >>> >>> https://bugzilla.gnome.org/show_bug.cgi?id=756458 >>> >>> I've done some (very sim

Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

2015-12-28 Thread Duncan
Detlef Graef posted on Mon, 28 Dec 2015 15:53:59 +0100 as excerpted: > I've some update to this bug: > > https://bugzilla.gnome.org/show_bug.cgi?id=756458 > > I've done some (very simple) debugging. > > At startup Pan reads the value from the string "last-visited-group" from > the preferences.x